fix

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

encodings/datetime-parts/src/compute/cast.rs

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+use vortex_array::Array;
 use vortex_array::ArrayRef;
 use vortex_array::IntoArray;
 use vortex_array::builtins::ArrayBuiltins;
@@ -90,21 +91,17 @@ mod tests {
     #[case(Validity::from_iter([true, false, true]))]
     fn test_bad_cast_fails(#[case] validity: Validity) {
         let array = date_time_array(validity);
-        let result = array.cast(DType::Bool(Nullability::NonNullable));
-        assert!(
-            result.as_ref().is_err_and(|err| err
-                .to_string()
-                .contains("No CastKernel to cast canonical array")),
-            "Got error: {result:?}"
-        );
+        // Cast to incompatible type - force evaluation via to_canonical
+        let result = array
+            .cast(DType::Bool(Nullability::NonNullable))
+            .and_then(|a| a.to_canonical().map(|c| c.into_array()));
+        assert!(result.is_err(), "Expected error, got: {result:?}");
 
-        let result = array.cast(array.dtype().with_nullability(Nullability::NonNullable));
-        assert!(
-            result.as_ref().is_err_and(|err| err
-                .to_string()
-                .contains("invalid values to non-nullable type")),
-            "Got error: {result:?}"
-        );
+        // Cast nullable with nulls to non-nullable - force evaluation via to_canonical
+        let result = array
+            .cast(array.dtype().with_nullability(Nullability::NonNullable))
+            .and_then(|a| a.to_canonical().map(|c| c.into_array()));
+        assert!(result.is_err(), "Expected error, got: {result:?}");
     }
 
     #[rstest]

encodings/decimal-byte-parts/src/decimal_byte_parts/compute/cast.rs

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+use vortex_array::Array;
 use vortex_array::ArrayRef;
 use vortex_array::IntoArray;
 use vortex_array::builtins::ArrayBuiltins;
@@ -86,10 +87,11 @@ mod tests {
         )
         .unwrap();
 
-        // Cast to non-nullable should fail due to nulls
+        // Cast to non-nullable should fail due to nulls - force evaluation via to_canonical
         let result = array
             .to_array()
-            .cast(DType::Decimal(decimal_dtype, Nullability::NonNullable));
+            .cast(DType::Decimal(decimal_dtype, Nullability::NonNullable))
+            .and_then(|a| a.to_canonical().map(|c| c.into_array()));
         assert!(result.is_err());
     }
 

encodings/fastlanes/src/rle/compute/cast.rs

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+use vortex_array::Array;
 use vortex_array::ArrayRef;
 use vortex_array::builtins::ArrayBuiltins;
 use vortex_array::compute::CastReduce;
@@ -42,6 +43,8 @@ impl CastReduce for RLEVTable {
 #[cfg(test)]
 mod tests {
     use rstest::rstest;
+    use vortex_array::Array;
+    use vortex_array::IntoArray;
     use vortex_array::arrays::PrimitiveArray;
     use vortex_array::builtins::ArrayBuiltins;
     use vortex_array::compute::conformance::cast::test_cast_conformance;
@@ -81,6 +84,7 @@ mod tests {
         let rle = RLEArray::encode(&primitive).unwrap();
         rle.to_array()
             .cast(DType::Primitive(PType::U8, Nullability::NonNullable))
+            .and_then(|a| a.to_canonical().map(|c| c.into_array()))
             .unwrap();
     }
 

vortex-array/src/arrays/primitive/array/patch.rs

@@ -10,7 +10,7 @@ use vortex_dtype::match_each_integer_ptype;
 use vortex_dtype::match_each_native_ptype;
 use vortex_error::VortexResult;
 
-use crate::ToCanonical;
+use crate::Array;
 use crate::arrays::PrimitiveArray;
 use crate::patches::PATCH_CHUNK_SIZE;
 use crate::patches::Patches;
@@ -19,8 +19,8 @@ use crate::vtable::ValidityHelper;
 
 impl PrimitiveArray {
     pub fn patch(self, patches: &Patches) -> VortexResult<Self> {
-        let patch_indices = patches.indices().to_primitive();
-        let patch_values = patches.values().to_primitive();
+        let patch_indices = patches.indices().to_canonical()?.into_primitive();
+        let patch_values = patches.values().to_canonical()?.into_primitive();
 
         let patched_validity = self.validity().clone().patch(
             self.len(),