Skip to content

Commit 6e1e9d5

Browse files
fix[ci]: pin nightly for miri (#6448)
## Does this PR closes an open issue or discussion? <!-- This helps us keep track of fixed issues and changes. --> - Closes #. ## What changes are included in this PR? <!-- What changes are included here, if an issue or discussion are attached, there's no need to duplicate the details. --> ## What is the rationale for this change? <!-- Why do you propose this change, and why did you choose this approach. This helps reviewers and other readers understand changes, creates a shared understanding of the issue and codebase, and improves their ability to work with this change and offer better suggestions. --> ## How is this change tested? <!-- Changes should be tested, we expect changes to fit in one of the following categories: 1. Verifying existing behavior is maintained. 2. For serialization related changes - Compatibility should be maintained or explicitly broken. 3. For new behavior and functionality, this helps us maintaining that desired behavior in the future. --> ## Are there any user-facing changes? <!-- Does the change affect users in what of the following ways: 1. Breaks public APIs in some way. 2. Changes the underlying behavior of one of the integrations. 3. Should some documentation be changed to reflect this change? In the case some public API is changed in a breaking way, make sure to add the appropriate label. --> --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
1 parent 493dbb5 commit 6e1e9d5

1 file changed

Lines changed: 15 additions & 14 deletions

File tree

.github/workflows/ci.yml

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ permissions:
2323
env:
2424
CARGO_TERM_COLOR: auto
2525
RUST_BACKTRACE: 1
26+
NIGHTLY_TOOLCHAIN: nightly-2026-02-05
2627

2728
jobs:
2829
lint-toml:
@@ -283,10 +284,10 @@ jobs:
283284
- id: setup-rust
284285
uses: ./.github/actions/setup-rust
285286
with:
286-
toolchain: nightly
287+
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
287288
repo-token: ${{ secrets.GITHUB_TOKEN }}
288289
- name: Rust Lint - Format
289-
run: cargo +nightly fmt --all --check
290+
run: cargo +$NIGHTLY_TOOLCHAIN fmt --all --check
290291
- name: Rustc check
291292
run: RUSTFLAGS="-D warnings" cargo check --locked --all-features --all-targets
292293
- name: Rustc check (release)
@@ -404,7 +405,7 @@ jobs:
404405
env:
405406
RUSTFLAGS: "-Cinstrument-coverage -A warnings --cfg vortex_nightly"
406407
run: |
407-
cargo +nightly nextest run --locked --workspace --all-features --no-fail-fast
408+
cargo +$NIGHTLY_TOOLCHAIN nextest run --locked --workspace --all-features --no-fail-fast
408409
- name: Install llvm-tools-preview
409410
run: rustup component add llvm-tools-preview
410411
- name: Generate coverage report
@@ -463,7 +464,7 @@ jobs:
463464
uses: ./.github/actions/setup-rust
464465
with:
465466
repo-token: ${{ secrets.GITHUB_TOKEN }}
466-
toolchain: nightly
467+
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
467468
components: "rust-src, rustfmt, clippy, llvm-tools-preview"
468469
- name: Install build dependencies
469470
run: |
@@ -478,11 +479,11 @@ jobs:
478479
RUSTFLAGS: "-A warnings -Zsanitizer=address -Zsanitizer=leak --cfg disable_loom --cfg vortex_nightly -C debuginfo=2 -C opt-level=0 -C strip=none"
479480
run: |
480481
# Build with full debug info first (helps with caching)
481-
cargo +nightly build --locked --all-features \
482+
cargo +$NIGHTLY_TOOLCHAIN build --locked --all-features \
482483
--target x86_64-unknown-linux-gnu \
483484
-p vortex-buffer -p vortex-ffi -p vortex-fastlanes -p vortex-fsst -p vortex-alp -p vortex-array
484485
# Run tests with sanitizers and debug output
485-
cargo +nightly nextest run \
486+
cargo +$NIGHTLY_TOOLCHAIN nextest run \
486487
--locked \
487488
--all-features \
488489
--no-fail-fast \
@@ -516,7 +517,7 @@ jobs:
516517
- uses: ./.github/actions/setup-rust
517518
with:
518519
repo-token: ${{ secrets.GITHUB_TOKEN }}
519-
toolchain: nightly
520+
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
520521
components: "rust-src, rustfmt, clippy, llvm-tools-preview"
521522
- name: Install nextest
522523
uses: taiki-e/install-action@v2
@@ -528,9 +529,9 @@ jobs:
528529
FLAT_LAYOUT_INLINE_ARRAY_NODE: true
529530
run: |
530531
# Build with full debug info first (helps with caching)
531-
cargo +nightly build --locked -p vortex-cuda -p vortex-file -p vortex-test-e2e-cuda --all-features --target x86_64-unknown-linux-gnu
532+
cargo +$NIGHTLY_TOOLCHAIN build --locked -p vortex-cuda -p vortex-file -p vortex-test-e2e-cuda --all-features --target x86_64-unknown-linux-gnu
532533
# Run tests with sanitizers and debug output
533-
cargo +nightly nextest run \
534+
cargo +$NIGHTLY_TOOLCHAIN nextest run \
534535
--locked \
535536
-p vortex-file \
536537
-p vortex-cuda \
@@ -557,7 +558,7 @@ jobs:
557558
CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER: compute-sanitizer --tool initcheck --error-exitcode 1
558559
run: cargo test -p vortex-cuda
559560
- name: Build cudf test library
560-
run: cargo +nightly build --locked -p vortex-test-e2e-cuda --target x86_64-unknown-linux-gnu
561+
run: cargo +$NIGHTLY_TOOLCHAIN build --locked -p vortex-test-e2e-cuda --target x86_64-unknown-linux-gnu
561562
- name: Download and run cudf-test-harness
562563
run: |
563564
curl -fsSL https://github.com/vortex-data/cudf-test-harness/releases/latest/download/cudf-test-harness-x86_64.tar.gz | tar -xz
@@ -790,13 +791,13 @@ jobs:
790791
- uses: ./.github/actions/setup-rust
791792
with:
792793
repo-token: ${{ secrets.GITHUB_TOKEN }}
793-
toolchain: nightly
794+
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
794795
components: "rust-src, rustfmt, clippy, miri"
795796
- uses: taiki-e/install-action@v2
796797
with:
797798
tool: nextest
798799
- name: Run Miri
799-
run: cargo +nightly miri nextest run --no-fail-fast -p vortex-buffer -p vortex-ffi
800+
run: cargo +$NIGHTLY_TOOLCHAIN miri nextest run --no-fail-fast -p vortex-buffer -p vortex-ffi
800801

801802
generated-files:
802803
name: "Check generated source files are up to date"
@@ -807,15 +808,15 @@ jobs:
807808
- uses: ./.github/actions/setup-rust
808809
with:
809810
repo-token: ${{ secrets.GITHUB_TOKEN }}
810-
toolchain: nightly
811+
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
811812
- uses: ./.github/actions/setup-flatc
812813
- name: "regenerate all .fbs/.proto Rust code"
813814
run: |
814815
cargo xtask generate-fbs
815816
cargo xtask generate-proto
816817
- name: "regenerate FFI header file"
817818
run: |
818-
cargo +nightly build -p vortex-ffi
819+
cargo +$NIGHTLY_TOOLCHAIN build -p vortex-ffi
819820
- name: "Make sure no files changed after regenerating"
820821
run: |
821822
git status --porcelain

0 commit comments

Comments
 (0)