Merge remote-tracking branch 'origin/ji/fix-up-execute' into ji/fix-up-execute

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/src/arrow/record_batch.rs

@@ -17,19 +17,17 @@ use crate::VortexSessionExecute;
 use crate::array::IntoArray;
 use crate::arrays::StructArray;
 use crate::arrow::ArrowArrayExecutor;
-use crate::validity::Validity;
-
-// deprecated(note = "Use ArrowArrayExecutor::execute_record_batch instead")
 impl TryFrom<&ArrayRef> for RecordBatch {
     type Error = VortexError;
 
+    #[deprecated(note = "Use ArrowArrayExecutor::execute_record_batch instead")]
     fn try_from(value: &ArrayRef) -> VortexResult<Self> {
         let Canonical::Struct(struct_array) = value.to_canonical()? else {
             vortex_bail!("RecordBatch can only be constructed from ")
         };
 
         vortex_ensure!(
-            matches!(struct_array.validity()?, Validity::AllValid),
+            struct_array.validity()?.no_nulls(),
             "RecordBatch can only be constructed from StructArray with no nulls"
         );
 

vortex-array/src/validity.rs

@@ -112,6 +112,13 @@ impl Validity {
         }
     }
 
+    /// Returns `true` if this validity guarantees no null values, i.e. it is either
+    /// [`Validity::NonNullable`] or [`Validity::AllValid`].
+    #[inline]
+    pub fn no_nulls(&self) -> bool {
+        matches!(self, Self::NonNullable | Self::AllValid)
+    }
+
     /// The union nullability and validity.
     #[inline]
     pub fn union_nullability(self, nullability: Nullability) -> Self {