Skip to content

Commit 33e5d06

Browse files
ethanglaserCopilot
andauthored
XFAIL Incremental PCA test 100 column failing test (#3092)
* Revise incremental PCA test sizes for experimentation * Apply suggestion from @ethanglaser * Apply suggestion from @ethanglaser * black * Update onedal/decomposition/tests/test_incremental_pca.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @ethanglaser --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent f202b14 commit 33e5d06

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

onedal/decomposition/tests/test_incremental_pca.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,18 @@ def test_on_gold_data(queue, is_deterministic, whiten, num_blocks, dtype):
113113
@pytest.mark.parametrize("whiten", [True, False])
114114
@pytest.mark.parametrize("num_blocks", [1, 10])
115115
@pytest.mark.parametrize("row_count", [100, 1000])
116-
@pytest.mark.parametrize("column_count", [10, 100])
116+
@pytest.mark.parametrize(
117+
"column_count",
118+
[
119+
10,
120+
pytest.param(
121+
100,
122+
marks=pytest.mark.xfail(
123+
reason="TODO: resolve known NaN location mismatch in IncrementalPCA random-data test for column_count>=row count"
124+
),
125+
),
126+
],
127+
)
117128
@pytest.mark.parametrize("dtype", [np.float32, np.float64])
118129
def test_on_random_data(
119130
queue, n_components, whiten, num_blocks, row_count, column_count, dtype

0 commit comments

Comments
 (0)