Remove unused assignments

Author: mernst

SKIP-REQUIRE-JAVADOC

@@ -0,0 +1 @@
+Delete this file

annotation-file-utilities/src/main/java/org/checkerframework/afu/annotator/find/GenericArrayLocationCriterion.java

@@ -283,7 +283,6 @@ && isSatisfiedBy(
         if (leaf instanceof ParameterizedTypeTree) {
           leaf = parent;
           parentPath = parentPath.getParentPath();
-          parent = parentPath.getLeaf();
         }
         if (!(leaf instanceof MemberSelectTree)) {
           return false;
@@ -294,7 +293,6 @@ && isSatisfiedBy(
           return false;
         }
         locationRemaining.remove(locationRemaining.size() - 1);
-        leaf = fieldAccess.selected;
         pathRemaining = parentPath;
         // TreePath.getPath(pathRemaining.getCompilationUnit(), leaf);
       } else if (loc.step == TypePath.WILDCARD_BOUND

annotation-file-utilities/src/main/java/org/checkerframework/afu/annotator/find/Insertions.java

@@ -516,7 +516,6 @@ private Set<Insertion> organizeTypedInsertions(
             default:
               break;
           }
-          path = path.getParentPath();
         }
       }
 

annotation-file-utilities/src/main/java/org/checkerframework/afu/annotator/scanner/InstanceOfScanner.java

@@ -16,25 +16,6 @@
  */
 public class InstanceOfScanner extends CommonScanner {
 
-  /**
-   * Computes the index of the given instanceof tree amongst all instanceof tree inside its method,
-   * using 0-based indexing.
-   *
-   * @param origpath the path ending in the given instanceof tree
-   * @param tree the instanceof tree to search for
-   * @return the index of the given instanceof tree
-   */
-  public static int indexOfInstanceOfTree(TreePath origpath, Tree tree) {
-    TreePath path = TreePathUtil.findCountingContext(origpath);
-    if (path == null) {
-      return -1;
-    }
-
-    InstanceOfScanner ios = new InstanceOfScanner(tree);
-    ios.scan(path, null);
-    return ios.index;
-  }
-
   private int index = -1;
   private boolean done = false;
   private final Tree tree;
@@ -61,6 +42,25 @@ public Void visitInstanceOf(InstanceOfTree node, Void p) {
     return super.visitInstanceOf(node, null);
   }
 
+  /**
+   * Computes the index of the given instanceof tree amongst all instanceof tree inside its method,
+   * using 0-based indexing.
+   *
+   * @param origpath the path ending in the given instanceof tree
+   * @param tree the instanceof tree to search for
+   * @return the index of the given instanceof tree
+   */
+  public static int indexOfInstanceOfTree(TreePath origpath, Tree tree) {
+    TreePath path = TreePathUtil.findCountingContext(origpath);
+    if (path == null) {
+      return -1;
+    }
+
+    InstanceOfScanner ios = new InstanceOfScanner(tree);
+    ios.scan(path, null);
+    return ios.index;
+  }
+
   // Map from name of a method to a list of bytecode offsets of all
   // instanceof checks in that method.
   private static Map<String, List<Integer>> methodNameToInstanceOfOffsets = new HashMap<>();

annotation-file-utilities/src/main/java/org/checkerframework/afu/scenelib/el/AScene.java

@@ -408,7 +408,10 @@ public static void main(String[] args) {
       System.out.print(args[i] + ": ");
       try {
         IndexFileParser.parseFile(args[i], s0);
-        @SuppressWarnings("UnusedVariable") // testing that clone() does not throw an exception
+        @SuppressWarnings({
+          "UnusedVariable",
+          "PMD.UnusedLocalVariable"
+        }) // testing that clone() does not throw an exception
         AScene ignore = s0.clone();
         System.out.println("ok");
       } catch (Throwable e) {

dataflow/src/main/java/org/checkerframework/dataflow/cfg/ControlFlowGraph.java

@@ -465,7 +465,7 @@ public String toStringDebug() {
     if (astString.length() > 65) {
       astString = "\"" + astString.substring(0, 60) + "\"";
     }
-    result.add("underlyingAST=" + underlyingAST);
+    result.add("underlyingAST=" + astString);
     result.add("treeLookup=" + AnalysisResult.treeLookupToString(treeLookup));
     result.add("convertedTreeLookup=" + AnalysisResult.treeLookupToString(convertedTreeLookup));
     result.add("postfixLookup=" + postfixNodeLookup);