Box arguments to funs if types don't match

Author: tshort

src/codegens.jl

@@ -93,7 +93,7 @@ function codegen!(cg::CodeCtx)
     if !has_terminator(entry)
         LLVM.unreachable!(cg.builder)
     end
-    # LLVM.verify(cg.func)
+    LLVM.verify(cg.func)
     LLVM.dispose(cg.builder)
     return cg.mod
 end
@@ -255,8 +255,12 @@ function codegen!(cg::CodeCtx, ::Val{:invoke}, args, typ)
     end
     llvmargs = LLVM.Value[]
     startpos = isa(args[1], Core.MethodInstance) ? 3 : 2
-    for v in args[startpos:end]
-        push!(llvmargs, codegen!(cg, v))
+    for (i,v) in enumerate(args[startpos:end])
+        a = codegen!(cg, v)
+        if llvmtype(argtypes.parameters[i]) != LLVM.llvmtype(a)  # kludgey?
+            a = emit_box!(cg, v)
+        end
+        push!(llvmargs, a)
     end
     return LLVM.call!(cg.builder, func, llvmargs)
 end

test/broken.jl

@@ -8,26 +8,10 @@ using MicroLogging
 configure_logging(min_level=:info)
 configure_logging(min_level=:debug)
 
-m = codegen(Base.throw_inexacterror,Tuple{Symbol,Type{Int32},Int32})
-verify(m)
-
-# basedump(Base.throw_inexacterror,Tuple{Symbol,Type{Int32},Int32})
-
-# function test_arrays(x)
-#     y = fill(2pi, 5)
-#     push!(y, 3x)
-#     z = reverse(y)
-#     zz = y .+ z.^2
-#     return maximum(zz)
-# end
-# m = codegen(test_arrays, Tuple{Int})
-# verify(m)
 
-
-
-# f(x) = string("a", x)
-# m = codegen(f, Tuple{Int})
-# verify(m)
+f(x) = string("a", x)
+m = codegen(f, Tuple{Int})
+verify(m)