Skip to content

Commit f0c3a21

Browse files
committed
Fix Issue #148
1 parent fcfb90e commit f0c3a21

4 files changed

Lines changed: 38 additions & 5 deletions

File tree

docs/web/release-notes-3.1.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,9 @@ This version is meant to be used with `TFEL` Version 5.1.
2424

2525
Python bindings are now generated using the
2626
[`pybind11`](https://github.com/pybind/pybind11) library.
27+
28+
# Issues fixed
29+
30+
## Issue 148: [doc] better document `rdt` usage
31+
32+
For more details, see <https://github.com/thelfer/MFrontGenericInterfaceSupport/issues/148>.

include/MGIS/Behaviour/BehaviourData.hxx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,17 @@ namespace mgis::behaviour {
9393
* must be computed.
9494
*/
9595
std::vector<real> K;
96-
//! \brief proposed time step increment increase factor
97-
real rdt;
96+
/*!
97+
* \brief proposed time step increment increase factor
98+
*
99+
* The calling solver shall set a suitable value on input
100+
* depending on its policy **before** each call to integrate.
101+
*
102+
* For instance, if the solver want to limit the increase to 20% at most, it
103+
* shall set it to 1.2. But setting it to 1, the solver won't allow the
104+
* behaviour to request an increase of the time step.
105+
*/
106+
real rdt = 1;
98107
//! \brief speed of sound (only computed if requested)
99108
real speed_of_sound = 0;
100109
//! \brief state at the beginning of the time step

include/MGIS/Behaviour/BehaviourDataView.hxx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,16 @@ struct mgis_bv_BehaviourDataView {
9898
* stress with respect to the deformation gradient is returned
9999
*/
100100
mgis_real* K;
101-
//! \brief proposed time step increment increase factor
101+
/*!
102+
* \brief proposed time step increment increase factor
103+
*
104+
* The calling solver shall set a suitable value on input
105+
* depending on its policy **before** each call to integrate.
106+
*
107+
* For instance, if the solver want to limit the increase to 20% at most, it
108+
* shall set it to 1.2. But setting it to 1, the solver won't allow the
109+
* behaviour to request an increase of the time step.
110+
*/
102111
mgis_real* rdt;
103112
//! \brief speed of sound (only computed if requested)
104113
mgis_real* speed_of_sound;

include/MGIS/Behaviour/MaterialDataManager.hxx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,17 @@ namespace mgis::behaviour {
212212
MaterialStateManager s1;
213213
//! \brief view of the stiffness matrices, if required.
214214
std::span<real> K;
215-
//! \brief proposed time step increment increase factor
216-
real rdt;
215+
/*!
216+
* \brief proposed time step increment increase factor
217+
*
218+
* The calling solver shall set a suitable value on input
219+
* depending on its policy **before** each call to integrate.
220+
*
221+
* For instance, if the solver want to limit the increase to 20% at most, it
222+
* shall set it to 1.2. But setting it to 1, the solver won't allow the
223+
* behaviour to request an increase of the time step.
224+
*/
225+
real rdt = 1;
217226
//! \brief view on the speed of sound.
218227
std::span<real> speed_of_sound;
219228
//! \brief number of integration points

0 commit comments

Comments
 (0)