Fix clang warnings

Author: thelfer

cmake/modules/clang.cmake

@@ -9,6 +9,7 @@ tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wno-documentation-unknown-comm
 tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wno-exit-time-destructors")
 tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wno-global-constructors")
 tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wno-missing-braces")
+tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wno-unsafe-buffer-usage")
 tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wrange-loop-analysis")
 tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Wmove")
 tfel_enable_cxx_compiler_flag(COMPILER_WARNINGS  "Winfinite-recursion")

src/BehaviourDataView.cxx

@@ -27,4 +27,4 @@ namespace mgis::behaviour {
     print_markdown(os, b, d.s1, l + 1);
   }  // end of print_markdown
 
-} // end of namespace mgis::behaviour
+} // end of namespace mgis::behaviour

src/BehaviourDescription.cxx

@@ -267,7 +267,7 @@ namespace mgis::behaviour {
         break;
       default:
         raise("unsupported behaviour type");
-    };
+    }
     // behaviour symmetry
     d.symmetry = lm.getBehaviourSymmetry(l, b) == 0
                      ? BehaviourDescription::ISOTROPIC

src/BehaviourIntegrationFailureAnalyser.cxx

@@ -22,7 +22,7 @@ namespace mgis::behaviour::debug {
   BehaviourIntegrationFailureAnalyser::
       ~BehaviourIntegrationFailureAnalyser() noexcept = default;
 
-  std::function<
+  static std::function<
       std::string(std::string_view, std::string_view, std::string_view)>&
   getBehaviourIntegrationFailureAnalysisFileNameGenerator() {
     static std::function<std::string(std::string_view, std::string_view,
@@ -59,7 +59,7 @@ namespace mgis::behaviour::debug {
       if (f) {
         print_markdown(f, b, d, 0);
       }
-    };
+    }
     void analyse(const Behaviour& b,
                  const BehaviourDataView& d) const noexcept override {
       // write inputs to output file
@@ -69,7 +69,7 @@ namespace mgis::behaviour::debug {
       if (f) {
         print_markdown(f, b, d, 0);
       }
-    };
+    }
     bool shallCopyBehaviourDataBeforeIntegration() const noexcept override {
       return true;
     }