Add option to disable auth on streaming endpoint

Author: yux0

common/authorization/interceptor.go

@@ -90,6 +90,7 @@ type Interceptor struct {
 	authExtraHeaderName          string
 	exposeAuthorizerErrors       dynamicconfig.BoolPropertyFn
 	enableCrossNamespaceCommands dynamicconfig.BoolPropertyFn
+	disableStreamingAuthorizer   dynamicconfig.BoolPropertyFn
 }
 
 // NewInterceptor creates an authorization interceptor.
@@ -104,6 +105,7 @@ func NewInterceptor(
 	authExtraHeaderName string,
 	exposeAuthorizerErrors dynamicconfig.BoolPropertyFn,
 	enableCrossNamespaceCommands dynamicconfig.BoolPropertyFn,
+	disableStreamingAuthorizer dynamicconfig.BoolPropertyFn,
 ) *Interceptor {
 	return &Interceptor{
 		claimMapper:                  claimMapper,
@@ -116,6 +118,7 @@ func NewInterceptor(
 		audienceGetter:               audienceGetter,
 		exposeAuthorizerErrors:       exposeAuthorizerErrors,
 		enableCrossNamespaceCommands: enableCrossNamespaceCommands,
+		disableStreamingAuthorizer:   disableStreamingAuthorizer,
 	}
 }
 
@@ -177,34 +180,37 @@ func (a *Interceptor) InterceptStream(
 	handler grpc.StreamHandler,
 ) error {
 	ctx := ss.Context()
-	tlsConnection := TLSInfoFromContext(ctx)
-
-	authInfo := a.GetAuthInfo(tlsConnection, headers.NewGRPCHeaderGetter(ctx), func() string {
-		// JWTAudienceMapper only supports UnaryServerInfo; no request is available at stream init.
-		return ""
-	})
-
-	var claims *Claims
-	if authInfo != nil {
-		var err error
-		claims, err = a.GetClaims(authInfo)
-		if err != nil {
-			a.logger.Error("Authorization error", tag.Error(err))
-			return errUnauthorized
+	bypassAuth := a.disableStreamingAuthorizer()
+	if !bypassAuth {
+		tlsConnection := TLSInfoFromContext(ctx)
+
+		authInfo := a.GetAuthInfo(tlsConnection, headers.NewGRPCHeaderGetter(ctx), func() string {
+			// JWTAudienceMapper only supports UnaryServerInfo; no request is available at stream init.
+			return ""
+		})
+
+		var claims *Claims
+		if authInfo != nil {
+			var err error
+			claims, err = a.GetClaims(authInfo)
+			if err != nil {
+				a.logger.Error("Authorization error", tag.Error(err))
+				return errUnauthorized
+			}
+			ctx = a.EnhanceContext(ctx, authInfo, claims)
 		}
-		ctx = a.EnhanceContext(ctx, authInfo, claims)
-	}
 
-	if a.authorizer != nil {
-		// Namespace is not available in the stream handshake (no initial request body).
-		ct := &CallTarget{
-			Namespace: "",
-			APIName:   info.FullMethod,
-			Request:   nil,
-		}
-		if err := a.Authorize(ctx, claims, ct); err != nil {
-			a.logger.Error("Authorization error", tag.Error(err))
-			return err
+		if a.authorizer != nil {
+			// Namespace is not available in the stream handshake (no initial request body).
+			ct := &CallTarget{
+				Namespace: "",
+				APIName:   info.FullMethod,
+				Request:   nil,
+			}
+			if err := a.Authorize(ctx, claims, ct); err != nil {
+				a.logger.Error("Authorization error", tag.Error(err))
+				return err
+			}
 		}
 	}
 

common/authorization/interceptor_test.go

@@ -84,6 +84,7 @@ func (s *authorizerInterceptorSuite) SetupTest() {
 		"",
 		dynamicconfig.GetBoolPropertyFn(false), // exposeAuthorizerErrors
 		dynamicconfig.GetBoolPropertyFn(false), // enableCrossNamespaceCommands
+		dynamicconfig.GetBoolPropertyFn(false), // disableStreamingAuthorizer
 	)
 	s.handler = func(ctx context.Context, req interface{}) (interface{}, error) { return true, nil }
 }
@@ -159,6 +160,7 @@ func (s *authorizerInterceptorSuite) TestAuthorizationFailedExposed() {
 		"",
 		dynamicconfig.GetBoolPropertyFn(true),  // exposeAuthorizerErrors
 		dynamicconfig.GetBoolPropertyFn(false), // enableCrossNamespaceCommands
+		dynamicconfig.GetBoolPropertyFn(false), // disableStreamingAuthorizer
 	)
 
 	authErr := serviceerror.NewInternal("intentional test failure")
@@ -192,6 +194,7 @@ func (s *authorizerInterceptorSuite) TestNoopClaimMapperWithoutTLS() {
 		"",
 		dynamicconfig.GetBoolPropertyFn(false), // exposeAuthorizerErrors
 		dynamicconfig.GetBoolPropertyFn(false), // enableCrossNamespaceCommands
+		dynamicconfig.GetBoolPropertyFn(false), // disableStreamingAuthorizer
 	)
 	_, err := interceptor.Intercept(ctx, describeNamespaceRequest, describeNamespaceInfo, s.handler)
 	s.NoError(err)
@@ -209,6 +212,7 @@ func (s *authorizerInterceptorSuite) TestAlternateHeaders() {
 		"custom-extra-header",
 		dynamicconfig.GetBoolPropertyFn(false), // exposeAuthorizerErrors
 		dynamicconfig.GetBoolPropertyFn(false), // enableCrossNamespaceCommands
+		dynamicconfig.GetBoolPropertyFn(false), // disableStreamingAuthorizer
 	)
 
 	cases := []struct {
@@ -318,6 +322,7 @@ func (s *authorizerInterceptorSuite) newCrossNamespaceInterceptor(namespaces ...
 		"",
 		dynamicconfig.GetBoolPropertyFn(false), // exposeAuthorizerErrors
 		dynamicconfig.GetBoolPropertyFn(true),  // enableCrossNamespaceCommands
+		dynamicconfig.GetBoolPropertyFn(false), // disableStreamingAuthorizer
 	)
 }
 
@@ -634,6 +639,8 @@ func (s *authorizerInterceptorSuite) TestInterceptStream_AuthDisabled() {
 		"",
 		"",
 		dynamicconfig.GetBoolPropertyFn(false),
+		dynamicconfig.GetBoolPropertyFn(false),
+		dynamicconfig.GetBoolPropertyFn(false),
 	)
 
 	handlerCalled := false
@@ -659,6 +666,8 @@ func (s *authorizerInterceptorSuite) TestInterceptStream_InvalidToken() {
 		"",
 		"",
 		dynamicconfig.GetBoolPropertyFn(false),
+		dynamicconfig.GetBoolPropertyFn(false),
+		dynamicconfig.GetBoolPropertyFn(false),
 	)
 
 	// Provide an incoming context with an auth token so GetAuthInfo returns non-nil.

common/dynamicconfig/constants.go

@@ -149,6 +149,11 @@ for signal / start / signal with start API if namespace is not active`,
 		true,
 		`EnableCrossNamespaceCommands is the key to enable commands for external namespaces`,
 	)
+	DisableStreamingAuthorizer = NewGlobalBoolSetting(
+		"system.disableStreamingAuthorizer",
+		false,
+		`DisableStreamingAuthorizer is the key to disable the auth on streaming endpoint`,
+	)
 	ClusterMetadataRefreshInterval = NewGlobalDurationSetting(
 		"system.clusterMetadataRefreshInterval",
 		time.Minute,

service/frontend/fx.go

@@ -172,6 +172,7 @@ func AuthorizationInterceptorProvider(
 		cfg.Global.Authorization.AuthExtraHeaderName,
 		serviceConfig.ExposeAuthorizerErrors,
 		dynamicconfig.EnableCrossNamespaceCommands.Get(dc),
+		dynamicconfig.DisableStreamingAuthorizer.Get(dc),
 	)
 }
 

service/frontend/nexus_handler_test.go

@@ -128,6 +128,7 @@ func newOperationContext(options contextOptions) *operationContext {
 		"",
 		dynamicconfig.GetBoolPropertyFn(false), // exposeAuthorizerErrors
 		dynamicconfig.GetBoolPropertyFn(false), // enableCrossNamespaceCommands
+		dynamicconfig.GetBoolPropertyFn(false), // disableStreamingAuthorizer
 	)
 	oc.namespaceConcurrencyLimitInterceptor = interceptor.NewConcurrentRequestLimitInterceptor(
 		nil,