Skip to content

Commit 3bac398

Browse files
committed
Init tester object in setUp
1 parent 620326c commit 3bac398

2 files changed

Lines changed: 35 additions & 24 deletions

File tree

tests/phpunit/Commands/IncrementCommandTest.php

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,64 +13,75 @@
1313
class IncrementCommandTest extends TestCase
1414
{
1515
private Commander $commander;
16+
private CommandTester $tester;
1617

1718
public function setUp(): void
1819
{
1920
parent::setUp();
2021

2122
$this->commander = new Commander();
23+
$this->tester = new CommandTester($this->commander->get('increment'));
2224
}
2325

2426
/** @dataProvider dataInvalidVersionArgument */
2527
public function testInvalidVersionArgument(string $version): void
2628
{
27-
$tester = new CommandTester($this->commander->get('increment'));
28-
$tester->execute(['version' => $version]);
29+
$this->tester->execute(['version' => $version]);
2930

3031
self::assertStringContainsString(
3132
sprintf("[ERROR] Version string '%s' is not valid and cannot be parsed", $version),
32-
$tester->getDisplay(),
33+
$this->tester->getDisplay(),
3334
);
3435
}
3536

3637
public function testIncrementPatch(): void
3738
{
38-
$tester = new CommandTester($this->commander->get('increment'));
39-
$tester->execute(['version' => '1.0.0']);
39+
$this->tester->execute(['version' => '1.0.0']);
4040

41-
self::assertStringContainsString('1.0.1', $tester->getDisplay());
41+
self::assertStringContainsString(
42+
'1.0.1',
43+
$this->tester->getDisplay(),
44+
);
4245
}
4346

4447
public function testIncrementMinor(): void
4548
{
46-
$tester = new CommandTester($this->commander->get('increment'));
47-
$tester->execute(['version' => '1.0.0', '--part' => 'minor']);
49+
$this->tester->execute(['version' => '1.0.0', '--part' => 'minor']);
4850

49-
self::assertStringContainsString('1.1.0', $tester->getDisplay());
51+
self::assertStringContainsString(
52+
'1.1.0',
53+
$this->tester->getDisplay(),
54+
);
5055
}
5156

5257
public function testIncrementMajor(): void
5358
{
54-
$tester = new CommandTester($this->commander->get('increment'));
55-
$tester->execute(['version' => '1.0.0', '--part' => 'major']);
59+
$this->tester->execute(['version' => '1.0.0', '--part' => 'major']);
5660

57-
self::assertStringContainsString('2.0.0', $tester->getDisplay());
61+
self::assertStringContainsString(
62+
'2.0.0',
63+
$this->tester->getDisplay(),
64+
);
5865
}
5966

6067
public function testIncrementWithBuildMetadata(): void
6168
{
62-
$tester = new CommandTester($this->commander->get('increment'));
63-
$tester->execute(['version' => '1.0.0', '--build' => '123']);
69+
$this->tester->execute(['version' => '1.0.0', '--build' => '123']);
6470

65-
self::assertStringContainsString('1.0.1+123', $tester->getDisplay());
71+
self::assertStringContainsString(
72+
'1.0.1+123',
73+
$this->tester->getDisplay(),
74+
);
6675
}
6776

6877
public function testIncrementWithPreRelease(): void
6978
{
70-
$tester = new CommandTester($this->commander->get('increment'));
71-
$tester->execute(['version' => '1.0.0', '--pre' => 'beta']);
79+
$this->tester->execute(['version' => '1.0.0', '--pre' => 'beta']);
7280

73-
self::assertStringContainsString('1.0.1-beta', $tester->getDisplay());
81+
self::assertStringContainsString(
82+
'1.0.1-beta',
83+
$this->tester->getDisplay(),
84+
);
7485
}
7586

7687
public static function dataInvalidVersionArgument(): iterable

tests/phpunit/Commands/ValidateCommandTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,35 +13,35 @@
1313
class ValidateCommandTest extends TestCase
1414
{
1515
private Commander $commander;
16+
private CommandTester $tester;
1617

1718
public function setUp(): void
1819
{
1920
parent::setUp();
2021

2122
$this->commander = new Commander();
23+
$this->tester = new CommandTester($this->commander->get('validate'));
2224
}
2325

2426
/** @dataProvider dataInvalidVersionArgument */
2527
public function testInvalidVersionArgument(string $version): void
2628
{
27-
$tester = new CommandTester($this->commander->get('validate'));
28-
$tester->execute(['version' => $version]);
29+
$this->tester->execute(['version' => $version]);
2930

3031
self::assertStringContainsString(
3132
sprintf("[ERROR] Version string '%s' is not valid and cannot be parsed", $version),
32-
$tester->getDisplay(),
33+
$this->tester->getDisplay(),
3334
);
3435
}
3536

3637
/** @dataProvider dataValidVersionArgument */
3738
public function testValidVersionArgument(string $version): void
3839
{
39-
$tester = new CommandTester($this->commander->get('validate'));
40-
$tester->execute(['version' => $version]);
40+
$this->tester->execute(['version' => $version]);
4141

4242
self::assertStringContainsString(
4343
sprintf("[OK] Version string '%s' is valid and can be parsed", $version),
44-
$tester->getDisplay(),
44+
$this->tester->getDisplay(),
4545
);
4646
}
4747

0 commit comments

Comments
 (0)