Add reusable cleanup-releases workflow, remove draft cleanup from cleanup-artifacts

Use synle/gha-workflows cleanup-releases reusable workflow for draft and
incomplete release cleanup. Remove the inline draft release cleanup from
cleanup-artifacts.yml to avoid duplication.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: synle

.github/workflows/cleanup-artifacts.yml

@@ -0,0 +1,105 @@
+name: Cleanup Artifacts & Old Runs
+
+on:
+  schedule:
+    - cron: '0 0 * * 0'
+  workflow_dispatch:
+    inputs:
+      keep_last:
+        description: 'Number of successful builds to keep artifacts from'
+        required: false
+        default: '1'
+        type: number
+      keep_runs_days:
+        description: 'Delete runs older than N days'
+        required: false
+        default: '30'
+        type: number
+
+jobs:
+  cleanup:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Cleanup artifacts and old runs
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const KEEP_LAST = ${{ github.event.inputs.keep_last || 1 }};
+            const KEEP_RUNS_DAYS = ${{ github.event.inputs.keep_runs_days || 30 }};
+            const cutoffDate = new Date(Date.now() - KEEP_RUNS_DAYS * 24 * 60 * 60 * 1000);
+
+            // --- Cleanup Artifacts ---
+            console.log(`\n=== Artifact Cleanup (keeping last ${KEEP_LAST} successful) ===\n`);
+
+            const runs = await github.paginate(
+              github.rest.actions.listWorkflowRunsForRepo,
+              {
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                status: 'success',
+                per_page: 100,
+              }
+            );
+
+            const successRunIds = new Set(runs.map(r => r.id));
+
+            const artifacts = await github.paginate(
+              github.rest.actions.listArtifactsForRepo,
+              {
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                per_page: 100,
+              }
+            );
+
+            const successful = artifacts
+              .filter(a => successRunIds.has(a.workflow_run?.id))
+              .sort((a, b) => new Date(b.created_at) - new Date(a.created_at));
+
+            const failed = artifacts
+              .filter(a => !successRunIds.has(a.workflow_run?.id));
+
+            // Group successful artifacts by run, keep all artifacts from the last N runs
+            const runIds = [...new Set(successful.map(a => a.workflow_run?.id))];
+            const keepRunIds = new Set(runIds.slice(0, KEEP_LAST));
+
+            const toDelete = [
+              ...successful.filter(a => !keepRunIds.has(a.workflow_run?.id)),
+              ...failed,
+            ];
+
+            for (const artifact of toDelete) {
+              console.log(`Deleting artifact: ${artifact.name} (run: ${artifact.workflow_run?.id}, created: ${artifact.created_at})`);
+              await github.rest.actions.deleteArtifact({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                artifact_id: artifact.id,
+              });
+            }
+
+            console.log(`\nArtifacts — Kept runs: ${keepRunIds.size}, Deleted artifacts: ${toDelete.length}`);
+
+            // --- Cleanup Old Workflow Runs ---
+            console.log(`\n=== Workflow Run Cleanup (older than ${KEEP_RUNS_DAYS} days) ===\n`);
+
+            const allRuns = await github.paginate(
+              github.rest.actions.listWorkflowRunsForRepo,
+              {
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                per_page: 100,
+              }
+            );
+
+            const oldRuns = allRuns.filter(r => new Date(r.created_at) < cutoffDate);
+
+            for (const run of oldRuns) {
+              console.log(`Deleting run: #${run.run_number} ${run.name} (${run.status}, created: ${run.created_at})`);
+              await github.rest.actions.deleteWorkflowRun({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                run_id: run.id,
+              });
+            }
+
+            console.log(`\nWorkflow runs deleted: ${oldRuns.length}`);

.github/workflows/cleanup-releases.yml

@@ -0,0 +1,49 @@
+name: cleanup-releases
+
+on:
+  schedule:
+    - cron: "0 0 * * 0"
+  workflow_dispatch:
+    inputs:
+      cleanup_drafts:
+        description: "Delete old draft releases"
+        type: boolean
+        default: true
+      draft_keep_count:
+        description: "Number of most recent draft releases to keep"
+        type: number
+        default: 0
+      cleanup_incomplete:
+        description: "Delete incomplete releases (missing assets)"
+        type: boolean
+        default: true
+      expected_assets:
+        description: "Expected number of assets per release"
+        type: number
+        default: 4
+      lookback_months:
+        description: "How many months back to check for incomplete releases"
+        type: number
+        default: 3
+      dry_run:
+        description: "Preview deletions without actually deleting"
+        type: boolean
+        default: true
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  cleanup:
+    # https://github.com/synle/gha-workflows/blob/main/.github/workflows/cleanup-releases.yml
+    uses: synle/gha-workflows/.github/workflows/cleanup-releases.yml@main
+    permissions:
+      contents: write
+    with:
+      cleanup-drafts: ${{ inputs.cleanup_drafts || true }}
+      draft-keep-count: ${{ inputs.draft_keep_count || 0 }}
+      cleanup-incomplete: ${{ inputs.cleanup_incomplete || true }}
+      expected-assets: ${{ inputs.expected_assets || 4 }}
+      lookback-months: ${{ inputs.lookback_months || 3 }}
+      dry-run: ${{ inputs.dry_run || false }}

CLAUDE.md

@@ -6,62 +6,7 @@ Cross-platform desktop system tray application for controlling monitor brightnes
 
 Display and dark mode operations are delegated to the [display-dj CLI](https://github.com/synle/display-dj-cli), which runs as a bundled HTTP server sidecar. The Tauri backend makes HTTP requests to it. Volume control remains platform-specific in Rust.
 
-## Architecture
-
-### Frontend (`src/`)
-
-- React 18 + TypeScript, bundled with Vite
-- Communicates with backend via `invoke()` from `@tauri-apps/api/core`
-- Listens for backend events via `listen()` from `@tauri-apps/api/event`
-- Components: Header, Slider, MonitorControl, AllMonitorsControl, VolumeControl, DarkModeToggle, SettingsPanel
-- `types.ts` — shared TypeScript interfaces (Monitor, MonitorMetadata, Preferences, KeyBinding, NightModeSchedule, Profile)
-- `types.d.ts` — global type definitions (Command, DisplayType, BrightnessPreset, etc.)
-- `constants.ts` — shared constants (e.g. `LAPTOP_BUILT_IN_DISPLAY_ID`)
-
-### Backend (`src-tauri/src/`)
-
-- `lib.rs` — Tauri app setup, plugin init, sidecar launch (display-dj HTTP server), port discovery, window management, dock hiding (macOS), night mode schedule checker
-- `display.rs` — Monitor brightness and contrast via HTTP requests to the display-dj server
-- `dark_mode.rs` — Dark mode detection and toggling via HTTP requests to the display-dj server
-- `volume.rs` — System volume get/set (platform-specific, not via display-dj)
-- `config.rs` — Preferences persistence (JSON file in OS config dir, includes per-monitor metadata), night mode schedule, min brightness with absolute floor, migration from legacy `monitor-configs.json`, reset to defaults
-- `tray.rs` — System tray menu, window positioning, global keyboard shortcuts
-
-### display-dj CLI sidecar (`src-tauri/binaries/`)
-
-The [display-dj CLI](https://github.com/synle/display-dj-cli) is bundled as a Tauri sidecar. On app startup, `lib.rs` finds an available port (starting from 51337) and spawns `display-dj-server serve <port>`. All display and dark mode operations go through its HTTP API at `http://127.0.0.1:<port>/`.
-
-Key HTTP routes used:
-
-- `GET /get_all` — list all displays with live brightness and contrast
-- `GET /set_one/<id>/<level>` — set one display's brightness
-- `GET /set_all/<level>` — set all displays' brightness
-- `GET /set_contrast_one/<id>/<level>` — set one display's contrast (DDC-only, 0-100)
-- `GET /set_contrast_all/<level>` — set all displays' contrast (DDC-only, 0-100)
-- `GET /dark` / `GET /light` — switch dark/light mode
-- `GET /theme` — get current theme
-- `GET /health` — server health check
-- `GET /debug` — full diagnostics: version, OS/arch, display enumeration, active tests (brightness/contrast per display, volume, theme). Restores all settings after testing. Returns JSON.
-
-**Sidecar lifecycle:** The `CommandChild` handle is stored in `AppState.sidecar_child`. On app exit, the `RunEvent::Exit` handler in `lib.rs::run()` calls `child.kill()` to terminate the sidecar server. This prevents orphaned `display-dj-server` processes after the main app closes.
-
-Sidecar binaries follow Tauri's naming convention:
-
-```
-src-tauri/binaries/
-  display-dj-server-aarch64-apple-darwin      # macOS ARM
-  display-dj-server-x86_64-apple-darwin       # macOS Intel
-  display-dj-server-x86_64-pc-windows-msvc.exe  # Windows x64
-  display-dj-server-x86_64-unknown-linux-gnu  # Linux x64
-```
-
-### Volume (platform-specific)
-
-Volume is the only module with platform-specific code, as the display-dj CLI does not handle volume:
-
-- **macOS**: `osascript` (CoreAudio)
-- **Windows**: PowerShell + WASAPI COM interop
-- **Linux**: `pactl` (PulseAudio/PipeWire)
+For full architecture details, request lifecycle, layer-by-layer breakdown, data flow diagrams, and "where to edit" reference, see **[DEV.md](DEV.md)**.
 
 ## Build Commands
 
@@ -100,23 +45,6 @@ cd src-tauri && cargo test  # Run all Rust backend tests
 
 GitHub Actions (`build.yml`) runs `npm test` and `cargo test` on all platforms (macOS ARM/Intel, Windows, Linux) for every push and PR.
 
-## Config File Locations
-
-- **macOS**: `~/Library/Application Support/display-dj/`
-- **Windows**: `%APPDATA%/display-dj/`
-- **Linux**: `~/.config/display-dj/`
-
-Files: `preferences.json` (includes per-monitor metadata — labels, sort order — as `monitorConfigs` array)
-
-## Monitor Identity (UID scheme)
-
-Each monitor is identified by a composite UID: `{api_id}::{api_model_name}` (e.g. `"1::Dell U2723QE"`, `"builtin::Built-in Display"`). This is more stable than the raw integer ID from the sidecar API, which can collide when monitors are swapped.
-
-- `Monitor.id` — raw API id, used for sidecar HTTP calls (`/set_one/{id}/{value}`)
-- `Monitor.uid` — composite key, used for config lookups, React keys, rename/reorder operations
-- `MonitorMetadata` entries in `preferences.monitorConfigs` are **append-only** — new monitors are added on first detection, never removed on unplug. This preserves labels and sort order across plug/unplug cycles.
-- On startup, a one-time migration converts old `monitor-configs.json` entries into `MonitorMetadata` format within preferences.
-
 ## Formatting
 
 After making changes to frontend code (`src/`), config files, or docs, always run `npx prettier --write` on the changed files before considering the task done. The prettier hook in `.claude/settings.json` handles this automatically for Edit/Write tool calls, but if you create or modify files via other means, run prettier manually.
@@ -139,43 +67,6 @@ After making changes to frontend code (`src/`), config files, or docs, always ru
 - Brightness values are clamped to `effective_min_brightness()` which enforces an absolute floor of 5
 - Contrast is DDC-only (`Option<u32>` / `number | null`): built-in displays return `null`. The contrast slider is hidden by default and toggled via the `showContrast` preference in Settings
 
-## Window Positioning (multi-monitor DPI)
-
-The tray popup window must appear next to the tray icon, which can be on any monitor with any DPI scale factor. This is deceptively hard because of how Tauri handles coordinates on macOS. **Read the doc comment on `position_window_near_tray` in `tray.rs` before modifying positioning code.**
-
-### The coordinate spaces
-
-| API                                     | Returns                             | Coordinate space                                             |
-| --------------------------------------- | ----------------------------------- | ------------------------------------------------------------ |
-| `tray.rect()`                           | `PhysicalPosition` / `PhysicalSize` | Global physical pixels                                       |
-| `monitor.position()` / `monitor.size()` | `PhysicalPosition` / `PhysicalSize` | Global physical pixels                                       |
-| `window.set_position(PhysicalPosition)` | —                                   | Tauri divides by `window.scale_factor()` to get macOS points |
-| `window.scale_factor()`                 | `f64`                               | Scale of the monitor the window is **currently** on          |
-
-### The pitfall
-
-`window.scale_factor()` reflects the **current** monitor, not the target. When the window is on a 1× display and the tray is clicked on a 2× display, Tauri's `set_position` divides by 1 instead of 2, placing the window at double the intended macOS-point coordinate (off-screen).
-
-**Attempted fix that does NOT work:** moving the hidden window to the target monitor before positioning. `scale_factor()` does not update synchronously after `set_position`.
-
-### The fix: scale compensation
-
-All positioning math runs in the global physical pixel space using `target_scale` (the tray's monitor). Before calling `set_position`, multiply by `window_scale / target_scale`:
-
-```
-Tauri does:     point = arg / window_scale
-We need:        point = physical / target_scale
-So we pass:     arg = physical × window_scale / target_scale
-```
-
-When both scales match (same monitor), the compensation is 1× (no-op).
-
-### Debug logging
-
-Enable debug logging via the tray menu → "Debug" → "Enable Logging" to write positioning data to `debug.log` in the config directory (auto-truncated at 1 MB, keeps last 80% when limit is hit). Open via tray menu → "Debug" → "Open Debug Log". Each tray click logs: tray rect, all monitors (position/size/scale), target selection, window scale, computed position, compensation factor, and final `set_position` arguments.
-
-When debug logging is enabled, the app also calls the sidecar's `/debug` endpoint on startup and prepends the full diagnostic dump (version, OS, display enumeration, active brightness/contrast/volume/theme tests) to the debug log. This is useful for troubleshooting display detection issues. You can also hit the endpoint directly: `curl http://127.0.0.1:<port>/debug`.
-
 ## Related Projects
 
 - **[display-dj-cli](https://github.com/synle/display-dj-cli)** — The Rust CLI/HTTP server that handles all display operations (brightness, contrast, dark mode). Bundled as a Tauri sidecar. Source at `/Users/syle/Downloads/display-dj-cli`. When bumping the sidecar version, always review upstream changes in that repo.