Add rector to reduce known boolean and forms

Author: john-shaffer

rector.php

@@ -2,6 +2,7 @@
 
 require_once __DIR__ . '/util/rector/RemoveAlwaysFalseIfStatementRector.php';
 require_once __DIR__ . '/util/rector/RemoveAlwaysTrueIfConditionRector2.php';
+require_once __DIR__ . '/util/rector/ReduceKnownBooleanAnd.php';
 require_once __DIR__ . '/util/rector/ReplaceKnownDefinedWithBooleanRector.php';
 require_once __DIR__ . '/util/rector/ReplaceNegatedBooleanRector.php';
 
@@ -17,6 +18,7 @@
 use Rector\Php53\Rector\Ternary\TernaryToElvisRector;
 use Rector\Set\ValueObject\SetList;
 use Rector\Transform\Rector\BooleanNot\ReplaceNegatedBooleanRector;
+use StaticDeploy\Rector\ReduceKnownBooleanAnd;
 
 // Search rules at https://getrector.com/find-rule
 
@@ -39,6 +41,7 @@
         [
             RemoveAlwaysFalseIfStatementRector::class,
             RemoveAlwaysTrueIfConditionRector2::class,
+            ReduceKnownBooleanAnd::class,
             ReplaceKnownDefinedWithBooleanRector::class,
             ReplaceNegatedBooleanRector::class,
         ]

util/rector/ReduceKnownBooleanAnd.php

@@ -0,0 +1,103 @@
+<?php
+
+declare(strict_types=1);
+
+namespace StaticDeploy\Rector;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
+use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Name;
+use Rector\DeadCode\NodeAnalyzer\SafeLeftTypeBooleanAndOrAnalyzer;
+use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class ReduceKnownBooleanAnd extends AbstractRector
+{
+    public function __construct(
+        private readonly SafeLeftTypeBooleanAndOrAnalyzer $safeLeftTypeBooleanAndOrAnalyzer,
+        private readonly ValueResolver $valueResolver
+    ) {
+    }
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition('Remove `and true` that has no added value', [
+            new CodeSample(
+                <<<'CODE_SAMPLE'
+class SomeClass
+{
+    public function run()
+    {
+        return true && 5 === 1;
+    }
+}
+CODE_SAMPLE
+                ,
+                <<<'CODE_SAMPLE'
+class SomeClass
+{
+    public function run()
+    {
+        return 5 === 1;
+    }
+}
+CODE_SAMPLE
+            ),
+        ]);
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [BooleanAnd::class];
+    }
+
+    /**
+     * @param BooleanAnd $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if ($this->isTrueOrBooleanAndTrues($node->right)) {
+            return $node->left;
+        }
+
+        if (! $this->safeLeftTypeBooleanAndOrAnalyzer->isSafe($node)) {
+            return null;
+        }
+
+        $conditionStaticType = $this->getType($node->left);
+
+        if ($conditionStaticType->isFalse()->yes()) {
+            return new ConstFetch(new Name('false'));
+        }
+
+        if ($conditionStaticType->isTrue()->yes()) {
+            return $node->right;
+        }
+
+        return null;
+    }
+
+    private function isTrueOrBooleanAndTrues(Expr $expr): bool
+    {
+        if ($this->valueResolver->isTrue($expr)) {
+            return true;
+        }
+
+        if (! $expr instanceof BooleanAnd) {
+            return false;
+        }
+
+        if (! $this->isTrueOrBooleanAndTrues($expr->left)) {
+            return false;
+        }
+
+        return $this->isTrueOrBooleanAndTrues($expr->right);
+    }
+}