lints

Author: john-shaffer

src/Local/LocalDeployer.php

@@ -69,7 +69,7 @@ public function uploadFilesIter( \Iterator $path_infos ): void {
             WsLog::d( 'Site dir: ' . $site_dir );
         }
 
-        if ( mb_strpos( (string) $out_dir, (string) $site_dir ) === 0 ) {
+        if ( mb_strpos( $out_dir, $site_dir ) === 0 ) {
             $msg = 'Local deployment directory must be outside of the WordPress directory: '
                 . $out_dir;
             if ( defined( 'STATIC_DEPLOY_ESCAPE_EXCEPTIONS' )

src/PostProcessConfig.php

@@ -30,7 +30,7 @@ public function __construct() {
 
         $wordpress_site_url = untrailingslashit( $this->site_url );
         $destination_url = untrailingslashit( $this->destination_url );
-        $destination_url_c = addcslashes( (string) $destination_url, '/' );
+        $destination_url_c = addcslashes( $destination_url, '/' );
         $destination_url_rel = URLHelper::getProtocolRelativeURL( $destination_url );
         $destination_url_rel_c = addcslashes( $destination_url_rel, '/' );
 

src/SiteInfo.php

@@ -82,7 +82,7 @@ public function __construct() {
      * @throws StaticDeployException
      */
     public static function getPath( string $name ): string {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
@@ -114,7 +114,7 @@ public static function getPath( string $name ): string {
      * @throws StaticDeployException
      */
     public static function getUrl( string $name ): string {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
@@ -139,15 +139,15 @@ public static function getUrl( string $name ): string {
     // TODO Use WP_Http 'curl_enabled' => $this->hasCurlSupport(),
     // didn't see the method vailable in WP_Http
     public static function hasCURLSupport(): bool {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
         return extension_loaded( 'curl' );
     }
 
     public static function isUploadsWritable(): bool {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
@@ -160,7 +160,7 @@ public static function isUploadsWritable(): bool {
     }
 
     public static function permalinksAreCompatible(): bool {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
@@ -173,7 +173,7 @@ public static function permalinksAreCompatible(): bool {
     }
 
     public static function getPermalinks(): string {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
@@ -191,7 +191,7 @@ public static function getPermalinks(): string {
      * @throws StaticDeployException
      */
     public static function getSiteURLHost(): string {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }
 
@@ -219,7 +219,7 @@ public static function getSiteURLHost(): string {
      *  @return mixed[]
      */
     public static function getAllInfo(): array {
-        if ( self::$instance === null ) {
+        if ( ! self::$instance instanceof SiteInfo ) {
             self::$instance = new SiteInfo();
         }