ps_point.hpp:27 — reserve doesn't account for existing vector size

[andrepfeuffer]

names.reserve(q.size() + p.size() + g.size());
If names already contains elements, this may under-reserve. Should be
names.reserve(names.size() + q.size() + p.size() + g.size()). Same issue on
line 37 for values.

[nhuurre]

This is a real issue. names is nonempty on the last line here:

stan/src/stan/services/util/mcmc_writer.hpp

Lines 159 to 167 in 450f974

	std::vector<std::string> names;
	sample.get_sample_param_names(names);
	sampler.get_sampler_param_names(names);
	std::vector<std::string> model_names;
	model.unconstrained_param_names(model_names, false, false);
	sampler.get_sampler_diagnostic_names(model_names, names);