add unit test for isSolidus function

Author: localjo

Gruntfile.js

@@ -33,8 +33,6 @@ module.exports = function(grunt) {
 
   grunt.registerTask('default', ['jshint', 'jasmine']);
   grunt.registerTask('test', ['jshint', 'jasmine']);
-
-  //TODO: Add Jasmine tests to build task
-  grunt.registerTask('build', ['jshint', 'run:crxmake']);
+  grunt.registerTask('build', ['jshint', 'jasmine', 'run:crxmake']);
 
 };

dist/devtools-solidus-0.1.0.crx

@@ -41,7 +41,11 @@ function notifyDevtools(msgType, payload) {
 }
 
 function isSolidus(xpbHeader) {
-    return xpbHeader.match(/Solidus/i);
+  if (xpbHeader.match(/Solidus/i)) {
+    return true;
+  } else {
+    return false;
+  }
 }
 
 function getJsonResource(tabID) {

extension/background.js

@@ -10,15 +10,17 @@
 
 var inspector;
 
-var socket = io('http://localhost:8081');
-socket.on('connect', function(){
-  socket.on('log', function(data){
-    addToLog(data.message);
-    });
-  socket.on('disconnect', function(){
-    document.querySelector('#serverlogs').innerHTML = 'Socket Disconnected';
-    });
-});
+if (typeof io !== 'undefined') {
+  var socket = io('http://localhost:8081');
+  socket.on('connect', function(){
+    socket.on('log', function(data){
+      addToLog(data.message);
+      });
+    socket.on('disconnect', function(){
+      document.querySelector('#serverlogs').innerHTML = 'Socket Disconnected';
+      });
+  });
+}
 
 function processMainIncomingMessage(msg) {
   switch(msg.msgType) {
@@ -100,17 +102,23 @@ function updateStatus(status) { //Update status panel in footer
 }
 
 function addToLog(msg) {
-  var logContainer = document.querySelector('#serverlogs');
-  logContainer.innerHTML += msg + '\n';
-  logContainer.scrollTop = logContainer.scrollHeight;
+  if (document.querySelector('#serverlogs')) {
+    var logContainer = document.querySelector('#serverlogs');
+    logContainer.innerHTML += msg + '\n';
+    logContainer.scrollTop = logContainer.scrollHeight;
+  }
 }
 
 function clearLog() {
   document.querySelector('#serverlogs').innerHTML = '';
 }
 
-window.onload = function() {
-  var clearButton = document.querySelector('#logclear');
-  clearButton.addEventListener('click', clearLog, false);
-  $('#sidePanel').resizable({ minWidth: 120, handles: 'e'});
-};
+window.addEventListener('load', function() {
+  if (document.querySelector('#logclear')) {
+    var clearButton = document.querySelector('#logclear');
+    clearButton.addEventListener('click', clearLog, false);
+  }
+  if (document.querySelector('#sidePanel')) {
+    $('#sidePanel').resizable({ minWidth: 120, handles: 'e'});
+  }
+}, false);

extension/devpanel.js

@@ -1,3 +1,9 @@
+describe("Jasmine", function() {
+  it("successfully runs tests", function() {
+    expect(true).toBe(true);
+  });
+});
+
 describe("Getting page context JSON", function() {
   it("Checks that header contains 'Solidus'", function() {
     var headerValue = isSolidus('Solidus');