feat(secrets): persist and run Secrets with other scanners [IDE-1747] (#791)

* feat(secrets): persist and run Secrets with other scanners [IDE-1747]

- Add activateSnykSecrets to SaveConfigRequest and apply in SaveConfigHandler
- Add activateSnykSecrets to LanguageServerSettings and getSettings()
- Add secretsResults to TreeFiltering and matchFilteringWithEnablement
- Add Secrets scan action to SnykTreeScanTypeFilterActionGroup

Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(ui): add Secrets root to tool window tree and fix clean-all [IDE-1747]

- Add RootSecretsIssuesTreeNode and SECRETS_ROOT_TEXT; tree shows four roots
  (OSS, Code Security, IaC, Secrets) before and after any scan.
- Include Secrets root in removeAllChildren and updateTreeRootNodesPresentation
  so Clean all results keeps all four roots with labels reset.
- Wire Secrets in SnykToolWindowSnykScanListener: scanningStarted/scanningError
  clear Secrets node; displaySecretsResults and filter refresh populate it.
- Map ScanIssue.SECRETS in description panel and flushPendingTreeRefreshes.
- Tests: expect four roots, pass rootSecretsIssuesTreeNode, assert no null on
  Secrets node after clean.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(ui): show Secrets in HTML tree view on first load [IDE-1747]

Add Secrets product node to TreeViewInit.html so the initial HTML tree
view displays all four products (OSS, Code Security, IaC, Secrets) from
plugin load instead of showing Secrets only after the LS sends a tree
view update.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(toolwindow): remove Secrets from native tree [IDE-1747]

- Remove RootSecretsIssuesTreeNode and delete its class file; Secrets are
  shown only in the LS-driven HTML tree view (snykTreeView), not in the
  native Swing tree.
- SnykToolWindowSnykScanListener now takes three roots (OSS, Code, IaC);
  remove all LsProduct.Secrets handling (scanningStarted, scanningError,
  displaySecretsResults, SECRETS branch in displayResults/displayIssues).
- Panel: stop creating/passing Secrets root, drop Secrets from filtering
  callback and from flushPendingTreeRefreshes.
- Update tests for 3-root native tree.

Made-with: Cursor

* chore(toolwindow): remove SECRETS_ROOT_TEXT, add Secrets description handlers [IDE-1747]

- Remove unused SECRETS_ROOT_TEXT from SnykToolWindowPanel companion object.
- Add ScanIssue.SECRETS branch in SuggestionDescriptionPanel.initializeBrowser()
  with SubmitIgnoreRequestHandler so Secrets issue detail HTML can trigger
  ignore requests (parity with VS Code submitIgnoreRequest).

Made-with: Cursor

* refactor(toolwindow): remove Secrets from tree filter and HTML tree [IDE-1747]

- Drop treeFiltering.secretsResults and matchFiltering sync (native tree not used for Secrets)
- Remove createSecretsScanAction and Secrets from scan-type filter menu
- Remove product-secrets node from TreeViewInit.html
- Test: use 3-param updateTreeRootNodesPresentation call and comment

Made-with: Cursor

* refactor(toolwindow): remove unused secrets count from tree presentation [IDE-1747]

- Drop secretsResultsCount param from displayIssues and updateTreeRootNodesPresentation
- Restore Secrets cache clear and comments in scan listener (scan started / scan error)
- Call sites: use 3 counts + addHMLPostfix only; test keeps positional updateTreeRootNodesPresentation(0, 0, 0, "")

Made-with: Cursor

* refactor(toolwindow): remove redundant SECRETS branches for PR review [IDE-1747]

- Panel: drop SECRETS branch in productIssues when; Secrets only in HTML tree
- SuggestionDescriptionPanel: remove SECRETS SubmitIgnoreRequestHandler block

Made-with: Cursor

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: acke

src/main/kotlin/io/snyk/plugin/ui/jcef/ConfigurationDataClasses.kt

@@ -56,6 +56,7 @@ data class SaveConfigRequest(
   @SerializedName("activateSnykOpenSource") val activateSnykOpenSource: Boolean? = null,
   @SerializedName("activateSnykCode") val activateSnykCode: Boolean? = null,
   @SerializedName("activateSnykIac") val activateSnykIac: Boolean? = null,
+  @SerializedName("activateSnykSecrets") val activateSnykSecrets: Boolean? = null,
   @SerializedName("scanningMode") val scanningMode: String? = null,
 
   // Connection Settings

src/main/kotlin/io/snyk/plugin/ui/jcef/SaveConfigHandler.kt

@@ -212,6 +212,7 @@ class SaveConfigHandler(
       settings.ossScanEnable = config.activateSnykOpenSource ?: false
       settings.snykCodeSecurityIssuesScanEnable = config.activateSnykCode ?: false
       settings.iacScanEnabled = config.activateSnykIac ?: false
+      settings.secretsEnabled = config.activateSnykSecrets ?: false
 
       // Scanning mode
       config.scanningMode?.let { settings.scanOnSave = (it == "auto") }

src/main/kotlin/io/snyk/plugin/ui/toolwindow/SnykToolWindowPanel.kt

@@ -385,9 +385,7 @@ class SnykToolWindowPanel(val project: Project) : JPanel(), Disposable {
               ScanIssue.CODE_SECURITY -> cache?.currentSnykCodeResultsLS
               ScanIssue.OPEN_SOURCE -> cache?.currentOSSResultsLS
               ScanIssue.INFRASTRUCTURE_AS_CODE -> cache?.currentIacResultsLS
-              else -> {
-                null
-              }
+              else -> null
             }
           productIssues?.values?.any { issues -> issues.any { issue.id == it.id } } == true
         } else {
@@ -538,7 +536,7 @@ class SnykToolWindowPanel(val project: Project) : JPanel(), Disposable {
               scanListenerLS.displayIacResults(results)
             }
           }
-          LsProduct.Secrets -> Unit // we use the HTML tree for secrets
+          LsProduct.Secrets -> Unit
           LsProduct.Unknown -> Unit
         }
       }

src/main/kotlin/snyk/common/lsp/LanguageServerWrapper.kt

@@ -557,6 +557,7 @@ class LanguageServerWrapper(private val project: Project) : Disposable {
       activateSnykOpenSource = ps.ossScanEnable.toString(),
       activateSnykCodeSecurity = ps.snykCodeSecurityIssuesScanEnable.toString(),
       activateSnykIac = ps.iacScanEnabled.toString(),
+      activateSnykSecrets = ps.secretsEnabled.toString(),
       organization = ps.organization ?: "",
       insecure = ps.ignoreUnknownCA.toString(),
       endpoint = getEndpointUrl(),

src/main/kotlin/snyk/common/lsp/settings/LanguageServerSettings.kt

@@ -13,6 +13,7 @@ data class LanguageServerSettings(
   @SerializedName("activateSnykOpenSource") val activateSnykOpenSource: String? = "false",
   @SerializedName("activateSnykCode") val activateSnykCode: String? = "false",
   @SerializedName("activateSnykIac") val activateSnykIac: String? = "false",
+  @SerializedName("activateSnykSecrets") val activateSnykSecrets: String? = "false",
   @SerializedName("insecure") val insecure: String?,
   @SerializedName("endpoint") val endpoint: String?,
   @SerializedName("additionalParams") val additionalParams: String? = null,