udpate

Author: Daniel Lemire

benchmarks/src/CMakeLists.txt

@@ -60,19 +60,27 @@ target_compile_options(SerializationTwitterBenchmark PRIVATE -freflection -stdli
 # Link sanitizers and libraries
 target_link_libraries(SerializationTwitterBenchmark PRIVATE nlohmann_json::nlohmann_json simdjson::simdjson )
 
+target_link_libraries(SerializationBenchmark PRIVATE simdjson-serial nlohmann_json::nlohmann_json simdjson::simdjson)
+
 # cpp-reflect may fail to build on LLVM 19 due to this issue
 # https://github.com/hanickadot/compile-time-regular-expressions/issues/307
 option(SIMDJSON_BENCH_CPP_REFLECT "include cpp reflect in the benchmarks" OFF)
 if(SIMDJSON_BENCH_CPP_REFLECT)
   message(STATUS "Including reflect-cpp in the benchmarks.")
   add_library(benchmark_reflect_serialization_twitter STATIC benchmark_reflect_serialization_twitter.cpp)
   target_link_libraries(benchmark_reflect_serialization_twitter PRIVATE reflectcpp)
+
   target_link_libraries(SerializationTwitterBenchmark PRIVATE benchmark_reflect_serialization_twitter)
-  target_compile_definitions(benchmark_reflect_serialization_twitter PRIVATE SIMDJSON_BENCH_CPP_REFLECT=1)
-endif()
+  target_compile_definitions(SerializationTwitterBenchmark PRIVATE SIMDJSON_BENCH_CPP_REFLECT=1)
 
 
-target_link_libraries(SerializationBenchmark PRIVATE simdjson-serial nlohmann_json::nlohmann_json simdjson::simdjson)
+  add_library(benchmark_reflect_serialization STATIC benchmark_reflect_serialization_twitter.cpp)
+  target_link_libraries(benchmark_reflect_serialization PRIVATE reflectcpp)
+
+  target_link_libraries(SerializationBenchmark PRIVATE benchmark_reflect_serialization)
+  target_compile_definitions(SerializationBenchmark PRIVATE SIMDJSON_BENCH_CPP_REFLECT=1)
+endif()
+
 
 
 target_compile_definitions(SerializationTwitterBenchmark PRIVATE JSON_FILE="${CMAKE_CURRENT_SOURCE_DIR}/data/twitter.json")

benchmarks/src/benchmark_reflect_serialization.cpp

@@ -0,0 +1,21 @@
+#include "benchmark_reflect_serialization.hpp"
+#include "benchmark_helper.hpp"
+
+#include <rfl.hpp>
+#include <rfl/json.hpp>
+
+void bench_reflect_cpp(std::vector<User>& data) {
+  std::string output = rfl::json::write(data);
+  size_t output_volume = output.size();
+  printf("# output volume: %zu bytes\n", output_volume);
+
+  volatile size_t measured_volume = 0;
+  pretty_print(
+    1, output_volume, "bench_reflect_cpp",
+    bench([&data, &measured_volume, &output_volume] () {
+      std::string output = rfl::json::write(data);
+      measured_volume = output.size();
+      if(measured_volume != output_volume) { printf("mismatch\n"); }
+    })
+  );
+}

benchmarks/src/benchmark_reflect_serialization.hpp

@@ -0,0 +1,6 @@
+#ifndef BENCHMARK_REFLECT_SERIALIZATION_TWITTER_HPP
+#define BENCHMARK_REFLECT_SERIALIZATION_TWITTER_HPP
+
+#include "user_profile.hpp"
+void bench_reflect_cpp(std::vector<User>& data)
+#endif

benchmarks/src/benchmark_serialization.cpp

@@ -10,12 +10,12 @@
 #include <vector>
 #include <format>
 #include <atomic>
-#include <rfl.hpp>
-#include <rfl/json.hpp>
 #include "user_profile.hpp"
 #include "custom_serializer.h"
 #include "nlohmann_user_profile.hpp"
-
+#if SIMDJSON_BENCH_CPP_REFLECT
+#include "benchmark_reflect_serialization.hpp"
+#endif
 std::string generate_email(const std::string &name,
                            const std::string &company) {
   std::string email = name + "@" + company + ".com";
@@ -231,21 +231,6 @@ void bench_nlohmann(std::vector<User> &data) {
   );
 }
 
-void bench_reflect_cpp(std::vector<User>& data) {
-  std::string output = rfl::json::write(data);
-  size_t output_volume = output.size();
-  printf("# output volume: %zu bytes\n", output_volume);
-
-  volatile size_t measured_volume = 0;
-  pretty_print(
-    1, output_volume, "bench_reflect_cpp",
-    bench([&data, &measured_volume, &output_volume] () {
-      std::string output = rfl::json::write(data);
-      measured_volume = output.size();
-      if(measured_volume != output_volume) { printf("mismatch\n"); }
-    })
-  );
-}
 
 
 int main() {
@@ -257,7 +242,8 @@ int main() {
   bench_nlohmann(test_data);
   bench_custom(test_data);
   bench_fast_simpler(test_data);
+#if SIMDJSON_BENCH_CPP_REFLECT
   bench_reflect_cpp(test_data);
-
+#endif
   return EXIT_SUCCESS;
 }