Skip to content

Commit c82dce7

Browse files
Merge pull request #31 from simdjson/patch_for_reflect_cpp
adds a patch to make reflect-cpp build
2 parents 6a267f2 + 7a98928 commit c82dce7

5 files changed

Lines changed: 850 additions & 6 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ CPMAddPackage("gh:nlohmann/json@3.10.5")
2424
CPMAddPackage(
2525
NAME reflect-cpp
2626
GITHUB_REPOSITORY getml/reflect-cpp
27+
PATCHES reflect-cpp.patch
2728
GIT_TAG v0.13.0
2829
)
2930

benchmarks/src/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ target_link_libraries(SerializationBenchmark PRIVATE simdjson-serial nlohmann_js
6464

6565
# cpp-reflect may fail to build on LLVM 19 due to this issue
6666
# https://github.com/hanickadot/compile-time-regular-expressions/issues/307
67-
option(SIMDJSON_BENCH_CPP_REFLECT "include cpp reflect in the benchmarks" OFF)
67+
option(SIMDJSON_BENCH_CPP_REFLECT "include cpp reflect in the benchmarks" ON)
6868
if(SIMDJSON_BENCH_CPP_REFLECT)
6969
message(STATUS "Including reflect-cpp in the benchmarks.")
7070
add_library(benchmark_reflect_serialization_twitter STATIC benchmark_reflect_serialization_twitter.cpp)
@@ -74,7 +74,7 @@ if(SIMDJSON_BENCH_CPP_REFLECT)
7474
target_compile_definitions(SerializationTwitterBenchmark PRIVATE SIMDJSON_BENCH_CPP_REFLECT=1)
7575

7676

77-
add_library(benchmark_reflect_serialization STATIC benchmark_reflect_serialization_twitter.cpp)
77+
add_library(benchmark_reflect_serialization STATIC benchmark_reflect_serialization.cpp)
7878
target_link_libraries(benchmark_reflect_serialization PRIVATE reflectcpp)
7979

8080
target_link_libraries(SerializationBenchmark PRIVATE benchmark_reflect_serialization)

benchmarks/src/benchmark_reflect_serialization.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
#define BENCHMARK_REFLECT_SERIALIZATION_TWITTER_HPP
33

44
#include "user_profile.hpp"
5-
void bench_reflect_cpp(std::vector<User>& data)
5+
void bench_reflect_cpp(std::vector<User>& data);
66
#endif

cmake/CPM.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
#
33
# SPDX-FileCopyrightText: Copyright (c) 2019-2023 Lars Melchior and contributors
44

5-
set(CPM_DOWNLOAD_VERSION 0.39.0)
6-
set(CPM_HASH_SUM "66639bcac9dd2907b2918de466783554c1334446b9874e90d38e3778d404c2ef")
5+
set(CPM_DOWNLOAD_VERSION 0.40.0)
6+
set(CPM_HASH_SUM "7b354f3a5976c4626c876850c93944e52c83ec59a159ae5de5be7983f0e17a2a")
77

88
if(CPM_SOURCE_CACHE)
99
set(CPM_DOWNLOAD_LOCATION "${CPM_SOURCE_CACHE}/cpm/CPM_${CPM_DOWNLOAD_VERSION}.cmake")
@@ -21,4 +21,4 @@ file(DOWNLOAD
2121
${CPM_DOWNLOAD_LOCATION} EXPECTED_HASH SHA256=${CPM_HASH_SUM}
2222
)
2323

24-
include(${CPM_DOWNLOAD_LOCATION})
24+
include(${CPM_DOWNLOAD_LOCATION})

0 commit comments

Comments
 (0)