Commit a463f5c
committed
Fix rrule creation: use name= and value= for more correct syntax.
- When trying to make the rrule, I was getting import errors in
Thunderbird locally, + the online icalendar verifier. (These
changes have not yet been tested for the online calendars. I also
wondered if the online calendars would be more relaxed in parsing
it, so that it would work).
- The rrule had a trailing ':', since it was parsed as NAME:VALUE with
all of the rrule in NAME only, leaving the ':' on the end.
- Now, split the rrule on ':' (maxsplit=1), and make the
ics.ContentLine with the 'name=[left side]', 'value=[right side]'.
This leaves the colon in the right place.
- This makes the generated ics pass the validator and work locally in
Thunderbird. If it doesn't work with online calendars, I will
update this PR with that information.
- Review: worth someone looking to see if this is reasonable, but I
think there is little chance of anything being made worse than it
was before.1 parent 4996b43 commit a463f5c
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
| |||
0 commit comments