Skip to content

Commit 35f6a9a

Browse files
committed
Support Java 21 and 25
1 parent 0c89f58 commit 35f6a9a

6 files changed

Lines changed: 10 additions & 76 deletions

File tree

.github/workflows/build-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ concurrency:
1515
jobs:
1616
check-code-style:
1717
name: Code Style # scalafmt, javafmt, headerCheck
18-
uses: playframework/.github/.github/workflows/cmd.yml@v3
18+
uses: playframework/.github/.github/workflows/cmd.yml@v4
1919
with:
2020
cmd: sbt validateCode
2121

2222
tests:
2323
name: Tests
24-
uses: playframework/.github/.github/workflows/cmd.yml@v3
24+
uses: playframework/.github/.github/workflows/cmd.yml@v4
2525
with:
26-
java: 17, 11
26+
java: 25, 21, 17, 11
2727
scala: 2.12.20
2828
add-dimensions: >-
2929
{
@@ -44,4 +44,4 @@ jobs:
4444
if: github.event_name == 'pull_request'
4545
needs: # Should be last
4646
- "tests"
47-
uses: playframework/.github/.github/workflows/rtm.yml@v3
47+
uses: playframework/.github/.github/workflows/rtm.yml@v4

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
if: ${{ github.repository_owner == 'sbt' }}
1414
steps:
1515
- name: Checkout
16-
uses: actions/checkout@v3
16+
uses: actions/checkout@v4
1717
with:
1818
# we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
1919
fetch-depth: 0

build.sbt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ developers += Developer(
3636
)
3737

3838
libraryDependencies ++= Seq(
39-
"org.apache.maven.plugins" % "maven-plugin-plugin" % "3.15.1",
39+
"org.apache.maven.plugins" % "maven-plugin-plugin" % "3.15.2",
40+
"org.apache.maven" % "maven-core" % "3.9.12",
4041
"junit" % "junit" % "4.13.2" % Test
4142
)
4243

src/main/java/com/github/sbt/maven/SbtLogger.java

Lines changed: 0 additions & 64 deletions
This file was deleted.

src/main/scala/com/github/sbt/maven/SbtMavenPlugin.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import org.apache.maven.tools.plugin.extractor.MojoDescriptorExtractor
2828
import org.apache.maven.tools.plugin.generator.GeneratorUtils.toComponentDependencies
2929
import org.apache.maven.tools.plugin.generator.PluginDescriptorFilesGenerator
3030
import org.apache.maven.tools.plugin.DefaultPluginToolsRequest
31-
import org.codehaus.plexus.logging
3231
import org.codehaus.plexus.util.ReflectionUtils.setVariableValueInObject
3332

3433
object SbtMavenPlugin extends AutoPlugin {
@@ -144,10 +143,9 @@ object SbtMavenPlugin extends AutoPlugin {
144143
project
145144
}
146145

147-
private def createMojoExtractor(logger: logging.Logger): MojoDescriptorExtractor = {
146+
private def createMojoExtractor(): MojoDescriptorExtractor = {
148147
val extractor = new JavaAnnotationsMojoDescriptorExtractor()
149148
val scanner = new DefaultMojoAnnotationsScanner
150-
scanner.enableLogging(logger)
151149
setVariableValueInObject(extractor, "mojoAnnotationsScanner", scanner)
152150
extractor
153151
}
@@ -161,7 +159,7 @@ object SbtMavenPlugin extends AutoPlugin {
161159
val artifacts = findRuntimeDependencies(update.value, allDependencies.value, crossVersion)
162160
val pluginDescriptor = createPluginDescriptor(mavenPluginGoalPrefix.value, projectId, projectInfo.value, artifacts)
163161
val request = new DefaultPluginToolsRequest(project, pluginDescriptor)
164-
val extractor = createMojoExtractor(new SbtLogger(streams.value.log))
162+
val extractor = createMojoExtractor()
165163
val generator = new PluginDescriptorFilesGenerator()
166164

167165
extractor.execute(request).forEach { mojo => pluginDescriptor.addMojo(mojo) }

src/sbt-test/sbt-maven/simple/src/maven-test/simple/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
<version>1.0.0-SNAPSHOT</version>
1010

1111
<properties>
12-
<maven.compiler.source>1.8</maven.compiler.source>
13-
<maven.compiler.target>1.8</maven.compiler.target>
12+
<maven.compiler.release>11</maven.compiler.release>
1413
</properties>
1514

1615
<dependencies>

0 commit comments

Comments
 (0)