Don't pass a block to input elements

Author: nimmolo

lib/superform/rails/components/input.rb

@@ -2,7 +2,7 @@ module Superform
   module Rails
     module Components
       class Input < Field
-        def view_template(&)
+        def view_template
           input(**attributes)
         end
 

lib/superform/rails/field.rb

@@ -72,73 +72,73 @@ def human_attribute_name
       #   field(:birthday).date
       #   field(:secret).hidden(value: "token123")
       #   field(:gender).radio("male", id: "user_gender_male")
-      def text(*, **, &)
-        input(*, **, type: :text, &)
+      def text(*, **)
+        input(*, **, type: :text)
       end
 
-      def hidden(*, **, &)
-        input(*, **, type: :hidden, &)
+      def hidden(*, **)
+        input(*, **, type: :hidden)
       end
 
-      def password(*, **, &)
-        input(*, **, type: :password, &)
+      def password(*, **)
+        input(*, **, type: :password)
       end
 
-      def email(*, **, &)
-        input(*, **, type: :email, &)
+      def email(*, **)
+        input(*, **, type: :email)
       end
 
-      def url(*, **, &)
-        input(*, **, type: :url, &)
+      def url(*, **)
+        input(*, **, type: :url)
       end
 
-      def tel(*, **, &)
-        input(*, **, type: :tel, &)
+      def tel(*, **)
+        input(*, **, type: :tel)
       end
       alias_method :phone, :tel
 
-      def number(*, **, &)
-        input(*, **, type: :number, &)
+      def number(*, **)
+        input(*, **, type: :number)
       end
 
-      def range(*, **, &)
-        input(*, **, type: :range, &)
+      def range(*, **)
+        input(*, **, type: :range)
       end
 
-      def date(*, **, &)
-        input(*, **, type: :date, &)
+      def date(*, **)
+        input(*, **, type: :date)
       end
 
-      def time(*, **, &)
-        input(*, **, type: :time, &)
+      def time(*, **)
+        input(*, **, type: :time)
       end
 
-      def datetime(*, **, &)
-        input(*, **, type: :"datetime-local", &)
+      def datetime(*, **)
+        input(*, **, type: :"datetime-local")
       end
 
-      def month(*, **, &)
-        input(*, **, type: :month, &)
+      def month(*, **)
+        input(*, **, type: :month)
       end
 
-      def week(*, **, &)
-        input(*, **, type: :week, &)
+      def week(*, **)
+        input(*, **, type: :week)
       end
 
-      def color(*, **, &)
-        input(*, **, type: :color, &)
+      def color(*, **)
+        input(*, **, type: :color)
       end
 
-      def search(*, **, &)
-        input(*, **, type: :search, &)
+      def search(*, **)
+        input(*, **, type: :search)
       end
 
-      def file(*, **, &)
-        input(*, **, type: :file, &)
+      def file(*, **)
+        input(*, **, type: :file)
       end
 
-      def radio(value, *, **, &)
-        input(*, **, type: :radio, value: value, &)
+      def radio(value, *, **)
+        input(*, **, type: :radio, value: value)
       end
 
       # Rails compatibility aliases

spec/superform/rails/components/input_component_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe Superform::Rails::Components::Input do
+RSpec.describe Superform::Rails::Components::Input, type: :view do
   let(:field) do
     object = double("object", "foo=": nil)
     object = double("object", "foo": value)
@@ -65,4 +65,19 @@
     end
     it { is_expected.to have_client_provided_value }
   end
+
+  describe "block handling" do
+    it "does not accept blocks in view_template" do
+      # Input is a void element and should not render block content
+      html = render(component)
+      expect(html).to eq('<input id="foo" name="foo" type="text" value="a string">')
+    end
+
+    it "ignores block content if accidentally passed" do
+      # Even if someone tries to pass a block, it should be ignored
+      html = render(component) { "This should not appear" }
+      expect(html).to eq('<input id="foo" name="foo" type="text" value="a string">')
+      expect(html).not_to include("This should not appear")
+    end
+  end
 end

spec/superform/rails/field_convenience_methods_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-RSpec.describe Superform::Rails::Form::Field do
+RSpec.describe Superform::Rails::Form::Field, type: :view do
   let(:user) { User.new(email: "test@example.com", first_name: "John") }
   let(:form) { Superform::Rails::Form.new(user) }
   let(:field) { form.field(:email) }
@@ -60,4 +60,51 @@
       expect(component.type).to eq("radio")
     end
   end
+
+  describe "block handling" do
+    # Input elements are void elements and should not accept blocks.
+    # These tests verify that blocks are properly ignored.
+
+    it "does not render block content for text input" do
+      html = render(field.text { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="text"[^>]*>/)
+    end
+
+    it "does not render block content for email input" do
+      html = render(field.email { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="email"[^>]*>/)
+    end
+
+    it "does not render block content for password input" do
+      html = render(field.password { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="password"[^>]*>/)
+    end
+
+    it "does not render block content for hidden input" do
+      html = render(field.hidden { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="hidden"[^>]*>/)
+    end
+
+    it "does not render block content for number input" do
+      html = render(field.number { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="number"[^>]*>/)
+    end
+
+    it "does not render block content for date input" do
+      html = render(field.date { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="date"[^>]*>/)
+    end
+
+    it "does not render block content for file input" do
+      html = render(field.file { "Block content" })
+      expect(html).not_to include("Block content")
+      expect(html).to match(/<input[^>]*type="file"[^>]*>/)
+    end
+  end
 end