Only sort once

This might never be a hotspot, but I had to optimize away some sorts in other locations. My preference is to sort once if the value won't be changing (this also assumes we won't re-use a visitor once used, perhaps we need to check and error if that assumption doesn't hold).

Author: schneems

lib/syntax_suggest/visitor.rb

@@ -27,15 +27,18 @@ module SyntaxSuggest
   #   visitor = Visitor.new
   #   visitor.endless_def_keyword_locs.first.start_line # => 1
   class Visitor < Prism::Visitor
-    attr_reader :endless_def_keyword_locs
+    attr_reader :endless_def_keyword_locs, :consecutive_lines
 
     def initialize
       @endless_def_keyword_locs = []
-      @consecutive_lines = {}
+      @consecutive_lines_hash = {}
+      @consecutive_lines = []
     end
 
-    def consecutive_lines
-      @consecutive_lines.keys.sort
+    def visit(ast)
+      super(ast)
+      @consecutive_lines = @consecutive_lines_hash.keys.sort
+      self
     end
 
     # Called by Prism::Visitor for every method-call node in the AST
@@ -50,7 +53,7 @@ def visit_call_node(node)
         #     .bar     # line 2
         if receiver_loc.end_line != call_operator_loc.start_line && call_operator_loc.start_line == message_loc.start_line
           (receiver_loc.end_line..call_operator_loc.start_line - 1).each do |line|
-            @consecutive_lines[line] = true
+            @consecutive_lines_hash[line] = true
           end
         end
 
@@ -59,7 +62,7 @@ def visit_call_node(node)
         #     bar      # line 2
         if receiver_loc.end_line == call_operator_loc.start_line && call_operator_loc.start_line != message_loc.start_line
           (call_operator_loc.start_line..message_loc.start_line - 1).each do |line|
-            @consecutive_lines[line] = true
+            @consecutive_lines_hash[line] = true
           end
         end
       end