Skip to content

Commit 9230fe1

Browse files
authored
Rename matches? as match? (#753)
1 parent f9f90da commit 9230fe1

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

lib/reline/io/windows.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ def process_key_event(repeat_count, virtual_key_code, virtual_scan_code, char_co
252252

253253
key = KeyEventRecord.new(virtual_key_code, char_code, control_key_state)
254254

255-
match = KEY_MAP.find { |args,| key.matches?(**args) }
255+
match = KEY_MAP.find { |args,| key.match?(**args) }
256256
unless match.nil?
257257
@output_buf.concat(match.last)
258258
return
@@ -501,7 +501,7 @@ def enhanced?
501501
# Verifies if the arguments match with this key event.
502502
# Nil arguments are ignored, but at least one must be passed as non-nil.
503503
# To verify that no control keys were pressed, pass an empty array: `control_keys: []`.
504-
def matches?(control_keys: nil, virtual_key_code: nil, char_code: nil)
504+
def match?(control_keys: nil, virtual_key_code: nil, char_code: nil)
505505
raise ArgumentError, 'No argument was passed to match key event' if control_keys.nil? && virtual_key_code.nil? && char_code.nil?
506506

507507
(control_keys.nil? || [*control_keys].sort == @control_keys) &&

test/reline/windows/test_key_event_record.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,31 +10,31 @@ def setup
1010
end
1111

1212
def test_matches__with_no_arguments_raises_error
13-
assert_raise(ArgumentError) { @key.matches? }
13+
assert_raise(ArgumentError) { @key.match? }
1414
end
1515

1616
def test_matches_char_code
17-
assert @key.matches?(char_code: 0x1)
17+
assert @key.match?(char_code: 0x1)
1818
end
1919

2020
def test_matches_virtual_key_code
21-
assert @key.matches?(virtual_key_code: 0x41)
21+
assert @key.match?(virtual_key_code: 0x41)
2222
end
2323

2424
def test_matches_control_keys
25-
assert @key.matches?(control_keys: :CTRL)
25+
assert @key.match?(control_keys: :CTRL)
2626
end
2727

2828
def test_doesnt_match_alt
29-
refute @key.matches?(control_keys: :ALT)
29+
refute @key.match?(control_keys: :ALT)
3030
end
3131

3232
def test_doesnt_match_empty_control_key
33-
refute @key.matches?(control_keys: [])
33+
refute @key.match?(control_keys: [])
3434
end
3535

3636
def test_matches_control_keys_and_virtual_key_code
37-
assert @key.matches?(control_keys: :CTRL, virtual_key_code: 0x41)
37+
assert @key.match?(control_keys: :CTRL, virtual_key_code: 0x41)
3838
end
3939

4040
end

0 commit comments

Comments
 (0)