fix: resolve ::class constant in Pest describe() to FQN (#405)

Author: recca0120

packages/phpunit/src/Interpreter/Resolvers/PestResolver.ts

@@ -1,9 +1,15 @@
 import { datasetExpander } from '../../TestParser/DatasetExpander';
-import type { AstNode, CallNode, ExpressionStatementNode } from '../AstParser/AstNode';
+import type {
+    AstNode,
+    CallNode,
+    ClassConstantAccessNode,
+    ExpressionStatementNode,
+} from '../AstParser/AstNode';
 import { evaluate } from '../Expressions/PhpExpression';
 import type { PHP } from '../PHP';
 import type { FileInfo, PestCallDescriptor, Resolver } from '../types';
 import { CallVisitor } from '../Visitors/CallVisitor';
+import { FQNResolver } from './FQNResolver';
 
 const pestFunctionNames = new Set(['test', 'it', 'describe', 'arch']);
 
@@ -34,14 +40,26 @@ export class PestResolver implements Resolver {
     }
 }
 
-function extractDescription(args: AstNode[]): string | undefined {
+function extractDescription(args: AstNode[], php: PHP): string | undefined {
     const firstArg = args[0];
     if (firstArg?.kind === 'string') {
         return firstArg.value;
     }
     if (firstArg?.kind === 'argument' && firstArg.value?.kind === 'string') {
         return firstArg.value.value;
     }
+    if (firstArg?.kind === 'class_constant_access') {
+        const node = firstArg as ClassConstantAccessNode;
+        if (node.name === 'class') {
+            return php.getResolver(FQNResolver).resolveFQN(node.scope);
+        }
+    }
+    if (firstArg?.kind === 'argument' && firstArg.value?.kind === 'class_constant_access') {
+        const node = firstArg.value as ClassConstantAccessNode;
+        if (node.name === 'class') {
+            return php.getResolver(FQNResolver).resolveFQN(node.scope);
+        }
+    }
     return undefined;
 }
 
@@ -101,7 +119,7 @@ function buildPestCallDescriptor(call: CallNode, php: PHP): PestCallDescriptor |
 
     return {
         fnName: rootCall.name,
-        description: extractDescription(rootCall.arguments),
+        description: extractDescription(rootCall.arguments, php),
         range: rootCall.loc,
         datasets: resolveDatasets(withSources),
         children: rootCall.name === 'describe' ? collectDescribeChildren(rootCall, php) : [],

packages/phpunit/src/TestParser/TestExtractorForPest.test.ts

@@ -581,8 +581,68 @@ it('generates name', function (object $user) {
         );
     });
 
+    it('describe with ::class using use statement', async () => {
+        const content = `<?php
+
+namespace Foo\\tests\\Unit;
+
+use Foo\\Services\\PlaylistService;
+
+describe(PlaylistService::class, function() {
+    it('should detect this test', function() {
+        expect(true)->toBeTrue();
+    });
+});
+        `;
+
+        expect(
+            givenTest(
+                file,
+                content,
+                '`Foo\\Services\\PlaylistService` → it should detect this test',
+            ),
+        ).toEqual(
+            expect.objectContaining({
+                type: TestType.method,
+                id: 'tests/Fixtures/ExampleTest.php::`Foo\\Services\\PlaylistService` → it should detect this test',
+                methodName: '`Foo\\Services\\PlaylistService` → it should detect this test',
+                label: 'it should detect this test',
+                file,
+            }),
+        );
+    });
+
+    it('describe with ::class using fully qualified class name', async () => {
+        const content = `<?php
+
+namespace Foo\\tests\\Unit;
+
+describe(\\Foo\\Services\\PlaylistService::class, function() {
+    it('should detect this test', function() {
+        expect(true)->toBeTrue();
+    });
+});
+        `;
+
+        expect(
+            givenTest(
+                file,
+                content,
+                '`Foo\\Services\\PlaylistService` → it should detect this test',
+            ),
+        ).toEqual(
+            expect.objectContaining({
+                type: TestType.method,
+                id: 'tests/Fixtures/ExampleTest.php::`Foo\\Services\\PlaylistService` → it should detect this test',
+                methodName: '`Foo\\Services\\PlaylistService` → it should detect this test',
+                label: 'it should detect this test',
+                file,
+            }),
+        );
+    });
+
     it('parse describe arch', () => {
-        const content = `<?php 
+        const content = `<?php
 
 describe('Given a project', function () {
     describe('When the architecture is tested', function () {