fix(health): show health error details (#161)

* fix(deps): update dependencies

* fix(health): show health error details

Author: juancgalvis

build.gradle

@@ -15,7 +15,7 @@ plugins {
     id 'org.sonarqube' version '7.2.2.6593'
     id 'org.springframework.boot' version '4.0.1' apply false
     id 'io.github.gradle-nexus.publish-plugin' version '2.0.0'
-    id 'co.com.bancolombia.cleanArchitecture' version '4.0.4'
+    id 'co.com.bancolombia.cleanArchitecture' version '4.0.5'
 }
 
 repositories {

samples/async/async-sender-client/src/main/resources/application.yaml

@@ -15,5 +15,6 @@ management:
         include: health,prometheus
 app:
   async:
-    createTopology: true
-    listenReplies: true
+    app:
+      createTopology: true
+      listenReplies: true

starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/config/health/ReactiveCommonsHealthIndicator.java

@@ -32,7 +32,7 @@ protected Mono<Health> doHealthCheck(Health.Builder builder) {
     private Health.Builder reduceHealth(Health.Builder builder, RCHealth health) {
         String domain = health.details().getOrDefault(DOMAIN, UNKNOWN).toString();
         if (health.status().equals(RCHealth.Status.DOWN)) {
-            log.error("Broker of domain {} is down", domain);
+            log.error("Broker of domain {} is down {}", domain, health.details());
             return builder.down().withDetail(domain, health.details());
         }
         return builder.withDetail(domain, health.details());

starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java

@@ -2,14 +2,11 @@
 
 import com.rabbitmq.client.Connection;
 import com.rabbitmq.client.ConnectionFactory;
-import lombok.SneakyThrows;
 import lombok.extern.log4j.Log4j2;
 import org.reactivecommons.async.starter.config.health.RCHealth;
 import org.reactivecommons.async.starter.config.health.RCHealthIndicator;
 import reactor.core.publisher.Mono;
 
-import java.net.SocketException;
-
 import static org.reactivecommons.async.starter.config.health.ReactiveCommonsHealthIndicator.DOMAIN;
 import static org.reactivecommons.async.starter.config.health.ReactiveCommonsHealthIndicator.VERSION;
 
@@ -21,7 +18,6 @@ public class RabbitReactiveHealthIndicator extends RCHealthIndicator {
     public RabbitReactiveHealthIndicator(String domain, ConnectionFactory connectionFactory) {
         this.domain = domain;
         this.connectionFactory = connectionFactory.clone();
-        this.connectionFactory.useBlockingIo();
     }
 
     @Override
@@ -31,13 +27,12 @@ public Mono<RCHealth> doHealthCheck(RCHealth.RCHealthBuilder builder) {
                 .map(status -> builder.up().withDetail(VERSION, status).build());
     }
 
-    @SneakyThrows
     private String getRawVersion(ConnectionFactory factory) {
         Connection connection = null;
         try {
             connection = factory.newConnection();
             return connection.getServerProperties().get(VERSION).toString();
-        } catch (SocketException e) {
+        } catch (Exception e) {
             log.warn("Identified error", e);
             throw new RabbitMQHealthException(e);
         } finally {

starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicatorTest.java

@@ -84,7 +84,7 @@ void shouldBeDown() throws IOException, TimeoutException {
         Mono<RCHealth> result = indicator.doHealthCheck(RCHealth.builder());
         // Assert
         StepVerifier.create(result)
-                .expectError(TimeoutException.class)
+                .expectError(RabbitMQHealthException.class)
                 .verify();
     }