Skip to content

feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels #501

feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels

feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels #501

Triggered via pull request March 13, 2026 21:44
Status Success
Total duration 3m 26s
Artifacts

ci.yml

on: pull_request
Matrix: generate-template
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

17 warnings
fmt
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
doc
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
clippy
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, clechasseur/rs-clippy-check@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
used `unwrap()` on an `Option` value: src/backend/utils.rs#L211
warning: used `unwrap()` on an `Option` value --> src/backend/utils.rs:211:13 | 211 | let s = web_sys::window().unwrap().screen().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unwrap_used
used `unwrap()` on a `Result` value: src/backend/utils.rs#L211
warning: used `unwrap()` on a `Result` value --> src/backend/utils.rs:211:13 | 211 | let s = web_sys::window().unwrap().screen().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unwrap_used
used `unwrap()` on an `Option` value: src/backend/utils.rs#L188
warning: used `unwrap()` on an `Option` value --> src/backend/utils.rs:188:54 | 188 | let color = ansi_to_rgb(color).unwrap_or_else(|| ansi_to_rgb(fallback_color).unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unwrap_used
very complex type used. Consider factoring parts into `type` definitions: src/backend/webgl2.rs#L838
warning: very complex type used. Consider factoring parts into `type` definitions --> src/backend/webgl2.rs:838:15 | 838 | callback: Rc<RefCell<dyn FnMut(&str)>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: src/backend/webgl2.rs#L627
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/backend/webgl2.rs:627:50 | 627 | Self::update_canvas_cursor_style(&self.beamterm.canvas(), is_over); | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.beamterm.canvas()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this `if` statement can be collapsed: src/backend/dom.rs#L328
warning: this `if` statement can be collapsed --> src/backend/dom.rs:328:13 | 328 | / if cell.symbol().len() > 1 && cell.symbol().width() == 2 { 329 | | if (cell_position + 1) < self.cells.len() { 330 | | let next_elem = &self.cells[cell_position + 1]; 331 | | next_elem.set_inner_html(""); ... | 336 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 328 ~ if cell.symbol().len() > 1 && cell.symbol().width() == 2 329 ~ && (cell_position + 1) < self.cells.len() { 330 | let next_elem = &self.cells[cell_position + 1]; ... 334 | .map_err(Error::from)?; 335 ~ } |
doc list item overindented: src/backend/dom.rs#L56
warning: doc list item overindented --> src/backend/dom.rs:56:9 | 56 | /// `"_ratzilla_grid"`. | ^^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items = note: `#[warn(clippy::doc_overindented_list_items)]` on by default
used `unwrap()` on an `Option` value: src/backend/canvas.rs#L423
warning: used `unwrap()` on an `Option` value --> src/backend/canvas.rs:423:21 | 423 | let color = self.debug_mode.as_ref().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unwrap_used note: the lint level is defined here --> src/lib.rs:1:23 | 1 | #![warn(missing_docs, clippy::unwrap_used)] | ^^^^^^^^^^^^^^^^^^^
doc list item without indentation: src/backend/canvas.rs#L291
warning: doc list item without indentation --> src/backend/canvas.rs:291:9 | 291 | /// or when `always_clip_cells` is enabled. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 291 | /// or when `always_clip_cells` is enabled. | +++
this can be `std::io::Error::other(_)`: src/error.rs#L58
warning: this can be `std::io::Error::other(_)` --> src/error.rs:58:9 | 58 | std::io::Error::new(std::io::ErrorKind::Other, error.to_string()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#io_other_error = note: `#[warn(clippy::io_other_error)]` on by default help: use `std::io::Error::other` | 58 - std::io::Error::new(std::io::ErrorKind::Other, error.to_string()) 58 + std::io::Error::other(error.to_string()) |
generate-template (simple)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test ubuntu-latest
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test windows-latest
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test macos-latest
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/