Skip to content

Commit 11ce49d

Browse files
committed
Make ActiveRecord::Assertions::QueryAssertions method outputs consistent
Ref: rails/rails#55852
1 parent e896635 commit 11ce49d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/cases/coerced_tests.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2704,12 +2704,12 @@ def test_assert_queries_match_coerced
27042704
error = assert_raises(Minitest::Assertion) {
27052705
assert_queries_match(/ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY/i, count: 2) { Post.first }
27062706
}
2707-
assert_match(/1 instead of 2 queries/, error.message)
2707+
assert_match(/1 instead of 2 matching queries/, error.message)
27082708

27092709
error = assert_raises(Minitest::Assertion) {
27102710
assert_queries_match(/ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY/i, count: 0) { Post.first }
27112711
}
2712-
assert_match(/1 instead of 0 queries/, error.message)
2712+
assert_match(/1 instead of 0 matching queries/, error.message)
27132713
end
27142714
end
27152715
end

test/support/query_assertions.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ def assert_queries_count(count = nil, include_schema: false, &block)
1414
# End of monkey-patch
1515

1616
if count
17-
assert_equal count, queries.size, "#{queries.size} instead of #{count} queries were executed. Queries: #{queries.join("\n\n")}"
17+
assert_equal count, queries.size, "#{queries.size} instead of #{count} queries were executed#{queries.empty? ? '' : ". Queries:\n\n#{queries.join("\n\n")}"}"
1818
else
19-
assert_operator queries.size, :>=, 1, "1 or more queries expected, but none were executed.#{"\nQueries:\n#{queries.join("\n")}" unless queries.empty?}"
19+
assert_operator queries.size, :>=, 1, "1 or more queries expected, but none were executed"
2020
end
2121
result
2222
end

0 commit comments

Comments
 (0)