Full review and some refactoring (#124)

Author: hdk5

.gitignore

@@ -8,6 +8,6 @@ MANIFEST
 .pydevproject
 .settings/
 testing/
-tests/
+tests1/
 vk_config.json
 vk_config.v2.json

examples/messages_bot/messages_bot.py

@@ -34,7 +34,7 @@ def main():
     longpoll = VkLongPoll(vk_session)
 
     for event in longpoll.listen():
-        if event.type == VkEventType.MESSAGE_NEW and event.to_me:
+        if event.type == VkEventType.MESSAGE_NEW and event.to_me and event.text:
             print('id{}: "{}"'.format(event.user_id, event.text), end=' ')
 
             response = session.get(

jconfig/base.py

@@ -24,10 +24,10 @@ def __getattr__(self, name):
     __getitem__ = __getattr__
 
     def __setattr__(self, name, value):
-        if name in self.__slots__:
-            return super(BaseConfig, self).__setattr__(name, value)
-
-        self._section[name] = value
+        try:
+            super(BaseConfig, self).__setattr__(name, value)
+        except AttributeError:
+            self._section[name] = value
 
     __setitem__ = __setattr__
 

jconfig/jconfig.py

@@ -14,7 +14,7 @@
 
 class Config(BaseConfig):
 
-    __slots__ = BaseConfig.__slots__ + ('_filename',)
+    __slots__ = ('_filename',)
 
     def __init__(self, section, filename='.jconfig'):
         self._filename = filename

jconfig/memory.py

@@ -11,6 +11,9 @@
 
 
 class MemoryConfig(BaseConfig):
+
+    __slots__ = tuple()
+
     def load(self, settings=None, **kwargs):
         return {} if settings is None else settings
 

requirements_dev.txt

@@ -0,0 +1,2 @@
+pytest
+pytest-mock

setup.py

@@ -22,7 +22,7 @@
     license='Apache License, Version 2.0, see LICENSE file',
 
     packages=['vk_api', 'jconfig'],
-    install_requires=['requests', 'enum34'],
+    install_requires=['requests', 'enum34', 'beautifulsoup4'],
 
     classifiers=[
         'License :: OSI Approved :: Apache Software License',

tests/__init__.py

@@ -0,0 +1,19 @@
+from jconfig.memory import MemoryConfig
+
+
+def test_config_section():
+    c = MemoryConfig('secret')
+
+    assert 'secret' in c._settings
+
+    c.test = 'hello!'
+
+    assert c['test'] == 'hello!'
+    assert c.test == 'hello!'
+    assert c._section == {'test': 'hello!'}
+
+    c['test'] = '42'
+
+    assert c['test'] == '42'
+    assert c.test == '42'
+    assert c._section == {'test': '42'}

tests/test_jconfig.py

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+from .enums import *
 from .exceptions import *
 from .requests_pool import VkRequestsPool
 from .tools import VkTools