feat: benefit sync to push template changes to active sponsorships

Adds a "Sync to Sponsorships" button on the benefit edit page that lets
staff push updated benefit data (name, description, value, features) to
all active sponsorships using that benefit. Shows eligible sponsorships
with checkboxes, excludes rejected and expired.

Includes guide documentation and 6 tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: JacobCoffee

apps/sponsors/manage/tests.py

@@ -2295,3 +2295,75 @@ def test_renewal_flag_not_stored_without_param(self):
         self.client.get(reverse("manage_composer") + f"?new=1&sponsor_id={self.sponsor.pk}")
         session_data = self.client.session.get("composer", {})
         self.assertNotIn("renewal", session_data)
+
+
+class BenefitSyncViewTests(SponsorshipReviewTestBase):
+    """Test benefit sync to active sponsorships."""
+
+    def setUp(self):
+        super().setUp()
+        today = timezone.now().date()
+        self.sponsorship.status = Sponsorship.FINALIZED
+        self.sponsorship.start_date = today - datetime.timedelta(days=100)
+        self.sponsorship.end_date = today + datetime.timedelta(days=265)
+        self.sponsorship.save()
+        # Create SponsorBenefit linking sponsorship to benefit template
+        self.sponsor_benefit = SponsorBenefit.objects.create(
+            sponsorship=self.sponsorship,
+            sponsorship_benefit=self.benefit,
+            name=self.benefit.name,
+            description=self.benefit.description,
+            program=self.benefit.program,
+            benefit_internal_value=self.benefit.internal_value,
+        )
+
+    def test_sync_page_loads(self):
+        """Sync page shows eligible sponsorships."""
+        response = self.client.get(reverse("manage_benefit_sync", args=[self.benefit.pk]))
+        self.assertEqual(response.status_code, 200)
+        self.assertContains(response, "Acme Corp")
+        self.assertContains(response, "Sync Benefit to Sponsorships")
+
+    def test_sync_updates_sponsor_benefit(self):
+        """Posting sync updates the SponsorBenefit with latest template data."""
+        # Change the benefit template
+        self.benefit.name = "Updated Logo Benefit"
+        self.benefit.internal_value = 5000
+        self.benefit.save()
+        # Sync
+        response = self.client.post(
+            reverse("manage_benefit_sync", args=[self.benefit.pk]),
+            {"sponsorship_ids": [self.sponsorship.pk]},
+        )
+        self.assertEqual(response.status_code, 302)
+        self.sponsor_benefit.refresh_from_db()
+        self.assertEqual(self.sponsor_benefit.name, "Updated Logo Benefit")
+        self.assertEqual(self.sponsor_benefit.benefit_internal_value, 5000)
+
+    def test_sync_excludes_rejected(self):
+        """Rejected sponsorships are not shown on the sync page."""
+        self.sponsorship.status = Sponsorship.REJECTED
+        self.sponsorship.save(update_fields=["status"])
+        response = self.client.get(reverse("manage_benefit_sync", args=[self.benefit.pk]))
+        self.assertNotContains(response, "Acme Corp")
+
+    def test_sync_excludes_expired(self):
+        """Expired sponsorships are not shown on the sync page."""
+        today = timezone.now().date()
+        self.sponsorship.end_date = today - datetime.timedelta(days=10)
+        self.sponsorship.save(update_fields=["end_date"])
+        response = self.client.get(reverse("manage_benefit_sync", args=[self.benefit.pk]))
+        self.assertNotContains(response, "Acme Corp")
+
+    def test_sync_no_selection_warns(self):
+        """Posting with no selections shows a warning."""
+        response = self.client.post(
+            reverse("manage_benefit_sync", args=[self.benefit.pk]),
+            {},
+        )
+        self.assertEqual(response.status_code, 302)
+
+    def test_sync_button_shown_on_benefit_edit(self):
+        """Benefit edit page shows Sync button when sponsorships exist."""
+        response = self.client.get(reverse("manage_benefit_edit", args=[self.benefit.pk]))
+        self.assertContains(response, "Sync to Sponsorships")

apps/sponsors/manage/urls.py

@@ -12,6 +12,7 @@
     path("benefits/new/", views.BenefitCreateView.as_view(), name="manage_benefit_create"),
     path("benefits/<int:pk>/edit/", views.BenefitUpdateView.as_view(), name="manage_benefit_edit"),
     path("benefits/<int:pk>/delete/", views.BenefitDeleteView.as_view(), name="manage_benefit_delete"),
+    path("benefits/<int:pk>/sync/", views.BenefitSyncView.as_view(), name="manage_benefit_sync"),
     # Benefit feature configurations
     path(
         "benefits/<int:pk>/add-config/<str:config_type>/",

apps/sponsors/manage/views.py

@@ -324,6 +324,48 @@ def get_success_url(self):
         return reverse("manage_benefit_list") + (f"?year={year}" if year else "")
 
 
+class BenefitSyncView(SponsorshipAdminRequiredMixin, View):
+    """Sync a SponsorshipBenefit template to its related SponsorBenefit instances."""
+
+    def get(self, request, pk):
+        """Show eligible sponsorships with checkboxes for syncing."""
+        benefit = get_object_or_404(SponsorshipBenefit.objects.select_related("program"), pk=pk)
+        today = tz.now().date()
+        eligible = (
+            benefit.related_sponsorships.exclude(Q(end_date__lt=today) | Q(status=Sponsorship.REJECTED))
+            .select_related("sponsor", "package")
+            .order_by("sponsor__name")
+        )
+        return render(
+            request,
+            "sponsors/manage/benefit_sync.html",
+            {
+                "benefit": benefit,
+                "eligible": eligible,
+            },
+        )
+
+    @transaction.atomic
+    def post(self, request, pk):
+        """Sync benefit attributes to selected sponsorships."""
+        benefit = get_object_or_404(SponsorshipBenefit.objects.select_related("program"), pk=pk)
+        selected_ids = request.POST.getlist("sponsorship_ids")
+        if not selected_ids:
+            messages.warning(request, "No sponsorships selected.")
+            return redirect(reverse("manage_benefit_sync", args=[pk]))
+
+        count = 0
+        for sp_id in selected_ids:
+            try:
+                sponsor_benefit = benefit.sponsorbenefit_set.get(sponsorship_id=int(sp_id))
+                sponsor_benefit.reset_attributes(benefit)
+                count += 1
+            except SponsorBenefit.DoesNotExist:
+                continue
+        messages.success(request, f"Updated {count} sponsorship(s) with latest benefit data.")
+        return redirect(reverse("manage_benefit_edit", args=[pk]))
+
+
 class PackageListView(SponsorshipAdminRequiredMixin, ListView):
     """List sponsorship packages grouped by year."""
 
@@ -1170,9 +1212,15 @@ def post(self, request, pk):
         except Contract.DoesNotExist:
             pass
         new_contract = Contract.new(sp)
+        # Set revision to count of historical contracts for this sponsor
+        historical_count = Contract.objects.filter(
+            sponsor_info__contains=sp.sponsor.name, sponsorship__isnull=True, status=Contract.OUTDATED
+        ).count()
+        new_contract.revision = historical_count
+        new_contract.save()
         messages.success(
             request,
-            f"New contract draft created (Revision {new_contract.revision}). Previous contract preserved as outdated.",
+            f"New contract draft created (Revision {new_contract.revision}). Previous contract preserved.",
         )
         return redirect(reverse("manage_sponsorship_detail", args=[pk]))
 

apps/sponsors/templates/sponsors/manage/benefit_form.html

@@ -235,6 +235,7 @@ <h2>Included in Packages <span class="badge">{{ benefit_packages|length }}</span
         <div class="manage-section">
             <div class="manage-section-header">
                 <h2>Sponsors Using This Benefit <span class="badge">{{ related_sponsorships_count }}</span></h2>
+                <a href="{% url 'manage_benefit_sync' object.pk %}" class="btn btn-sm btn-gold">Sync to Sponsorships</a>
             </div>
             <table class="manage-table">
                 <thead>
@@ -251,7 +252,7 @@ <h2>Sponsors Using This Benefit <span class="badge">{{ related_sponsorships_coun
                     <tr>
                         <td>
                             {% if sp.sponsor %}
-                            <a href="{{ sp.admin_url }}" style="font-weight:600;color:#1a1a2e;text-decoration:none;">{{ sp.sponsor.name }}</a>
+                            <a href="{% url 'manage_sponsorship_detail' sp.pk %}" style="font-weight:600;color:#1a1a2e;text-decoration:none;">{{ sp.sponsor.name }}</a>
                             {% else %}
                             <span style="color:#999;">Unknown sponsor</span>
                             {% endif %}

apps/sponsors/templates/sponsors/manage/benefit_sync.html

@@ -0,0 +1,118 @@
+{% extends "sponsors/manage/_base.html" %}
+
+{% block page_title %}Sync {{ benefit.short_name }} | Sponsor Management{% endblock %}
+
+{% with active_tab="benefits" %}
+
+{% block manage_breadcrumbs %}
+<div class="manage-crumbs">
+    <a href="{% url 'manage_dashboard' %}">Dashboard</a>
+    <span class="sep">/</span>
+    <a href="{% url 'manage_benefit_list' %}">Benefits</a>
+    <span class="sep">/</span>
+    <a href="{% url 'manage_benefit_edit' benefit.pk %}">{{ benefit.short_name }}</a>
+    <span class="sep">/</span>
+    <span class="current">Sync</span>
+</div>
+{% endblock %}
+
+{% block manage_content %}
+    <div class="manage-form">
+        <h2 style="font-size:18px;font-weight:700;color:#1a1a2e;margin:0 0 4px;">
+            Sync Benefit to Sponsorships
+        </h2>
+        <p style="font-size:13px;color:#777;margin:0 0 20px;">
+            <strong>{{ benefit.name }}</strong> &middot; {{ benefit.program.name }} &middot; {{ benefit.year }}
+        </p>
+
+        <div class="manage-alert manage-alert-info" style="margin-bottom:20px;">
+            This will push the current benefit definition (name, description, value, program, features) to the selected sponsorships. Each sponsor's copy of this benefit will be overwritten with the latest template data.
+        </div>
+
+        {% if eligible %}
+        <form method="post">
+            {% csrf_token %}
+
+            <fieldset class="manage-fieldset">
+                <legend>Select Sponsorships to Update</legend>
+
+                <div style="margin-bottom:12px;">
+                    <label style="display:flex;align-items:center;gap:8px;font-size:13px;cursor:pointer;">
+                        <input type="checkbox" id="select-all" checked> Select / deselect all
+                    </label>
+                </div>
+
+                <table class="manage-table">
+                    <thead>
+                        <tr>
+                            <th style="width:30px;text-align:center;"></th>
+                            <th>Sponsor</th>
+                            <th>Package</th>
+                            <th>Year</th>
+                            <th style="text-align:center;">Status</th>
+                            <th>Period</th>
+                        </tr>
+                    </thead>
+                    <tbody>
+                        {% for sp in eligible %}
+                        <tr>
+                            <td style="text-align:center;">
+                                <input type="checkbox" name="sponsorship_ids" value="{{ sp.pk }}" class="row-select" checked>
+                            </td>
+                            <td>
+                                <a href="{% url 'manage_sponsorship_detail' sp.pk %}" style="font-weight:600;color:#1a1a2e;text-decoration:none;">
+                                    {% if sp.sponsor %}{{ sp.sponsor.name }}{% else %}Unknown{% endif %}
+                                </a>
+                            </td>
+                            <td>
+                                {% if sp.package %}<span class="tag tag-blue">{{ sp.package.name }}</span>{% else %}<span style="color:#ccc;">&mdash;</span>{% endif %}
+                            </td>
+                            <td>{{ sp.year|default:"&mdash;" }}</td>
+                            <td style="text-align:center;">
+                                {% if sp.status == 'applied' %}<span class="tag tag-blue">Applied</span>
+                                {% elif sp.status == 'approved' %}<span class="tag tag-gold">Approved</span>
+                                {% elif sp.status == 'finalized' %}<span class="tag tag-green">Finalized</span>
+                                {% endif %}
+                            </td>
+                            <td style="font-size:12px;color:#777;">
+                                {% if sp.start_date and sp.end_date %}
+                                {{ sp.start_date|date:"M j, Y" }} &ndash; {{ sp.end_date|date:"M j, Y" }}
+                                {% else %}<span style="color:#ccc;">&mdash;</span>{% endif %}
+                            </td>
+                        </tr>
+                        {% endfor %}
+                    </tbody>
+                </table>
+            </fieldset>
+
+            <div style="display:flex;gap:10px;align-items:center;padding-top:8px;">
+                <button type="submit" class="btn btn-primary">Sync {{ eligible|length }} Sponsorship{{ eligible|length|pluralize }}</button>
+                <a href="{% url 'manage_benefit_edit' benefit.pk %}" class="btn btn-secondary">Cancel</a>
+            </div>
+        </form>
+
+        <script>
+        (function() {
+            var selectAll = document.getElementById('select-all');
+            if (selectAll) {
+                selectAll.addEventListener('change', function() {
+                    var boxes = document.querySelectorAll('.row-select');
+                    for (var i = 0; i < boxes.length; i++) {
+                        boxes[i].checked = selectAll.checked;
+                    }
+                });
+            }
+        })();
+        </script>
+
+        {% else %}
+        <div class="empty-state">
+            <div class="empty-icon">&#9745;</div>
+            <p>No active sponsorships use this benefit. Nothing to sync.</p>
+            <a href="{% url 'manage_benefit_edit' benefit.pk %}" class="btn btn-secondary">Back to Benefit</a>
+        </div>
+        {% endif %}
+    </div>
+{% endblock %}
+
+{% endwith %}

apps/sponsors/templates/sponsors/manage/guide.html

@@ -218,6 +218,10 @@ <h3 style="font-size:16px;font-weight:700;color:#3776ab;border-bottom:2px solid
 <strong>Cloning a year:</strong> When setting up a new sponsorship year, go to <a href="{% url 'manage_clone_year' %}" style="color:#3776ab;">Clone Year</a> (under More in the nav). Pick a source year and a target year, and it copies all packages and benefits over. You can then tweak the new year's config without touching the previous year's data.
 </p>
 
+<p style="font-size:13px;line-height:1.8;color:#444;">
+<strong>Syncing benefit changes:</strong> When you update a benefit's name, description, value, or feature configurations, those changes only affect <em>new</em> sponsorships. Existing sponsorships keep a snapshot of the benefit as it was when they were created. To push your changes to active sponsorships, open the benefit edit page and click <strong>"Sync to Sponsorships"</strong> in the "Sponsors Using This Benefit" section. You'll see a list of eligible sponsorships (non-expired, non-rejected) and can select which ones to update.
+</p>
+
 <div class="manage-alert manage-alert-info">
 Cloning duplicates everything: packages, benefits, benefit-to-package associations, and feature configurations. It does not copy sponsorships or contracts. Review the cloned data after running it to make sure fees and benefit values are still correct for the new year.
 </div>