use _PyException_AddNote instead of calling add_note explicitly

Author: picnixz

Include/internal/pycore_global_objects_fini_generated.h

@@ -299,7 +299,6 @@ struct _Py_global_strings {
         STRUCT_FOR_ID(aclose)
         STRUCT_FOR_ID(add)
         STRUCT_FOR_ID(add_done_callback)
-        STRUCT_FOR_ID(add_note)
         STRUCT_FOR_ID(adobe)
         STRUCT_FOR_ID(after_in_child)
         STRUCT_FOR_ID(after_in_parent)

Include/internal/pycore_global_strings.h

@@ -29,7 +29,8 @@ PyAPI_FUNC(PyObject*) _PyErr_FormatFromCause(
     ...
     );
 
-extern int _PyException_AddNote(
+// Export for 'pyexpat' shared extension.
+PyAPI_FUNC(int) _PyException_AddNote(
      PyObject *exc,
      PyObject *note);
 

Include/internal/pycore_pyerrors.h

@@ -512,12 +512,11 @@ invalid_expat_handler_rv(const char *name)
     if (note == NULL) {
         goto error;
     }
-    PyObject *res = PyObject_CallMethodOneArg(exc, &_Py_ID(add_note), note);
+    int rc = _PyException_AddNote(exc, note);
     Py_DECREF(note);
-    if (res == NULL) {
+    if (rc < 0) {
         goto error;
-    }
-    Py_DECREF(res);
+    };
     goto done;
 
 error: