Allow advanced search to return results when no query is present (#3810)

Author: mamrey

lib/blacklight/solr/search_builder_behavior.rb

@@ -102,7 +102,7 @@ def add_search_field_with_json_query_parameters(solr_parameters)
 
     # Transform "clause" parameters into the Solr JSON Query DSL
     def add_adv_search_clauses(solr_parameters)
-      return if search_state.clause_params.blank?
+      return if search_state.clause_params.blank? || search_state.clause_params.all? { |_k, v| v[:query].blank? }
 
       # We need to specify lucene as the top-level defType when using JSON Query DSL in Solr versions
       # between 7.2.0 & 9.4.0. After 9.4.0 this is no longer necessary, but also not harmful to include.

spec/features/advanced_search_spec.rb

@@ -103,6 +103,19 @@
       expect(page).to have_content('Pākistānī ʻaurat dorāhe par')
       expect(page).to have_css('article.document', count: 10)
     end
+
+    it 'returns all records when no query is present' do
+      click_on 'advanced-search-submit'
+      expect(page).to have_content('1 - 10 of 30')
+    end
+
+    it 'performs a faceted search when query is present' do
+      within '#facet-language_ssim' do
+        check 'Urdu 3'
+      end
+      click_on 'advanced-search-submit'
+      expect(page).to have_css('article.document', count: 3)
+    end
   end
 
   describe "prepopulated advanced search form" do