fix(retif): correct parentheses for bin in retif (#1257)

Author: czosel

src/needs-parens.js

@@ -64,6 +64,7 @@ function needsParens(path) {
     case "bin": {
       switch (parent.kind) {
         case "assign":
+        case "retif":
           return ["and", "xor", "or"].includes(node.type);
         case "silent":
         case "cast":

tests/parens/__snapshots__/jsfmt.spec.js.snap

@@ -733,6 +733,7 @@ $var = ($foo ?? $baz) || $baz;
 $var = $foo ?? $baz || $baz;
 $var = ($foo && $baz) ?? $baz;
 $var = $foo && ($baz ?? $baz);
+
 =====================================output=====================================
 <?php
 
@@ -2885,6 +2886,16 @@ $var = ($var ?: ($var ?: $var)) ?: 'string';
 $var = ($var ?: (($var ?: $var) ?: 'string'));
 $var = ($var ?: ($var ?: ($var ?: 'string')));
 
+$var = ($foo and $bar) ? true : false;
+$var = ($foo or $bar) ? true : false;
+$var = ($foo xor $bar) ? true : false;
+$var = ($foo = "bar") ? true : false;
+
+$var = ($foo && $bar) ? true : false;
+$var = ($foo || $bar) ? true : false;
+$var = (!$foo) ? true : false;
+$var = (new $foo) ? true : false;
+
 =====================================output=====================================
 <?php
 
@@ -2951,6 +2962,16 @@ $var = $var ?: ($var ?: $var) ?: 'string';
 $var = $var ?: ($var ?: $var ?: 'string');
 $var = $var ?: ($var ?: ($var ?: 'string'));
 
+$var = ($foo and $bar) ? true : false;
+$var = ($foo or $bar) ? true : false;
+$var = ($foo xor $bar) ? true : false;
+$var = ($foo = "bar") ? true : false;
+
+$var = $foo && $bar ? true : false;
+$var = $foo || $bar ? true : false;
+$var = !$foo ? true : false;
+$var = new $foo() ? true : false;
+
 ================================================================================
 `;
 

tests/parens/bin.php

@@ -358,4 +358,4 @@
 $var = ($foo ?? $baz) || $baz;
 $var = $foo ?? $baz || $baz;
 $var = ($foo && $baz) ?? $baz;
-$var = $foo && ($baz ?? $baz);
+$var = $foo && ($baz ?? $baz);

tests/parens/retif.php

@@ -50,3 +50,13 @@
 $var = ($var ?: ($var ?: $var)) ?: 'string';
 $var = ($var ?: (($var ?: $var) ?: 'string'));
 $var = ($var ?: ($var ?: ($var ?: 'string')));
+
+$var = ($foo and $bar) ? true : false;
+$var = ($foo or $bar) ? true : false;
+$var = ($foo xor $bar) ? true : false;
+$var = ($foo = "bar") ? true : false;
+
+$var = ($foo && $bar) ? true : false;
+$var = ($foo || $bar) ? true : false;
+$var = (!$foo) ? true : false;
+$var = (new $foo) ? true : false;