feat: convert list to short syntax automatically (#1351)

Author: czosel

package.json

@@ -13,7 +13,7 @@
   "dependencies": {
     "linguist-languages": "^7.5.1",
     "mem": "^6.0.1",
-    "php-parser": "glayzzle/php-parser#5a0e2e1bf12517bd1c544c0f4e68482d0362a7b5"
+    "php-parser": "3.0.2"
   },
   "devDependencies": {
     "@babel/preset-env": "^7.7.5",

src/clean.js

@@ -34,7 +34,7 @@ function clean(node, newObj) {
     delete newObj.isDoubleQuote;
   }
 
-  if (node.kind === "array") {
+  if (["array", "list"].includes(node.kind)) {
     // TODO if options are available in this method, assign instead of delete
     delete newObj.shortForm;
   }

src/options.js

@@ -7,7 +7,7 @@ module.exports = {
     since: "0.13.0",
     category: CATEGORY_PHP,
     type: "choice",
-    default: "5.4",
+    default: "7.0",
     description: "Minimum target PHP version.",
     choices: [
       { value: "5.0" },

src/printer.js

@@ -2459,7 +2459,8 @@ function printNode(path, options, print) {
     case "array": {
       const useShortForm =
         (node.kind === "array" && isMinVersion(options.phpVersion, "5.4")) ||
-        (node.kind === "list" && node.shortForm);
+        (node.kind === "list" &&
+          (node.shortForm || isMinVersion(options.phpVersion, "7.1")));
       const open = useShortForm ? "[" : concat([node.kind, "("]);
       const close = useShortForm ? "]" : ")";
 

tests/array/__snapshots__/jsfmt.spec.js.snap

@@ -1555,21 +1555,21 @@ $arr = array(
         ->allOrderBy('nome')
         ->pluck('nome', 'id'),
 );
-[array($id1, $name1)] = $data;
-[array($id1), array($id2), array($id)] = $data;
+[[$id1, $name1]] = $data;
+[[$id1], [$id2], [$id]] = $data;
 [
-    array(
+    [
         $veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongValue,
         $veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongOtherValue,
-    ),
+    ],
 ] = $data;
 ["id" => $id1, "name" => $name1] = $data;
-[array("id" => $id1, "name" => $name1)] = $data;
+[["id" => $id1, "name" => $name1]] = $data;
 [
-    array(
+    [
         "veryVeryVeryVeryLongKey" => $veryVeryVeryVeryLongValue,
         "veryVeryVeryVeryLongOtherKey" => $veryVeryVeryVeryLongValue,
-    ),
+    ],
 ] = $data;
 $arr = array(
     'niveisFederativos' => function () {