Move package metadata to own crate (#1150)

Branched from #1147
Progress towards #1148

Moves our existing package/library infra to a new `oak_package` crate.

The main change is that NAMESPACE is no longer inspected with
tree-sitter but with Rowan.

Author: lionel-

Cargo.lock

@@ -15,7 +15,9 @@ members = [
     "crates/echo",
     "crates/harp",
     "crates/libr",
+    "crates/oak_core",
     "crates/oak_index",
+    "crates/oak_package",
     "crates/stdext",
 ]
 
@@ -75,7 +77,9 @@ log = "0.4.18"
 mime_guess = "2.0.4"
 nix = { version = "0.26.2", features = ["signal"] }
 notify = "6.0.0"
+oak_core = { path = "crates/oak_core" }
 oak_index = { path = "crates/oak_index" }
+oak_package = { path = "crates/oak_package" }
 once_cell = "1.17.1"
 parking_lot = "0.12.3"
 paste = "1.0.14"

Cargo.toml

@@ -44,6 +44,7 @@ log.workspace = true
 mime_guess.workspace = true
 nix.workspace = true
 notify.workspace = true
+oak_package.workspace = true
 once_cell.workspace = true
 regex.workspace = true
 reqwest.workspace = true
@@ -76,6 +77,7 @@ yaml-rust.workspace = true
 ark_test.workspace = true
 assert_matches.workspace = true
 insta.workspace = true
+oak_package = { workspace = true, features = ["testing"] }
 stdext = { workspace = true, features = ["testing"] }
 tempfile.workspace = true
 

crates/ark/Cargo.toml

@@ -14,6 +14,8 @@ use anyhow::bail;
 use anyhow::Result;
 use harp::syntax::is_valid_symbol;
 use harp::syntax::sym_quote_invalid;
+use oak_package::library::Library;
+use oak_package::package::Package;
 use stdext::*;
 use tower_lsp::lsp_types::Diagnostic;
 use tower_lsp::lsp_types::DiagnosticSeverity;
@@ -26,8 +28,6 @@ use crate::lsp::declarations::top_level_declare;
 use crate::lsp::diagnostics_syntax::syntax_diagnostics;
 use crate::lsp::document::Document;
 use crate::lsp::indexer;
-use crate::lsp::inputs::library::Library;
-use crate::lsp::inputs::package::Package;
 use crate::lsp::inputs::source_root::SourceRoot;
 use crate::lsp::state::WorldState;
 use crate::lsp::traits::node::NodeExt;
@@ -1132,17 +1132,17 @@ mod tests {
     use std::path::PathBuf;
 
     use harp::eval::RParseEvalOptions;
+    use oak_package::library::Library;
+    use oak_package::package::Package;
+    use oak_package::package_description::Dcf;
+    use oak_package::package_description::Description;
+    use oak_package::package_namespace::Namespace;
     use once_cell::sync::Lazy;
     use tower_lsp::lsp_types;
     use tower_lsp::lsp_types::Position;
 
     use crate::console::console_inputs;
     use crate::lsp::document::Document;
-    use crate::lsp::inputs::library::Library;
-    use crate::lsp::inputs::package::Package;
-    use crate::lsp::inputs::package_description::Dcf;
-    use crate::lsp::inputs::package_description::Description;
-    use crate::lsp::inputs::package_namespace::Namespace;
     use crate::lsp::state::WorldState;
     use crate::r_task;
 
@@ -1845,7 +1845,7 @@ foo
     #[test]
     fn test_penguins_symbol_no_diagnostic() {
         r_task(|| {
-            let palmerpenguins_dir = crate::lsp::inputs::package::temp_palmerpenguin();
+            let palmerpenguins_dir = oak_package::package::temp_palmerpenguin();
             let palmerpenguins_pkg = Package::load_from_folder(palmerpenguins_dir.path())
                 .unwrap()
                 .unwrap();

crates/ark/src/lsp/diagnostics.rs

@@ -427,13 +427,13 @@ fn new_syntax_diagnostic(
 
 #[cfg(test)]
 mod tests {
+    use oak_package::library::Library;
     use tower_lsp::lsp_types::Diagnostic;
     use tower_lsp::lsp_types::Position;
 
     use crate::lsp::diagnostics::DiagnosticContext;
     use crate::lsp::diagnostics_syntax::syntax_diagnostics;
     use crate::lsp::document::Document;
-    use crate::lsp::inputs::library::Library;
 
     fn text_diagnostics(text: &str) -> Vec<Diagnostic> {
         let document = Document::new(text, None);

crates/ark/src/lsp/diagnostics_syntax.rs

@@ -1,13 +1 @@
-//
-// mod.rs
-//
-// Copyright (C) 2025 by Posit Software, PBC
-//
-//
-
-pub mod library;
-pub mod package;
-pub mod package_description;
-pub mod package_index;
-pub mod package_namespace;
 pub mod source_root;

crates/ark/src/lsp/inputs.rs

@@ -5,7 +5,7 @@
 //
 //
 
-use super::package::Package;
+use oak_package::package::Package;
 
 /// The root of a source tree.
 /// Currently only supports packages, but can be extended to scripts.

crates/ark/src/lsp/inputs/source_root.rs

@@ -18,6 +18,7 @@ use std::sync::RwLock;
 use anyhow::anyhow;
 use futures::stream::FuturesUnordered;
 use futures::StreamExt;
+use oak_package::library::Library;
 use tokio::sync::mpsc;
 use tokio::sync::mpsc::unbounded_channel as tokio_unbounded_channel;
 use tokio::task;
@@ -41,7 +42,6 @@ use crate::lsp::diagnostics::generate_diagnostics;
 use crate::lsp::document::Document;
 use crate::lsp::handlers;
 use crate::lsp::indexer;
-use crate::lsp::inputs::library::Library;
 use crate::lsp::state::WorldState;
 use crate::lsp::state_handlers;
 use crate::lsp::state_handlers::ConsoleInputs;

crates/ark/src/lsp/main_loop.rs

@@ -2,11 +2,11 @@ use std::collections::HashMap;
 use std::path::Path;
 
 use anyhow::anyhow;
+use oak_package::library::Library;
 use url::Url;
 
 use crate::lsp::config::LspConfig;
 use crate::lsp::document::Document;
-use crate::lsp::inputs::library::Library;
 use crate::lsp::inputs::source_root::SourceRoot;
 
 #[derive(Clone, Default, Debug)]

crates/ark/src/lsp/state.rs

@@ -6,6 +6,7 @@
 //
 
 use anyhow::anyhow;
+use oak_package::package::Package;
 use stdext::result::ResultExt;
 use tower_lsp::lsp_types;
 use tower_lsp::lsp_types::CompletionOptions;
@@ -51,7 +52,6 @@ use crate::lsp::config::indent_style_from_lsp;
 use crate::lsp::config::DOCUMENT_SETTINGS;
 use crate::lsp::config::GLOBAL_SETTINGS;
 use crate::lsp::document::Document;
-use crate::lsp::inputs::package::Package;
 use crate::lsp::inputs::source_root::SourceRoot;
 use crate::lsp::main_loop::DidCloseVirtualDocumentParams;
 use crate::lsp::main_loop::DidOpenVirtualDocumentParams;