alapenna: review post-start.sh logic

Author: deviantony

Dockerfile

@@ -86,7 +86,6 @@ ENV GOROOT="/usr/local/go" \
     GOPATH="/root/go" \
     PATH="/usr/local/go/bin:/root/go/bin:/root/.nvm/versions/node/v${NODE_VERSION}/bin:${PATH}"
 
-# Set a custom entrypoint
-COPY entrypoint.sh /entrypoint.sh
-RUN chmod +x /entrypoint.sh
-ENTRYPOINT ["/entrypoint.sh"]
+# Inject a post-start.sh script that can be used via postStartCommand
+COPY post-start.sh /post-start.sh
+RUN chmod +x /post-start.sh

entrypoint.sh post-start.shentrypoint.sh renamed to post-start.sh

@@ -1,11 +1,7 @@
 #!/bin/bash
 
-# This is an entrypoint script that is used execute some actions 
-# when the container is started.
+# This script can trigger actions post dev container startup.
 
 # We clean-up the tmp folder as part of the startup because it can 
 # be flooded very fast with files and folders related to vscode, devextension, yarn, gobuilds etc...
 rm -rf /tmp/*
-
-# Execute the default command from the base image
-exec "$@"

user-toolkits/alapenna/Dockerfile

@@ -41,4 +41,4 @@ RUN apt install -y protobuf-compiler
 RUN printf '[url "ssh://git@github.com/"]\n\tinsteadOf = https://github.com/\n' > /root/.gitconfig
 
 # Update .zshrc
-RUN echo 'export PATH="$PATH:/root/.local/bin"' >> /root/.zshrc
+RUN echo 'export PATH="$PATH:/root/.local/bin"' >> /root/.zshrc

user-toolkits/alapenna/devcontainer.json

@@ -1,6 +1,7 @@
 {
 	"name": "portainer-dev-toolkit",
 	"image": "portainer-dev-toolkit:alapenna",
+	"postStartCommand": "/post-start.sh",
 	"forwardPorts": [6443, 8999, 9000],
 	"appPort": ["8000:8000", "9443:9443"],
 	"mounts": [
@@ -24,4 +25,4 @@
 		}
 	},
 	"remoteUser": "root"
-}
+}