Put sort() outside of while() and use php_ext

Author: Crizz0

config/services.yml

@@ -9,6 +9,7 @@ services:
         class: phpbbde\pastebin\functions\utility
         arguments:
             - '%phpbbde.pastebin.geshilangs%'
+            - '%core.php_ext%'
     phpbbde.pastebin.functions.pastebin:
         class: phpbbde\pastebin\functions\pastebin
         arguments:

functions/utility.php

@@ -31,13 +31,18 @@ class utility
 	 */
 	var $geshi_list	= array();
 
+	/** @var string */
+	protected $php_ext;
+
 	/**
 	 * Constructor
+	 * @param string $php_ext
 	 */
-	function __construct($geshi_dir)
+	function __construct($geshi_dir, $php_ext)
 	{
 		$this->geshi_dir	= $geshi_dir;
 		$this->geshi_list	= $this->geshi_list();
+		$this->php_ext 		= $php_ext;
 	}
 
 
@@ -54,8 +59,6 @@ function geshi_check($needle)
 	 */
 	function geshi_list()
 	{
-		global $phpEx;
-
 		$geshi_list = array();
 
 		$d = dir($this->geshi_dir);
@@ -66,13 +69,15 @@ function geshi_list()
 				continue;
 			}
 
-			if (($substr_end = strpos($file, ".$phpEx")) !== false)
+			if (($substr_end = strpos($file, ".$this->php_ext")) !== false)
 			{
-				@sort($geshi_list[] = substr($file, 0, $substr_end));
+				$geshi_list[] = substr($file, 0, $substr_end);
 			}
 		}
 		$d->close();
 
+		sort($geshi_list);
+
 		return $geshi_list;
 	}