Skip to content

Commit ff098c7

Browse files
committed
Merge branch 'PHP-8.5'
* PHP-8.5: Fix memory leaks and missing error propagation when php_openssl_csr_make() fails to set a version
2 parents 43f3245 + 2c8de71 commit ff098c7

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

ext/openssl/openssl_backend_common.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,13 +1088,15 @@ zend_result php_openssl_csr_make(struct php_x509_request * req, X509_REQ * csr,
10881088
}
10891089
}
10901090
}
1091+
1092+
if (!X509_REQ_set_pubkey(csr, req->priv_key)) {
1093+
php_openssl_store_errors();
1094+
}
10911095
} else {
10921096
php_openssl_store_errors();
1097+
return FAILURE;
10931098
}
10941099

1095-
if (!X509_REQ_set_pubkey(csr, req->priv_key)) {
1096-
php_openssl_store_errors();
1097-
}
10981100
return SUCCESS;
10991101
}
11001102

0 commit comments

Comments
 (0)