Skip to content

Commit 5102f72

Browse files
committed
- Resolves skipped/incomplete tests
- Added unit/integration tests for count() - Various minor code cleanups
1 parent 25c1429 commit 5102f72

10 files changed

Lines changed: 192 additions & 223 deletions

composer.lock

Lines changed: 46 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

phpstan-baseline.neon

Lines changed: 0 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,6 @@ parameters:
3030
count: 1
3131
path: src/Connection.php
3232

33-
-
34-
message: '#^PHPDoc tag @var for variable \$connectionInstance contains unknown class PhpDb\\Mysql\\Driver\\ConnectionInterface\.$#'
35-
identifier: class.notFound
36-
count: 1
37-
path: src/Container/DriverInterfaceFactory.php
38-
39-
-
40-
message: '#^PHPDoc tag @var for variable \$resultInstance contains unknown class PhpDb\\Mysql\\Driver\\ResultInterface\.$#'
41-
identifier: class.notFound
42-
count: 1
43-
path: src/Container/DriverInterfaceFactory.php
44-
45-
-
46-
message: '#^PHPDoc tag @var for variable \$statementInstance contains unknown class PhpDb\\Mysql\\Driver\\StatementInterface\.$#'
47-
identifier: class.notFound
48-
count: 1
49-
path: src/Container/DriverInterfaceFactory.php
50-
5133
-
5234
message: '#^Instanceof between PhpDb\\Mysql\\Connection and PhpDb\\Adapter\\Driver\\DriverAwareInterface will always evaluate to true\.$#'
5335
identifier: instanceof.alwaysTrue
@@ -126,12 +108,6 @@ parameters:
126108
count: 3
127109
path: src/Pdo/Driver.php
128110

129-
-
130-
message: '#^Parameter \#3 \$rowCount of method PhpDb\\Adapter\\Driver\\Pdo\\Result\:\:initialize\(\) expects Closure\|int, null given\.$#'
131-
identifier: argument.type
132-
count: 1
133-
path: src/Pdo/Driver.php
134-
135111
-
136112
message: '#^Instanceof between mysqli_stmt and mysqli_stmt will always evaluate to true\.$#'
137113
identifier: instanceof.alwaysTrue
@@ -192,42 +168,6 @@ parameters:
192168
count: 1
193169
path: src/Statement.php
194170

195-
-
196-
message: '#^Call to an undefined method PhpDb\\Mysql\\Driver\:\:quoteValue\(\)\.$#'
197-
identifier: method.notFound
198-
count: 2
199-
path: test/integration/AdapterPlatformTest.php
200-
201-
-
202-
message: '#^Parameter \#1 \$connection of class PhpDb\\Mysql\\Driver constructor expects PhpDb\\Mysql\\Connection, PDO given\.$#'
203-
identifier: argument.type
204-
count: 1
205-
path: test/integration/AdapterPlatformTest.php
206-
207-
-
208-
message: '#^Parameter \#1 \$connection of class PhpDb\\Mysql\\Driver constructor expects PhpDb\\Mysql\\Connection, mysqli given\.$#'
209-
identifier: argument.type
210-
count: 1
211-
path: test/integration/AdapterPlatformTest.php
212-
213-
-
214-
message: '#^Parameter \#2 \$statementPrototype of class PhpDb\\Mysql\\Driver constructor expects PhpDb\\Mysql\\Statement, PhpDb\\Adapter\\Driver\\Pdo\\Statement given\.$#'
215-
identifier: argument.type
216-
count: 1
217-
path: test/integration/AdapterPlatformTest.php
218-
219-
-
220-
message: '#^Property PhpDbIntegrationTest\\Mysql\\Platform\\AdapterPlatformTest\:\:\$adapters \(array\<string, mysqli\|PDO\>\) does not accept array\<string, mysqli\|PDO\|PhpDb\\Mysql\\Connection\>\.$#'
221-
identifier: assign.propertyType
222-
count: 1
223-
path: test/integration/AdapterPlatformTest.php
224-
225-
-
226-
message: '#^Property PhpDbIntegrationTest\\Mysql\\Platform\\AdapterPlatformTest\:\:\$adapters \(array\<string, mysqli\|PDO\>\) does not accept array\<string, mysqli\|PDO\|PhpDb\\Mysql\\Pdo\\Connection\>\.$#'
227-
identifier: assign.propertyType
228-
count: 1
229-
path: test/integration/AdapterPlatformTest.php
230-
231171
-
232172
message: '#^Parameter \#1 \$container of callable PhpDb\\Mysql\\Container\\DriverInterfaceFactory expects Laminas\\ServiceManager\\ServiceManager, Psr\\Container\\ContainerInterface given\.$#'
233173
identifier: argument.type
@@ -246,21 +186,3 @@ parameters:
246186
count: 1
247187
path: test/integration/Pdo/ConnectionTest.php
248188

249-
-
250-
message: '#^Unreachable statement \- code above always terminates\.$#'
251-
identifier: deadCode.unreachable
252-
count: 1
253-
path: test/integration/Pdo/QueryTest.php
254-
255-
-
256-
message: '#^Unreachable statement \- code above always terminates\.$#'
257-
identifier: deadCode.unreachable
258-
count: 1
259-
path: test/integration/Pdo/TableGatewayTest.php
260-
261-
-
262-
message: '#^Unreachable statement \- code above always terminates\.$#'
263-
identifier: deadCode.unreachable
264-
count: 1
265-
path: test/integration/TableGatewayTest.php
266-

0 commit comments

Comments
 (0)