[#73798] Remove scrum_projects feature flag

Make Backlogs use the sprint-based behavior unconditionally and
remove the old feature-flagged branches from controllers, routes,
representers, and supporting helpers.

Update the affected Backlogs specs and PDF export expectations to
match the permanent sprint model and keep list reordering stable when
moving work packages between backlog and sprint scopes.

https://community.openproject.org/wp/73798

Author: myabc

app/forms/versions/form.rb

@@ -110,29 +110,6 @@ class Form < ApplicationForm
         end
       end
 
-      if backlogs_enabled?
-        setting = version_setting_for_project
-
-        f.select_list(
-          name: "version[version_settings_attributes][][display]",
-          scope_name_to_model: false,
-          label: I18n.t(:label_column_in_backlog),
-          input_width: :small
-        ) do |list|
-          position_display_options.each do |label, value|
-            list.option(label:, value:, selected: setting.display == value)
-          end
-        end
-
-        if setting.persisted?
-          f.hidden(
-            name: "version[version_settings_attributes][][id]",
-            value: setting.id,
-            scope_name_to_model: false
-          )
-        end
-      end
-
       f.hidden(
         name: "project_id",
         value: project.id,
@@ -177,35 +154,5 @@ def custom_fields
     def wiki_pages_disabled?
       contract.assignable_wiki_pages.none?
     end
-
-    def backlogs_enabled?
-      resolved_project.backlogs_enabled? && !OpenProject::FeatureDecisions.scrum_projects_active?
-    end
-
-    def resolved_project
-      @project || version.project
-    end
-
-    def version_setting_for_project
-      setting = version.version_settings.detect { |vs| vs.project_id == resolved_project.id || vs.project_id.nil? }
-      setting || version.version_settings.new(display: VersionSetting::DISPLAY_LEFT, project: resolved_project)
-    end
-
-    def position_display_options
-      [VersionSetting::DISPLAY_NONE,
-       VersionSetting::DISPLAY_LEFT,
-       VersionSetting::DISPLAY_RIGHT].map { |s| [humanize_display_option(s), s] }
-    end
-
-    def humanize_display_option(option)
-      case option
-      when VersionSetting::DISPLAY_NONE
-        I18n.t("version_settings_display_option_none")
-      when VersionSetting::DISPLAY_LEFT
-        I18n.t("version_settings_display_option_left")
-      when VersionSetting::DISPLAY_RIGHT
-        I18n.t("version_settings_display_option_right")
-      end
-    end
   end
 end

app/models/permitted_params.rb

@@ -359,18 +359,14 @@ def category
   end
 
   def version
-    # `version_settings_attributes` is from a plugin. Unfortunately as it stands
-    # now it is less work to do it this way than have the plugin override this
-    # method. We hopefully will change this in the future.
     permitted_params = params.fetch(:version, {}).permit(:name,
                                                          :description,
                                                          :effective_date,
                                                          :due_date,
                                                          :start_date,
                                                          :wiki_page_title,
                                                          :status,
-                                                         :sharing,
-                                                         version_settings_attributes: %i(id display project_id))
+                                                         :sharing)
 
     permitted_params.merge(custom_field_values(:version, required: false))
   end

config/initializers/feature_decisions.rb

@@ -61,11 +61,6 @@
                                   description: "Enables Jira Migration Tool.",
                                   force_active: false
 
-OpenProject::FeatureDecisions.add :scrum_projects,
-                                  description: "Enables an overhauled version of the backlogs module to " \
-                                               "support Scrum projects with a new sprint planning experience. ",
-                                  force_active: true
-
 OpenProject::FeatureDecisions.add :user_working_times,
                                   description: "Enables tracking of user working hours and non-working days."
 

modules/backlogs/app/components/projects/settings/backlogs/settings_header_component.html.erb

@@ -44,7 +44,7 @@ See COPYRIGHT and LICENSE files for more details.
         t.with_text { t("backlogs.done_status") }
       end
 
-      if OpenProject::FeatureDecisions.scrum_projects_active? && User.current.allowed_in_project?(:share_sprint, project)
+      if User.current.allowed_in_project?(:share_sprint, project)
         tab_nav.with_tab(
           selected: selected_tab?(:sharing),
           href: project_settings_backlog_sharing_path(project)

modules/backlogs/app/controllers/inbox_controller.rb

@@ -31,7 +31,6 @@
 class InboxController < RbApplicationController
   include OpTurbo::ComponentStream
 
-  before_action :not_authorized_on_feature_flag_inactive
   before_action :load_work_package
 
   # Deferred ActionMenu items (Primer include-fragment).

modules/backlogs/app/controllers/projects/settings/backlogs_controller.rb

@@ -42,11 +42,7 @@ def update
   end
 
   def rebuild_positions
-    if OpenProject::FeatureDecisions.scrum_projects_active?
-      WorkPackages::RebuildPositionsService.new(project: @project).call
-    else
-      @project.rebuild_positions
-    end
+    WorkPackages::RebuildPositionsService.new(project: @project).call
     flash[:notice] = I18n.t("backlogs.positions_rebuilt_successfully")
 
     redirect_to_backlogs_settings

modules/backlogs/app/controllers/rb_application_controller.rb

@@ -33,7 +33,6 @@ class RbApplicationController < ApplicationController
   helper :rb_common
 
   before_action :load_sprint_and_project,
-                :check_if_plugin_is_configured,
                 :authorize
 
   private
@@ -54,25 +53,8 @@ def load_sprint
     @sprint_id = params.delete(:sprint_id)
     return unless @sprint_id
 
-    @sprint = if OpenProject::FeatureDecisions.scrum_projects_active?
-                Agile::Sprint.for_project(@project).visible.find(@sprint_id)
-              else
-                Sprint.visible.apply_to(@project).find(@sprint_id)
-              end
+    @sprint = Agile::Sprint.for_project(@project).visible.find_by(id: @sprint_id) ||
+      Sprint.visible.apply_to(@project).find(@sprint_id)
   end
 
-  def check_if_plugin_is_configured
-    return if OpenProject::FeatureDecisions.scrum_projects_active?
-
-    settings = Setting.plugin_openproject_backlogs
-    if settings["story_types"].blank? || settings["task_type"].blank?
-      respond_to do |format|
-        format.html { render template: "shared/not_configured" }
-      end
-    end
-  end
-
-  def not_authorized_on_feature_flag_inactive
-    render_403 unless OpenProject::FeatureDecisions.scrum_projects_active?
-  end
 end

modules/backlogs/app/controllers/rb_burndown_charts_controller.rb

@@ -32,7 +32,7 @@ class RbBurndownChartsController < RbApplicationController
   helper :burndown_charts
 
   def show
-    @burndown = if OpenProject::FeatureDecisions.scrum_projects_active?
+    @burndown = if @sprint.is_a?(Agile::Sprint)
                   Burndown.new(@sprint, @project)
                 else
                   @sprint.burndown(@project)

modules/backlogs/app/controllers/rb_master_backlogs_controller.rb

@@ -31,15 +31,10 @@
 class RbMasterBacklogsController < RbApplicationController
   include WorkPackages::WithSplitView
 
-  # Without the feature flag, there is only the top level menu item, select it
-  menu_item :backlogs_legacy
-
-  # With the feature flag, we have a proper menu, select the correct sub entry
   current_menu_item [:backlog] do
     :backlog
   end
 
-  before_action :not_authorized_on_feature_flag_inactive, only: :backlog
   before_action :load_backlogs, only: %i[index backlog]
 
   def backlog
@@ -51,12 +46,10 @@ def backlog
   end
 
   def index
-    return redirect_to action: :backlog if OpenProject::FeatureDecisions.scrum_projects_active?
-
     if turbo_frame_request?
-      render partial: "list", layout: false
+      render partial: "backlog_list", layout: false
     else
-      render :index
+      render :backlog
     end
   end
 
@@ -65,39 +58,25 @@ def details
       render "work_packages/split_view", layout: false
     else
       load_backlogs
-
-      if OpenProject::FeatureDecisions.scrum_projects_active?
-        render :backlog
-      else
-        render :index
-      end
+      render :backlog
     end
   end
 
   def split_view_base_route
-    if OpenProject::FeatureDecisions.scrum_projects_active?
-      backlog_backlogs_project_backlogs_path(request.query_parameters)
-    else
-      backlogs_project_backlogs_path(request.query_parameters)
-    end
+    backlog_backlogs_project_backlogs_path(request.query_parameters)
   end
 
   private
 
   def load_backlogs
     @owner_backlogs = Backlog.owner_backlogs(@project)
-
-    if OpenProject::FeatureDecisions.scrum_projects_active?
-      @sprints = Agile::Sprint.for_project(@project).not_completed.order_by_date
-      @stories_by_sprint_id = WorkPackage
-        .where(sprint: @sprints, project: @project)
-        .includes(:type, :status)
-        .order_by_position
-        .group_by(&:sprint_id)
-      @active_sprint_ids = @sprints.select(&:active?).map(&:id)
-      @inbox_work_packages = Backlog.inbox_for(project: @project)
-    else
-      @sprint_backlogs = Backlog.sprint_backlogs(@project)
-    end
+    @sprints = Agile::Sprint.for_project(@project).not_completed.order_by_date
+    @stories_by_sprint_id = WorkPackage
+      .where(sprint: @sprints, project: @project)
+      .includes(:type, :status)
+      .order_by_position
+      .group_by(&:sprint_id)
+    @active_sprint_ids = @sprints.select(&:active?).map(&:id)
+    @inbox_work_packages = Backlog.inbox_for(project: @project)
   end
 end

modules/backlogs/app/controllers/rb_stories_controller.rb

@@ -216,7 +216,7 @@ def replace_sprint_component_via_turbo_stream(sprint:)
 
   def load_story
     @allowed_stories =
-      if OpenProject::FeatureDecisions.scrum_projects_active?
+      if @sprint.is_a?(Agile::Sprint)
         WorkPackage.visible.where(sprint: @sprint, project: @project)
       else
         Story.visible.where(Story.condition(@project, @sprint))