Added delete project, delete file functionality. Added pageobject and small updates to versioning and skills.md

Author: Ihor-Khomenko

.cursor/skills/tests/SKILL.md

@@ -40,6 +40,7 @@ Page object inheritance:
 ## Page Object Conventions
 
 - When adding a new test, first check if an existing page object can be reused or extended before creating a new one.
+- Do not put UI flows (navigations, clicks, form fills) in `utils/test-helpers.ts`; move them into page objects.
 - All page objects must:
   - Extend the appropriate domain base page (`OpenProjectBasePage`, `NextcloudBasePage`, `KeycloakBasePage`) or `BasePage`.
   - Load locators via the base constructor using the correct locator JSON file.
@@ -108,12 +109,15 @@ try {
 ## Test Helpers and Reuse
 
 - Use functions for repetitive actions so they can be reused later rather than copied into each spec.
-- Shared helpers live primarily in:
-  - `utils/test-helpers.ts` for high-level flows (e.g., `ensureProjectExists`, `ensureProjectHasNextcloudStorage`, `ensureDemoProjectCopyViaUi`).
-  - `utils/openproject-api.ts` for direct API interactions with OpenProject (projects, users, storages).
+- **`utils/test-helpers.ts`** must contain only API-specific helpers and orchestration that combines API checks with page objects for UI fallback:
+  - API helpers: `ensureUserIsAdmin`, `ensureProjectExists`, `getProjectStorages`, `ensureProjectHasNoNextcloudStorage`.
+  - Orchestration: `ensureProjectHasNextcloudStorage` (API checks + optional UI via `OpenProjectProjectStoragesPage`).
+- **`utils/openproject-api.ts`** for direct API interactions with OpenProject (projects, users, storages).
+- **UI flows** belong in page objects, not test-helpers:
+  - `OpenProjectHomePage.copyDemoProjectViaUi(newIdentifier)` – copy demo project via UI.
+  - `OpenProjectProjectStoragesPage.navigateTo(identifier)`, `addNextcloudStorage()`, `hasNextcloudStorage()` – project storages UI.
 - When adding new cross-test flows:
-  - First, see if existing helpers can be extended.
-  - If needed, create a new helper function with a clear name and parameters.
+  - Prefer page objects for UI flows; use test-helpers only for API or orchestration.
 - After UI actions that should succeed, verify the expected UI feedback:
   - Example: after adding Nextcloud storage from OpenProject, wait for the success banner (`storageCreationSuccessMessage` locator, text `"Successful creation."`).
 

README.md

@@ -137,12 +137,13 @@ import { ensureProjectHasNextcloudStorage } from '../utils/test-helpers';
 await ensureProjectHasNextcloudStorage('demo-project');
 ```
 
-- Copy the demo project via UI using the existing page objects:
+- Copy the demo project via UI using page objects:
 
 ```typescript
-import { ensureDemoProjectCopyViaUi } from '../utils/test-helpers';
+import { OpenProjectHomePage } from '../pageobjects/openproject';
 
-await ensureDemoProjectCopyViaUi(page, 'test');
+const homePage = new OpenProjectHomePage(page);
+await homePage.copyDemoProjectViaUi('test');
 ```
 
 ## Environment Variables

global-setup.ts

@@ -1,6 +1,7 @@
 import { FullConfig } from '@playwright/test';
 import { waitForSetupJobComplete, setupJobExists, isSetupJobComplete } from './utils/pod-waiter';
 import { detectAllVersions } from './utils/version-detect';
+import { ensureKeycloakDirectAccessForNextcloud } from './utils/nextcloud-api';
 import { getErrorMessage } from './utils/error-utils';
 import { logInfo, logError, logWarn } from './utils/logger';
 
@@ -69,6 +70,15 @@ async function globalSetup(config: FullConfig) {
     logWarn('⚠️  Version detection failed:', getErrorMessage(error));
     logWarn('   Tests will use "not-detected" as fallback.');
   }
+
+  // ── Step 3: Enable direct access grants for Nextcloud WebDAV ────────
+  try {
+    await ensureKeycloakDirectAccessForNextcloud();
+    logInfo('✓ Keycloak direct access grants enabled for Nextcloud WebDAV');
+  } catch (error: unknown) {
+    logWarn('⚠️  Failed to enable Keycloak direct access grants:', getErrorMessage(error));
+    logWarn('   Nextcloud WebDAV operations may fail.');
+  }
 }
 
 export default globalSetup;

pageobjects/openproject/OpenProjectHomePage.ts

@@ -108,6 +108,15 @@ export class OpenProjectHomePage extends OpenProjectBasePage {
     ]);
   }
 
+  /**
+   * Copy the demo project via UI: waits for home, navigates to all projects, copies demo project to the given identifier.
+   */
+  async copyDemoProjectViaUi(newIdentifier: string): Promise<void> {
+    await this.waitForReady();
+    await this.navigateToAllProjects();
+    await this.copyDemoProjectTo(newIdentifier);
+  }
+
   async copyDemoProjectTo(name: string): Promise<void> {
     const demoProjectKebabButton = this.getLocator('demoProjectKebabButton').first();
     await demoProjectKebabButton.waitFor({ state: 'visible', timeout: 15000 });

pageobjects/openproject/OpenProjectProjectStoragesPage.ts

@@ -0,0 +1,84 @@
+import { Page } from '@playwright/test';
+import { OpenProjectBasePage } from './OpenProjectBasePage';
+
+/**
+ * Page object for a project's external file storages settings page.
+ * Supports adding Nextcloud storage via the UI.
+ */
+export class OpenProjectProjectStoragesPage extends OpenProjectBasePage {
+  constructor(page: Page) {
+    super(page);
+  }
+
+  /**
+   * Navigate to a project's external file storages page.
+   */
+  async navigateToProjectStorages(projectIdentifier: string): Promise<void> {
+    await this.navigateToProjectStoragesExternal(projectIdentifier);
+    const escaped = projectIdentifier.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+    const pattern = new RegExp(
+      `.*/projects/${escaped}/settings/project_storages/external_file_storages.*`
+    );
+    await this.page.waitForURL(pattern, { timeout: 15000 });
+  }
+
+  /**
+   * Check if Nextcloud storage row is already present on the page.
+   * Assumes we are on the project storages external page.
+   */
+  async hasNextcloudStorage(): Promise<boolean> {
+    const nextcloudStorageRow = this.getLocator('nextcloudStorageRow');
+    const count = await nextcloudStorageRow.count();
+    return count > 0;
+  }
+
+  /**
+   * Add Nextcloud storage to the current project via the UI.
+   * Assumes we are on the project storages external page and storage is not yet linked.
+   */
+  async addNextcloudStorage(): Promise<void> {
+    const newStorageLink = this.getLocator('newStorageLink');
+    await newStorageLink.waitFor({ state: 'visible', timeout: 10000 });
+    await newStorageLink.click();
+    await this.page.waitForURL(/\/projects\/[^/]+\/settings\/project_storages\/new/, {
+      timeout: 15000,
+    });
+
+    const addFileStorageHeading = this.getLocator('addFileStorageHeading').first();
+    await addFileStorageHeading.waitFor({ state: 'visible', timeout: 10000 });
+
+    const storageDropdown = this.getLocator('storageDropdown');
+    await storageDropdown.waitFor({ state: 'visible', timeout: 10000 });
+
+    const selectedOption = storageDropdown.locator('option:checked');
+    const selectedText = (await selectedOption.textContent())?.toLowerCase() ?? '';
+    if (!selectedText.includes('nextcloud')) {
+      const nextcloudOption = storageDropdown.locator('option', { hasText: /nextcloud/i }).first();
+      if ((await nextcloudOption.count()) === 0) {
+        throw new Error('Nextcloud option is not available in the storage dropdown.');
+      }
+      const nextcloudValue = await nextcloudOption.getAttribute('value');
+      if (!nextcloudValue) {
+        throw new Error('Nextcloud option is missing a value attribute.');
+      }
+      await storageDropdown.selectOption(nextcloudValue);
+    }
+
+    const continueButton = this.getLocator('continueButton');
+    await continueButton.waitFor({ state: 'visible', timeout: 10000 });
+    await continueButton.click();
+
+    const automaticFolderModeRadio = this.getLocator('automaticFolderModeRadio');
+    await automaticFolderModeRadio.waitFor({ state: 'visible', timeout: 10000 });
+    if (!(await automaticFolderModeRadio.isChecked())) {
+      await automaticFolderModeRadio.check();
+    }
+
+    const addButton = this.getLocator('addButton');
+    await addButton.waitFor({ state: 'visible', timeout: 10000 });
+    await addButton.click();
+
+    const successMessage = this.getLocator('storageCreationSuccessMessage');
+    await successMessage.waitFor({ state: 'visible', timeout: 15000 });
+  }
+}

pageobjects/openproject/index.ts

@@ -1,4 +1,5 @@
 export { OpenProjectBasePage } from './OpenProjectBasePage';
 export { OpenProjectLoginPage } from './OpenProjectLoginPage';
 export { OpenProjectHomePage } from './OpenProjectHomePage';
+export { OpenProjectProjectStoragesPage } from './OpenProjectProjectStoragesPage';
 

tests/base-test.ts

@@ -0,0 +1,71 @@
+import { test as base, expect } from '@playwright/test';
+import { Page } from '@playwright/test';
+import { testConfig } from '../utils/config';
+
+export const test = base.extend({});
+
+test.beforeEach(async ({ page }, testInfo) => {
+  const versions = [
+    { type: 'openproject_version', description: `OpenProject: ${testConfig.openproject.version}` },
+    { type: 'nextcloud_version', description: `Nextcloud: ${testConfig.nextcloud.version}` },
+    { type: 'nc_api_version', description: `NC API: ${testConfig.nextcloud.apiVersion}` },
+    { type: 'integration_app', description: `Integration App: ${testConfig.nextcloud.integrationAppVersion}` },
+    { type: 'team_folders', description: `Team Folders: ${testConfig.nextcloud.teamFoldersVersion}` },
+    { type: 'keycloak_version', description: `Keycloak: ${testConfig.keycloak.version}` },
+  ];
+  for (const ann of versions) {
+    testInfo.annotations.push(ann);
+  }
+
+  attachDebugListeners(page);
+});
+
+export function attachDebugListeners(page: Page): void {
+  page.on('framenavigated', (frame) => {
+    if (frame === page.mainFrame()) {
+      console.log(`[PAGE NAVIGATION] Frame navigated to: ${frame.url()}`);
+    }
+  });
+  page.on('request', (request) => {
+    console.log(`[NETWORK REQUEST] ${request.method()} ${request.url()}`);
+  });
+  page.on('response', (response) => {
+    console.log(`[NETWORK RESPONSE] ${response.status()} ${response.url()}`);
+  });
+  page.on('console', (msg) => {
+    console.log(`[PAGE CONSOLE] ${msg.type()}: ${msg.text()}`);
+  });
+}
+
+/**
+ * Build a URL regex for a given host and path.
+ * Host can be a hostname (e.g. "openproject.test") or a full URL.
+ */
+export function urlForHost(path: string, host: string): RegExp {
+  const escapeForRegex = (value: string): string =>
+    value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  const resolveHostname = (value: string): string => {
+    try {
+      return new URL(value).hostname;
+    } catch {
+      return value;
+    }
+  };
+  const escapedHost = escapeForRegex(resolveHostname(host));
+  const cleanPath = path.startsWith('/') ? path : `/${path}`;
+  const pathPattern = cleanPath.endsWith('/')
+    ? cleanPath.slice(0, -1) + '/?'
+    : cleanPath + '/?';
+  return new RegExp(`^https?://${escapedHost}${pathPattern}$`);
+}
+
+export const openProjectUrl = (path: string) =>
+  urlForHost(path, testConfig.openproject.host);
+export const nextcloudUrl = (path: string) =>
+  urlForHost(path, testConfig.nextcloud.host);
+export const keycloakUrl = (path: string) =>
+  urlForHost(path, testConfig.keycloak.host);
+
+export const integrationTags = { tag: ['@regression', '@integration'] };
+
+export { expect };

tests/opncintegration/kc-integration.spec.ts

@@ -1,46 +1,7 @@
-import { test, expect } from '@playwright/test';
+import { test, expect, integrationTags } from '../base-test';
 import { KeycloakLoginPage, KeycloakHomePage } from '../../pageobjects/keycloak';
-import { testConfig } from '../../utils/config';
-
-/**
- * Build a URL regex for the configured Keycloak host and a given path.
- */
-function keycloakUrl(path: string): RegExp {
-  const escapeForRegex = (value: string): string => value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-  const resolveHostname = (value: string): string => {
-    try {
-      return new URL(value).hostname;
-    } catch {
-      return value;
-    }
-  };
-  const host = escapeForRegex(resolveHostname(testConfig.keycloak.host));
-  const cleanPath = path.startsWith('/') ? path : `/${path}`;
-  const pathPattern = cleanPath.endsWith('/') ? cleanPath.slice(0, -1) + '/?' : cleanPath + '/?';
-  return new RegExp(`^https?://${host}${pathPattern}$`);
-}
-
-test.describe('SSO External - Keycloak Integration', { tag: ['@regression', '@integration'] }, () => {
-  test.beforeEach(async ({ page }) => {
-    page.on('framenavigated', (frame) => {
-      if (frame === page.mainFrame()) {
-        console.log(`[PAGE NAVIGATION] Frame navigated to: ${frame.url()}`);
-      }
-    });
-
-    page.on('request', (request) => {
-      console.log(`[NETWORK REQUEST] ${request.method()} ${request.url()}`);
-    });
-
-    page.on('response', (response) => {
-      console.log(`[NETWORK RESPONSE] ${response.status()} ${response.url()}`);
-    });
-
-    page.on('console', (msg) => {
-      console.log(`[PAGE CONSOLE] ${msg.type()}: ${msg.text()}`);
-    });
-  });
 
+test.describe('SSO External - Keycloak Integration', integrationTags, () => {
   test('should login to Keycloak and check op and nc client are present', { tag: ['@smoke'] }, async ({ page }) => {
     const loginPage = new KeycloakLoginPage(page);
     await loginPage.login();

tests/opncintegration/nc-integration.spec.ts

@@ -1,46 +1,7 @@
-import { test, expect } from '@playwright/test';
+import { test, expect, integrationTags } from '../base-test';
 import { NextcloudLoginPage, NextcloudActiveAppsPage, NextcloudOpenIDConnectPage } from '../../pageobjects/nextcloud';
-import { testConfig } from '../../utils/config';
-
-/**
- * Build a URL regex for the configured Nextcloud host and a given path.
- */
-function nextcloudUrl(path: string): RegExp {
-  const escapeForRegex = (value: string): string => value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-  const resolveHostname = (value: string): string => {
-    try {
-      return new URL(value).hostname;
-    } catch {
-      return value;
-    }
-  };
-  const host = escapeForRegex(resolveHostname(testConfig.nextcloud.host));
-  const cleanPath = path.startsWith('/') ? path : `/${path}`;
-  const pathPattern = cleanPath.endsWith('/') ? cleanPath.slice(0, -1) + '/?' : cleanPath + '/?';
-  return new RegExp(`^https?://${host}${pathPattern}$`);
-}
-
-test.describe('SSO External - Nextcloud Integration', { tag: ['@regression', '@integration'] }, () => {
-  test.beforeEach(async ({ page }) => {
-    page.on('framenavigated', (frame) => {
-      if (frame === page.mainFrame()) {
-        console.log(`[PAGE NAVIGATION] Frame navigated to: ${frame.url()}`);
-      }
-    });
-
-    page.on('request', (request) => {
-      console.log(`[NETWORK REQUEST] ${request.method()} ${request.url()}`);
-    });
-
-    page.on('response', (response) => {
-      console.log(`[NETWORK RESPONSE] ${response.status()} ${response.url()}`);
-    });
-
-    page.on('console', (msg) => {
-      console.log(`[PAGE CONSOLE] ${msg.type()}: ${msg.text()}`);
-    });
-  });
 
+test.describe('SSO External - Nextcloud Integration', integrationTags, () => {
   test('should login to Nextcloud and verify Keycloak provider details', async ({ page }) => {
     const loginPage = new NextcloudLoginPage(page);
     const dashboardPage = await loginPage.login('admin', 'admin');
@@ -67,12 +28,6 @@ test.describe('SSO External - Nextcloud Integration', { tag: ['@regression', '@i
     await activeAppsPage.waitForReady();
     await activeAppsPage.findOpenProjectIntegrationApp();
     const appVersion = await activeAppsPage.getOpenProjectIntegrationAppVersion();
-    const originalTitle = test.info().title;
-    test.info().title = `${originalTitle} (v${appVersion})`;    
-    test.info().annotations.push({
-      type: 'app_version',
-      description: `OpenProject Integration App Version: ${appVersion}`
-    });
 
     console.log(`[TEST RESULT] OpenProject Integration App Version: ${appVersion}`);
     const appLink = activeAppsPage.getOpenProjectIntegrationAppLink();