Fix data race bug: floating windows could stuck in a corner

#1987

AeroSpace has idempotent architecture: hideInCorner can be called multiple times. isHiddenInCorner serves as guard
against writing invalid values to prevUnhiddenProportionalPositionInsideWorkspaceRect. We should make sure that there
are no suspension points between the guard check and the prevUnhiddenProportionalPositionInsideWorkspaceRect assignment.

Kudos to the community for finding this bug and the root cause. Specifically to:
- https://github.com/fbuetler (#1875 (comment))
- https://github.com/tweezerticle (#1875 (comment))
- https://github.com/buacanning (#1985)

(cherry picked from commit 90a7c67)

Author: nikitabobko

Sources/AppBundle/tree/MacWindow.swift

@@ -125,15 +125,17 @@ final class MacWindow: Window {
     @MainActor
     func hideInCorner(_ corner: OptimalHideCorner) async throws {
         guard let nodeMonitor else { return }
-        // Don't accidentally override prevUnhiddenEmulationPosition in case of subsequent
-        // `hideEmulation` calls
+        // Don't accidentally override prevUnhiddenEmulationPosition in case of subsequent `hideInCorner` calls
         if !isHiddenInCorner {
             guard let windowRect = try await getAxRect() else { return }
-            let topLeftCorner = windowRect.topLeftCorner
-            let monitorRect = windowRect.center.monitorApproximation.rect // Similar to layoutFloatingWindow. Non idempotent
-            let absolutePoint = topLeftCorner - monitorRect.topLeftCorner
-            prevUnhiddenProportionalPositionInsideWorkspaceRect =
-                CGPoint(x: absolutePoint.x / monitorRect.width, y: absolutePoint.y / monitorRect.height)
+            // Check for isHiddenInCorner for the second time because of the suspension point above
+            if !isHiddenInCorner {
+                let topLeftCorner = windowRect.topLeftCorner
+                let monitorRect = windowRect.center.monitorApproximation.rect // Similar to layoutFloatingWindow. Non idempotent
+                let absolutePoint = topLeftCorner - monitorRect.topLeftCorner
+                prevUnhiddenProportionalPositionInsideWorkspaceRect =
+                    CGPoint(x: absolutePoint.x / monitorRect.width, y: absolutePoint.y / monitorRect.height)
+            }
         }
         let p: CGPoint
         switch corner {