Skip to content

Commit 2adddea

Browse files
authored
Merge pull request #587 from mlcommons/patch-subgen-ghaction
Add remaining gh actions for cm submission generation
2 parents de29b40 + 78813ff commit 2adddea

1 file changed

Lines changed: 32 additions & 1 deletion

File tree

.github/workflows/test-cm-based-submission-generation.yml

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,29 @@ jobs:
1919
python-version: [ "3.12" ]
2020
division: ["closed", "open", "closed-open"]
2121
category: ["datacenter", "edge"]
22-
case: ["closed", "closed-no-compliance", "closed-power", "closed-failed-power-logs", "case-3", "case-7", "case-8"]
22+
case: ["closed", "closed-no-compliance", "closed-power", "closed-failed-power-logs", "case-1", "case-2", "case-3", "case-5", "case-6", "case-7", "case-8"]
2323
action: ["run", "docker"]
2424
exclude:
2525
- os: macos-latest
2626
- os: windows-latest
2727
- category: "edge"
28+
- case: case-1
29+
division: closed
30+
- case: case-1
31+
division: closed-open
32+
- case: case-2
33+
division: closed
34+
- case: case-2
35+
division: closed-open
36+
- case: case-5
37+
division: closed
38+
- case: case-5
39+
division: closed-open
40+
- case: case-6
41+
division: closed
42+
- case: case-6
43+
division: closed-open
44+
2845
steps:
2946
- uses: actions/checkout@v4
3047
- name: Set up Python ${{ matrix.python-version }}
@@ -39,6 +56,7 @@ jobs:
3956
run: |
4057
git clone -b submission-generation-tests https://github.com/mlcommons/inference.git submission_generation_tests
4158
- name: Run Submission Generation - ${{ matrix.case }} ${{ matrix.action }} ${{ matrix.category }} ${{ matrix.division }}
59+
continue-on-error: true
4260
run: |
4361
if [ "${{ matrix.case }}" == "case-3" ]; then
4462
description="Submission generation (model_mapping.json not present but model name matches with official one)"
@@ -63,5 +81,18 @@ jobs:
6381
# Dynamically set the log group to simulate a dynamic step name
6482
echo "::group::$description"
6583
cm ${{ matrix.action }} script --tags=generate,inference,submission --adr.submission-checker-src.tags=_branch.dev --clean --preprocess_submission=yes --results_dir=$PWD/submission_generation_tests/${{ matrix.case }}/ --run-checker --submitter=MLCommons --tar=yes --env.CM_TAR_OUTFILE=submission.tar.gz --division=${{ matrix.division }} --env.CM_DETERMINE_MEMORY_CONFIGURATION=yes --quiet $extra_run_args
84+
exit_status=$?
85+
echo "Exit status for the job ${description} ${exit_status}"
86+
if [[ "${{ matrix.case }}" == "case-5" || "${{ matrix.case }}" == "case-6" ]]; then
87+
# For cases 5 and 6, exit status should be 0 if cm command fails, 1 if it succeeds
88+
if [[ ${exit_status} -ne 0 ]]; then
89+
exit 0
90+
else
91+
exit ${exit_status}
92+
fi
93+
else
94+
# For other cases, exit with the original status
95+
test ${exit_status} -eq 0 || exit ${exit_status}
96+
fi
6697
echo "::endgroup::"
6798

0 commit comments

Comments
 (0)