fix(admin-cabinet): handle 404s cleanly, plug menu info leak, polish … #189
Annotations
10 errors and 4 warnings
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L257
Expected at least 1 space after "=>"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L257
Expected at least 1 space before "=>"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L246
Expected at least 1 space after "=>"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L246
Expected at least 1 space before "=>"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L241
Expected at least 1 space after ">"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L241
Expected at least 1 space before ">"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L168
Expected at least 1 space after "??"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L168
Expected at least 1 space before "??"; 0 found
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L156
Whitespace found at end of line
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L1
Header blocks must be separated by a single blank line
|
|
PHPStan + phpcs
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
PHPStan + phpcs:
src/AdminCabinet/Library/Elements.php#L307
Property name "$_hiddenInDocker" should not be prefixed with an underscore to indicate visibility
|
|
PHPStan + phpcs:
src/AdminCabinet/Library/Elements.php#L69
Property name "$_headerMenu" should not be prefixed with an underscore to indicate visibility
|
|
PHPStan + phpcs:
src/AdminCabinet/Controllers/BaseController.php#L486
Usage of ELSE IF is discouraged; use ELSEIF instead
|