Skip to content

Commit 922cdc1

Browse files
committed
firefox
1 parent 1ddea96 commit 922cdc1

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

tests/async/test_navigation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ async def test_wait_for_load_state_should_wait_for_load_state_of_empty_url_popup
816816

817817
popup = await popup_info.value
818818
await popup.wait_for_load_state()
819-
assert ready_state == ["uninitialized"] if is_firefox else ["complete"]
819+
assert ready_state == ["complete"]
820820
assert await popup.evaluate("() => document.readyState") == ready_state[0]
821821

822822

tests/async/test_popup.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import asyncio
1616
from typing import List, Optional
1717

18+
import pytest
19+
1820
from playwright.async_api import Browser, BrowserContext, Request, Route
1921
from tests.server import Server
2022
from tests.utils import must
@@ -137,8 +139,10 @@ async def test_should_inherit_http_credentials_from_browser_context(
137139

138140

139141
async def test_should_inherit_touch_support_from_browser_context(
140-
browser: Browser, server: Server
142+
browser: Browser, server: Server, is_firefox: bool, browser_version: str
141143
) -> None:
144+
if is_firefox and int(browser_version.split(".")[0]) >= 148:
145+
pytest.skip("https://bugzilla.mozilla.org/show_bug.cgi?id=2014330")
142146
context = await browser.new_context(
143147
viewport={"width": 400, "height": 500}, has_touch=True
144148
)

0 commit comments

Comments
 (0)