GUI: PyQt6 ffprobe non-blocking; hardened HTTPS; robust Tkinter logging; tests: headless stubs

Author: mauriciomenon

.DS_Store

@@ -0,0 +1,4 @@
+{
+    "Codegeex.Chat.fontSize": 12,
+    "Codegeex.CommitMessageStyle": "ConventionalCommits"
+}

.vscode/settings.json

@@ -12,6 +12,7 @@
 import zipfile
 import shlex
 import tarfile
+import ssl
 from io import BytesIO
 from functools import partial
 from utils_safe_extract import safe_tar_extract, safe_zip_extract
@@ -352,15 +353,16 @@ def _finalize_proc(self):
 
     def _on_proc_finished(self, code, status):
         ok = (code == 0)
-        self._finalize_proc()
+        # Show dialog first, then finalize to avoid brief window where Convert is re-enabled during dialog
         if ok:
             QtWidgets.QMessageBox.information(self, 'Sucesso', 'Vídeo convertido com sucesso!')
         else:
             QtWidgets.QMessageBox.critical(self, 'Erro', f'Falha ao converter vídeo (código {code}).')
+        self._finalize_proc()
 
     def _on_proc_error(self, err):
-        self._finalize_proc()
         QtWidgets.QMessageBox.critical(self, 'Erro', f'Erro de processo: {err}')
+        self._finalize_proc()
 
     def _append_log(self, msg):
         # Efficient append without rewriting whole buffer
@@ -387,13 +389,27 @@ def show_video_info(self):
         if not candidate or not os.path.exists(candidate):
             candidate = ffprobe_name  # rely on PATH
         ffprobe = candidate
+        # Run ffprobe non-blocking using QProcess
         try:
-            command = [ffprobe, '-v', 'quiet', '-print_format', 'json', '-show_streams', '-show_format', inp]
-            p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-            out, err = p.communicate()
-            if p.returncode != 0:
-                raise RuntimeError('ffprobe error')
-            data = json.loads(out)
+            self._info_proc = QtCore.QProcess(self)
+            self._info_proc.setProgram(ffprobe)
+            self._info_proc.setArguments(['-v', 'quiet', '-print_format', 'json', '-show_streams', '-show_format', inp])
+            self._info_proc.setProcessChannelMode(QtCore.QProcess.ProcessChannelMode.MergedChannels)
+            self._info_proc.finished.connect(self._on_info_finished)
+            self._info_proc.errorOccurred.connect(lambda err: QtWidgets.QMessageBox.critical(self, 'Erro', f'Erro ao executar ffprobe: {err}'))
+            self._info_proc.start()
+        except FileNotFoundError:
+            QtWidgets.QMessageBox.critical(self, 'Erro', 'ffprobe não encontrado (verifique PATH ou caminho configurado).')
+        except Exception as e:
+            QtWidgets.QMessageBox.critical(self, 'Erro', f'Falha ao iniciar ffprobe: {e}')
+
+    def _on_info_finished(self, code, status):
+        try:
+            out = bytes(self._info_proc.readAllStandardOutput()).decode('utf-8', errors='ignore') if hasattr(self, '_info_proc') else ''
+            if code != 0:
+                QtWidgets.QMessageBox.critical(self, 'Erro', f'ffprobe falhou (código {code}).')
+                return
+            data = json.loads(out or '{}')
             info_text = json.dumps(data, indent=2, ensure_ascii=False)
             dlg = QtWidgets.QDialog(self)
             dlg.setWindowTitle('Informações detalhadas do vídeo')
@@ -404,10 +420,12 @@ def show_video_info(self):
             v.addWidget(b)
             dlg.setLayout(v)
             dlg.exec()
-        except FileNotFoundError:
-            QtWidgets.QMessageBox.critical(self, 'Erro', 'ffprobe não encontrado (verifique PATH ou caminho configurado).')
-        except Exception as e:
-            QtWidgets.QMessageBox.critical(self, 'Erro', f'Falha ao obter info: {e}')
+        finally:
+            try:
+                self._info_proc.deleteLater()
+            except Exception:
+                pass
+            self._info_proc = None
 
     def on_no_audio_change(self):
         disabled = self.no_audio_chk.isChecked()
@@ -422,13 +440,16 @@ def _http_get(self, url: str, timeout: int = 60) -> bytes:
         """Download URL returning raw bytes. Tries requests first, then urllib as fallback."""
         try:
             import requests  # type: ignore
-            resp = requests.get(url, timeout=timeout)
+            resp = requests.get(url, timeout=timeout, verify=True)
             resp.raise_for_status()
             return resp.content
         except Exception:
             # Fallback to urllib
             import urllib.request
-            with urllib.request.urlopen(url, timeout=timeout) as resp:  # nosec B310
+            ctx = ssl.create_default_context()
+            ctx.check_hostname = True
+            ctx.verify_mode = ssl.CERT_REQUIRED
+            with urllib.request.urlopen(url, timeout=timeout, context=ctx) as resp:  # nosec B310
                 if resp.status != 200:
                     raise RuntimeError(f"HTTP {resp.status}")
                 return resp.read()

GUI_pyqt6_WINFF.py

@@ -17,6 +17,7 @@
 import tkinter as tk
 from tkinter import ttk, filedialog, messagebox
 from utils_safe_extract import safe_tar_extract, safe_zip_extract
+import ssl
 
 import importlib
 try:
@@ -295,7 +296,10 @@ def _append_log(self, text: str):
 	def _reader_worker(self):
 		try:
 			assert self._proc is not None
-			for line in self._proc.stdout:
+			while True:
+				line = self._proc.stdout.readline()
+				if not line:
+					break
 				self._log_q.put(line.rstrip())
 		except Exception as e:
 			self._log_q.put(f"[erro leitor]: {e}")
@@ -307,12 +311,13 @@ def _poll_logs(self):
 				self._append_log(line)
 		except queue.Empty:
 			pass
-		# if process still alive, reschedule; else finalize
-		if self._proc is not None and self._proc.poll() is None:
+		alive = (self._proc is not None and self._proc.poll() is None)
+		if alive and self._reader_thread is not None and self._reader_thread.is_alive():
 			self.after(200, self._poll_logs)
 		else:
 			code = None if self._proc is None else self._proc.returncode
 			self._proc = None
+			self._reader_thread = None
 			self.convert_btn.configure(state='normal')
 			self.cancel_btn.configure(state='disabled')
 			if code == 0:
@@ -418,13 +423,16 @@ def _http_get(self, url: str, timeout: int = 60) -> bytes:
 		"""Download com requests (se disponível) e fallback para urllib."""
 		if requests is not None:
 			try:
-				r = requests.get(url, timeout=timeout)
+				r = requests.get(url, timeout=timeout, verify=True)
 				r.raise_for_status()
 				return r.content
 			except Exception:
 				pass
 		import urllib.request
-		with urllib.request.urlopen(url, timeout=timeout) as resp:  # nosec B310
+		ctx = ssl.create_default_context()
+		ctx.check_hostname = True
+		ctx.verify_mode = ssl.CERT_REQUIRED
+		with urllib.request.urlopen(url, timeout=timeout, context=ctx) as resp:  # nosec B310
 			return resp.read()
 
 	def download_ffmpeg_and_maybe_install(self):

GUI_tkinter_WINFF.py

@@ -1,7 +1,53 @@
 from importlib import import_module
+import sys
+import types
+
+
+def _stub_pyqt6():
+    if 'PyQt6' in sys.modules:
+        return
+    qt = types.ModuleType('PyQt6')
+    qtwidgets = types.ModuleType('PyQt6.QtWidgets')
+    qtcore = types.ModuleType('PyQt6.QtCore')
+    # Provide dummy classes used in import statements
+    for name in [
+        'QApplication','QWidget','QLabel','QLineEdit','QPushButton','QTextEdit',
+        'QComboBox','QFileDialog','QCheckBox','QHBoxLayout','QVBoxLayout','QProgressDialog'
+    ]:
+        setattr(qtwidgets, name, type(name, (), {}))
+    # Minimal decorator used in the module (@QtCore.pyqtSlot)
+    qtcore.pyqtSlot = lambda *args, **kwargs: (lambda f: f)
+    qt.QtWidgets = qtwidgets
+    qt.QtCore = qtcore
+    sys.modules['PyQt6'] = qt
+    sys.modules['PyQt6.QtWidgets'] = qtwidgets
+    sys.modules['PyQt6.QtCore'] = qtcore
+
+
+def _stub_tkinter():
+    if 'tkinter' in sys.modules:
+        return
+    tk = types.ModuleType('tkinter')
+    # Minimal Tk class to support class definition inheritance
+    tk.Tk = type('Tk', (), {})
+    ttk = types.ModuleType('ttk')
+    filedialog = types.ModuleType('filedialog')
+    messagebox = types.ModuleType('messagebox')
+    # Expose submodules as attributes to support `from tkinter import ...`
+    tk.ttk = ttk
+    tk.filedialog = filedialog
+    tk.messagebox = messagebox
+    # Mark as a package to be safe
+    tk.__path__ = []  # type: ignore[attr-defined]
+    sys.modules['tkinter'] = tk
+    sys.modules['ttk'] = ttk
+    sys.modules['tkinter.ttk'] = ttk
+    sys.modules['tkinter.filedialog'] = filedialog
+    sys.modules['tkinter.messagebox'] = messagebox
 
 
 def test_pyqt6_build_command_list_defaults(monkeypatch):
+    _stub_pyqt6()
     # Avoid importing PyQt6 in CI to keep tests light.
     # Instead, test the command assembly logic by stubbing the minimal API.
     m = import_module('GUI_pyqt6_WINFF')
@@ -32,6 +78,7 @@ def __init__(self):
 
 
 def test_tkinter_build_command_list_defaults(monkeypatch):
+    _stub_tkinter()
     m = import_module('GUI_tkinter_WINFF')
 
     class Stub: