CI hardening: manual-only release; light test env and stable imports

- release.yml now manual-only (workflow_dispatch)
- ci.yml installs only pytest and sets PYTHONPATH; avoids heavy GUI deps
- tests: avoid importing GUI frameworks; stub minimal API to test command build

Author: mauriciomenon

.github/workflows/ci.yml

@@ -17,7 +17,6 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          python -m pip install -r requirements.txt
           python -m pip install pytest
       - name: Enforce max file size
         run: |
@@ -33,5 +32,6 @@ jobs:
       - name: Run tests
         env:
           QT_QPA_PLATFORM: offscreen
+          PYTHONPATH: ${{ github.workspace }}
         run: |
           pytest -q

.github/workflows/release.yml

@@ -1,10 +1,8 @@
 name: release
 
 on:
-  # Release builds run on tag pushes only; tag creation is a deliberate action.
-  push:
-    tags:
-      - 'v*'
+  # Manual only to fully block automatic release builds
+  workflow_dispatch: {}
 
 permissions:
   contents: write

tests/test_command_build.py

@@ -1,35 +1,61 @@
-import os
-import shlex
-import types
-
-# We'll import the GUI modules and call their build_command_list through a minimal shim.
+from importlib import import_module
 
 
 def test_pyqt6_build_command_list_defaults(monkeypatch):
-    import GUI_pyqt6_WINFF as m
-
-    w = m.FFmpegGuiPyQt6()
-    # simulate basic defaults
-    w.input_edit.setText('/tmp/in.mp4')
-    w.same_dir_chk.setChecked(True)
-    w.set_default_options()
-
-    args = w.build_command_list()
+    # Avoid importing PyQt6 in CI to keep tests light.
+    # Instead, test the command assembly logic by stubbing the minimal API.
+    m = import_module('GUI_pyqt6_WINFF')
+
+    class Stub:
+        # only the attributes used inside build_command_list
+        def __init__(self):
+            self.input_edit = type('E', (), {'text': lambda self: '/tmp/in.mp4'})()
+            self.format_combo = type('C', (), {'currentText': lambda self: 'wmv'})()
+            self.video_bitrate = type('E', (), {'text': lambda self: '204800'})()
+            self.audio_bitrate = type('E', (), {'text': lambda self: '65536'})()
+            self.resolution_combo = type('C', (), {'currentText': lambda self: 'original'})()
+            self.video_codec_combo = type('C', (), {'currentText': lambda self: 'wmv2'})()
+            self.audio_codec_combo = type('C', (), {'currentText': lambda self: 'wmav2'})()
+            self.frame_rate = type('E', (), {'text': lambda self: '20'})()
+            self.audio_sample_rate = type('E', (), {'text': lambda self: '22050'})()
+            self.audio_channels = type('C', (), {'currentText': lambda self: '1'})()
+            self.ffmpeg_path = type('E', (), {'text': lambda self: 'ffmpeg'})()
+            self.same_dir_chk = type('C', (), {'isChecked': lambda self: True})()
+            self.output_edit = type('E', (), {'text': lambda self: ''})()
+            self.no_audio_chk = type('C', (), {'isChecked': lambda self: False})()
+
+    w = Stub()
+    args = m.FFmpegGuiPyQt6.build_command_list(w)
     assert args[0] == 'ffmpeg'
     assert '-i' in args and '/tmp/in.mp4' in args
-    # ensure no -s when resolution is original
-    assert '-s' not in args
+    assert '-s' not in args  # resolution original means no -s
 
 
 def test_tkinter_build_command_list_defaults(monkeypatch):
-    import GUI_tkinter_WINFF as m
-
-    app = m.FFmpegGuiTk()
-    app.input_var.set('/tmp/in.mp4')
-    app.same_dir_var.set(True)
-    app.set_default_options()
-
-    args = app.build_command_list()
+    m = import_module('GUI_tkinter_WINFF')
+
+    class Stub:
+        def __init__(self):
+            self.input_var = type('V', (), {'get': lambda self: '/tmp/in.mp4', 'set': lambda self, x: None})()
+            self.format_var = type('V', (), {'get': lambda self: 'wmv'})()
+            self.vbitrate_var = type('V', (), {'get': lambda self: '204800'})()
+            self.abitrate_var = type('V', (), {'get': lambda self: '65536'})()
+            self.resolution_var = type('V', (), {'get': lambda self: 'original'})()
+            self.vcodec_var = type('V', (), {'get': lambda self: 'wmv2'})()
+            self.acodec_var = type('V', (), {'get': lambda self: 'wmav2'})()
+            self.fps_var = type('V', (), {'get': lambda self: '20'})()
+            self.asamplerate_var = type('V', (), {'get': lambda self: '22050'})()
+            self.achannels_var = type('V', (), {'get': lambda self: '1'})()
+            self.ffmpeg_path_var = type('V', (), {'get': lambda self: 'ffmpeg'})()
+            self.same_dir_var = type('V', (), {'get': lambda self: True})()
+            self.output_dir_var = type('V', (), {'get': lambda self: ''})()
+            self.no_audio_var = type('V', (), {'get': lambda self: False})()
+
+        def _resolve_output_dir(self, inp: str) -> str:
+            return '/tmp'
+
+    app = Stub()
+    args = m.FFmpegGuiTk.build_command_list(app)
     assert args[0] == 'ffmpeg'
     assert '-i' in args and '/tmp/in.mp4' in args
     assert '-s' not in args