load favicons from browser (chrome-based browsers) or DuckDuckGo API (Firefox)

Author: mathio

README.md

@@ -54,13 +54,15 @@ Manually:
 - there are NO settings, deal with it
 - just displays your bookmarks in multiple columns for quick access from the new tab page
 - organize your bookmarks in folders under Bookmarks Bar to display in columns (or don't)
-- displays favicons for your bookmarks (via Google API)
+- displays favicons for your bookmarks
 - displays small "show" / "hide" toggle in bottom right corner to hide all your bookmarks (for when you are sharing your screen or someone is looking over your shoulder)
 - when you hide bookmarks [a random photo](https://unsplash.com/documentation#get-a-random-photo) from [wallpaper topic on Unsplash](https://unsplash.com/t/wallpapers?utm_source=chrome-new-tab-page-bookmarks&utm_medium=referral) is displayed once every 15 minutes
 
 ## Privacy and permission justification
 
-Extension requires [permissions to access your bookmarks](https://developer.chrome.com/docs/extensions/reference/bookmarks/) to display them on the new tab page. Your bookmarks do not leave your device. It loads favicons via Google API ([using t2.gstatic.com/faviconV2 like this](https://t2.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=http://github.com&size=16)) and might disclose domains & subdomains (not full URLs) from your bookmarks to Google.
+Extension requires [permissions to access your bookmarks](https://developer.chrome.com/docs/extensions/reference/bookmarks/) to display them on the new tab page. Your bookmarks do not leave your device.
+
+In Chrome-based browsers it retrieves [favicons](https://developer.chrome.com/docs/extensions/how-to/ui/favicons) directly from browser. In Firefox it loads favicons via DuckDuckGO API ([they don’t track you, ever](https://duckduckgo.com/duckduckgo-help-pages/privacy/favicons)).
 
 Wallpaper images from Unsplash API are loaded via proxy. All requests are anonymous and rate-limited via IP address hash. Image is loaded directly from Unsplash CDN and is [tracked by Unsplash](https://unsplash.com/documentation#hotlinking).
 

chrome/src/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "New Tab Page Bookmarks",
   "description": "Displays your bookmarks in multiple columns for quick access from the new tab page",
-  "version": "1.9",
+  "version": "1.10",
   "manifest_version": 3,
   "author": "https://github.com/mathio",
   "chrome_url_overrides": {
@@ -13,5 +13,5 @@
     "48": "icon48.png",
     "128": "icon128.png"
   },
-  "permissions": ["bookmarks"]
+  "permissions": ["bookmarks", "favicon"]
 }

firefox/src/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "New Tab Page Bookmarks",
   "description": "Displays your bookmarks in multiple columns for quick access from the new tab page",
-  "version": "1.9",
+  "version": "1.10",
   "manifest_version": 2,
   "author": "https://github.com/mathio",
   "chrome_url_overrides": {

src/index.js

@@ -1,8 +1,20 @@
 import { decodeBlurHash } from './fast-blurhash.js'
 
-const iconUrl = (href) => {
-  const { origin } = new URL(href)
-  return `https://t2.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=${origin}&size=32`
+const isFirefox = typeof browser !== 'undefined'
+
+export const DEFAULT_ICON_SVG = `data:image/svg+xml,${encodeURIComponent(
+  '<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="gray" viewBox="0 0 16 16"><path d="M0 8a8 8 0 1 1 16 0A8 8 0 0 1 0 8m7.5-6.923c-.67.204-1.335.82-1.887 1.855A8 8 0 0 0 5.145 4H7.5zM4.09 4a9.3 9.3 0 0 1 .64-1.539 7 7 0 0 1 .597-.933A7.03 7.03 0 0 0 2.255 4zm-.582 3.5c.03-.877.138-1.718.312-2.5H1.674a7 7 0 0 0-.656 2.5zM4.847 5a12.5 12.5 0 0 0-.338 2.5H7.5V5zM8.5 5v2.5h2.99a12.5 12.5 0 0 0-.337-2.5zM4.51 8.5a12.5 12.5 0 0 0 .337 2.5H7.5V8.5zm3.99 0V11h2.653c.187-.765.306-1.608.338-2.5zM5.145 12q.208.58.468 1.068c.552 1.035 1.218 1.65 1.887 1.855V12zm.182 2.472a7 7 0 0 1-.597-.933A9.3 9.3 0 0 1 4.09 12H2.255a7 7 0 0 0 3.072 2.472M3.82 11a13.7 13.7 0 0 1-.312-2.5h-2.49c.062.89.291 1.733.656 2.5zm6.853 3.472A7 7 0 0 0 13.745 12H11.91a9.3 9.3 0 0 1-.64 1.539 7 7 0 0 1-.597.933M8.5 12v2.923c.67-.204 1.335-.82 1.887-1.855q.26-.487.468-1.068zm3.68-1h2.146c.365-.767.594-1.61.656-2.5h-2.49a13.7 13.7 0 0 1-.312 2.5m2.802-3.5a7 7 0 0 0-.656-2.5H12.18c.174.782.282 1.623.312 2.5zM11.27 2.461c.247.464.462.98.64 1.539h1.835a7 7 0 0 0-3.072-2.472c.218.284.418.598.597.933M10.855 4a8 8 0 0 0-.468-1.068C9.835 1.897 9.17 1.282 8.5 1.077V4z"/></svg>'
+)}`
+
+const getFavicon = (pageUrl) => {
+  if (isFirefox) {
+    const { hostname } = new URL(pageUrl)
+    return `https://icons.duckduckgo.com/ip3/${hostname}.ico`
+  }
+  const url = new URL(chrome.runtime.getURL('/_favicon/'))
+  url.searchParams.set('pageUrl', pageUrl)
+  url.searchParams.set('size', '32')
+  return url.toString()
 }
 
 const addElm = (parent, tag, text, attributes) => {
@@ -21,13 +33,13 @@ const addElm = (parent, tag, text, attributes) => {
 
 const renderNode =
   (root) =>
-  ({ title, children, url: href }) => {
+  async ({ title, children, url: href }) => {
     const li = addElm(root, 'li')
 
     if (children) {
       addElm(li, 'h3', title)
       const ul = addElm(li, 'ul')
-      children.forEach(renderNode(ul))
+      await Promise.all(children.map(renderNode(ul)))
     } else if (href) {
       const parentUl = li.closest('ul')
       if (parentUl?.id === 'root') {
@@ -38,14 +50,18 @@ const renderNode =
       link.href = href
 
       const icon = document.createElement('img')
-      icon.src = iconUrl(href)
       icon.alt = title.substring(0, 1)
       link.append(icon)
 
       const text = document.createTextNode(` ${title}`)
       link.append(text)
 
       li.append(link)
+
+      icon.src = getFavicon(href)
+      icon.onerror = () => {
+        icon.src = DEFAULT_ICON_SVG
+      }
     }
   }
 
@@ -60,17 +76,15 @@ const renderBookmarksBar = async () => {
   }
 
   //
-  rootNode.children
-    .filter(
-      (item) =>
-        item.folderType === 'bookmarks-bar' || // chrome: find using folderType, there can be more than one (https://developer.chrome.com/blog/bookmarks-sync-changes)
-        item.id === 'toolbar_____' // firefox: find using ID
-    )
-    .forEach((bar) => {
-      bar.children.forEach(renderNode(domRoot))
-    })
+  const bars = rootNode.children.filter(
+    (item) =>
+      item.folderType === 'bookmarks-bar' || // chrome: find using folderType, there can be more than one (https://developer.chrome.com/blog/bookmarks-sync-changes)
+      item.id === 'toolbar_____' // firefox: find using ID
+  )
 
-  console.log(rootNode)
+  for (const bar of bars) {
+    await Promise.all(bar.children.map(renderNode(domRoot)))
+  }
 }
 
 const TOGGLE_KEY_NAME = 'hideBookmarksBar'