Skip to content

Commit 958f54a

Browse files
martincostellomartincostello
authored
Upgrade Microsoft.Data.SqlClient (#1181)
- Upgrade Microsoft.Data.SqlClient to 6.0.2. - Drop `netstandard2.0` and `net6.0` targets. - Add `net462` target. - Mark `net8.0` target as native AoT compatible. - Bump version to 4.0.0. - Review all the documentation and update/modernise as-appropriate.
1 parent a3c3a03 commit 958f54a

22 files changed

Lines changed: 232 additions & 134 deletions

‎.github/CONTRIBUTING.md‎

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,20 @@
1-
# Contributing Guide
1+
# Contributing
22

3-
To contribute changes (source code, scripts, configuration) to this repository please follow the steps below. These steps are a guideline for contributing and do not necessarily need to be followed for all changes.
3+
To contribute changes (source code, scripts, configuration) to this repository please follow the steps below.
4+
These steps are a guideline for contributing and do not necessarily need to be followed for all changes.
45

5-
1. If you intend to fix a bug please create an issue before forking the repository.
6-
1. Fork the `main` branch of this repository from the latest commit.
7-
1. Create a branch from your fork's `main` branch to help isolate your changes from any further work on `main`. If fixing an issue try to reference its name in your branch name (e.g. `issue-123`) to make changes easier to track the changes.
8-
1. Work on your proposed changes on your fork. If you are fixing an issue include at least one unit test that reproduces it if the code changes to fix it have not been applied; if you are adding new functionality please include unit tests appropriate to the changes you are making. The [code coverage figure](https://codecov.io/gh/martincostello/sqllocaldb) should be maintained where possible.
9-
1. When you think your changes are complete, test that the code builds cleanly using `build.ps1`. There should be no compiler warnings and all tests should pass.
10-
1. Once your changes build cleanly locally submit a Pull Request back to the `main` branch from your fork's branch. Ideally commits to your branch should be squashed before creating the Pull Request. If the Pull Request fixes an issue please reference it in the title and/or description. Please keep changes focused around a specific topic rather than include multiple types of changes in a single Pull Request.
11-
1. After your Pull Request is created it will build against the repository's continuous integrations.
12-
1. Once the Pull Request has been reviewed by the project's [contributors](https://github.com/martincostello/sqllocaldb/graphs/contributors) and the status checks pass your Pull Request will be merged back to the `main` branch, assuming that the changes are deemed appropriate.
6+
1. If you intend to fix a bug please create an issue before forking the repository.
7+
1. Fork the `main` branch of this repository from the latest commit.
8+
1. Create a branch from your fork's `main` branch to help isolate your changes from any further work on `main`.
9+
If fixing an issue try to reference its name in your branch name (e.g. `issue-123`) to make changes easier to track the changes.
10+
1. Work on your proposed changes on your fork. If you are fixing an issue include at least one unit test that reproduces it if the
11+
code changes to fix it have not been applied; if you are adding new functionality please include unit tests appropriate to the changes you are making.
12+
1. When you think your changes are complete, test that the code builds cleanly using `build.ps1`. There should be no compiler warnings and all tests should pass.
13+
1. Once your changes build cleanly locally submit a Pull Request back to the `main` branch from your fork's branch.
14+
Ideally commits to your branch should be squashed before creating the Pull Request. If the Pull Request fixes an issue please reference
15+
it in the title and/or description. Please keep changes focused around a specific topic rather than include multiple types of changes in a single Pull Request.
16+
1. After your Pull Request is created it will build against the repository's continuous integrations.
17+
1. Once the Pull Request has been reviewed by the project's [contributors][contributors] and the status checks pass your Pull Request
18+
will be merged back to the `main` branch, assuming that the changes are deemed appropriate.
19+
20+
[contributors]: https://github.com/martincostello/sqllocaldb/graphs/contributors

‎.github/ISSUE_TEMPLATE.md‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
# Issue
1+
---
2+
title: '[bug] :'
3+
---
24

3-
## Expected behaviour
5+
### Expected behaviour
46

57
<!-- Explain what you expected to happen. -->
68

7-
## Actual behaviour
9+
### Actual behaviour
810

911
<!-- Explain what actually happened. If an exception occurred, please include a stack trace if available. -->
1012

11-
## Steps to reproduce
13+
### Steps to reproduce
1214

1315
<!-- A concise, repeatable, example of how to illustrate the issue. -->

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 32 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,51 @@
11
---
22
name: Bug report
33
about: Create a bug report to help us improve the library
4-
title: ''
4+
title: '[bug] '
55
labels: bug
6-
assignees: ''
76
---
87

9-
<!--
10-
This is a template. Feel free to delete any sections that are not relevant.
11-
-->
12-
13-
## Describe the bug
8+
### Describe the bug
149

15-
<!-- A clear and concise description of what the bug is. -->
10+
<!--
11+
A clear and concise description of what the bug is.
12+
-->
1613

17-
## Steps To reproduce
14+
### Steps To reproduce
1815

19-
<!-- A concise, repeatable, example of how to reproduce the issue. -->
16+
<!--
17+
A concise, repeatable, example of how to reproduce the issue.
18+
-->
2019

21-
## Expected behaviour
20+
### Expected behaviour
2221

23-
<!-- A clear and concise description of what you expected to happen. -->
22+
<!--
23+
A clear and concise description of what you expected to happen.
24+
-->
2425

25-
## Actual behaviour
26+
### Actual behaviour
2627

27-
<!-- A clear and concise description of what actually happened. If an exception occurred, please include a stack trace if available. -->
28+
<!--
29+
A clear and concise description of what actually happened. If an exception occurred, please include a stack trace if available.
30+
-->
2831

29-
## Screenshots
32+
### Screenshots
3033

31-
<!-- If applicable, add screenshots to help explain your problem. -->
34+
<!--
35+
If applicable, add screenshots to help explain your problem.
36+
-->
3237

33-
## System information
38+
### System information
3439

35-
- OS: [e.g. Windows 11]
36-
- Library Version [e.g. 3.4.0]
37-
- SQL LocalDB version [e.g. 13.0]
38-
- .NET version (e.g. output from `dotnet --info`)
40+
<!--
41+
- OS: [e.g. Windows 11]
42+
- Library Version [e.g. 4.0.0]
43+
- SQL LocalDB version [e.g. Microsoft SQL Server 2019 (15.0.4382.1)]
44+
- .NET version (e.g. output from `dotnet --info`)
45+
-->
3946

40-
## Additional context
47+
### Additional context
4148

42-
<!-- Add any other context about the problem here. -->
49+
<!--
50+
Add any other context about the problem here.
51+
-->

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: true
2+
contact_links:
3+
- name: Contact me
4+
url: https://martincostello.com/bluesky
5+
about: You can also contact me on Bluesky.

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,30 @@
11
---
22
name: Feature request
33
about: Suggest an idea for a feature of this library
4-
title: ''
4+
title: '[feature] '
55
labels: question
6-
assignees: ''
76
---
87

9-
<!--
10-
This is a template. Feel free to delete any sections that are not relevant.
11-
-->
12-
13-
## Is your feature request related to a problem?
8+
### Is your feature request related to a problem?
149

15-
<!-- A clear and concise description of what the problem is. For example: _I'm always frustrated when [...]_ -->
10+
<!--
11+
A clear and concise description of what the problem is. For example: _It would be useful if [...]_
12+
-->
1613

17-
## Describe the solution you'd like
14+
### Describe the solution you'd like
1815

19-
<!-- A clear and concise description of what you want to happen. -->
16+
<!--
17+
A clear and concise description of what you would like to happen.
18+
-->
2019

21-
## Describe alternatives you've considered
20+
### Describe alternatives you've considered
2221

23-
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
22+
<!--
23+
A clear and concise description of any alternative solutions or features you've considered.
24+
-->
2425

25-
## Additional context
26+
### Additional context
2627

27-
<!-- Add any other context or screenshots about the feature request here. -->
28+
<!--
29+
Add any other context or screenshots about the feature request here.
30+
-->

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
<!-- Summarise the changes this Pull Request makes. -->
1+
<!--
22
3-
<!-- Please include a reference to a GitHub issue if appropriate. -->
3+
Summarise the changes this Pull Request makes.
4+
5+
Please include a reference to a GitHub issue if appropriate.
6+
7+
-->

‎.github/dependabot.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@ updates:
2323
open-pull-requests-limit: 99
2424
ignore:
2525
- dependency-name: "Microsoft.Extensions.DependencyInjection.Abstractions"
26-
- dependency-name: "Microsoft.Win32.Registry"

‎CHANGELOG.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,3 +248,13 @@ Added overloads to support specifying the name of the Initial Catalog using the
248248
`netstandard2.0`/`net6.0` and `5.1.5` for `net8.0` to include fixes for
249249
[CVE-2024-0056](https://github.com/advisories/GHSA-98g6-xh36-x2p7).
250250
* Use interop methods that are compatible with .NET native AoT.
251+
252+
## SqlLocalDb v4.0.0
253+
254+
### Changes
255+
256+
* Update Microsoft.Data.SqlClient dependency to
257+
[6.0.2](https://github.com/dotnet/SqlClient/releases/tag/v6.0.2).
258+
* Drop support for `netstandard2.0` and `net6.0`.
259+
* Add support for `net462`.
260+
* Set `IsAotCompatible=true` for `net8.0`.

‎CODE_OF_CONDUCT.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
5555
## Enforcement
5656

5757
Instances of abusive, harassing, or otherwise unacceptable behavior may be
58-
reported by contacting the project team [through a GitHub issue](https://github.com/martincostello/sqllocaldb/issues). All
58+
reported by contacting the project team [through a GitHub issue][issues]. All
5959
complaints will be reviewed and investigated and will result in a response that
6060
is deemed necessary and appropriate to the circumstances. The project team is
6161
obligated to maintain confidentiality with regard to the reporter of an incident.
@@ -71,4 +71,5 @@ This Code of Conduct is adapted from the [Contributor Covenant][homepage], versi
7171
available at [https://contributor-covenant.org/version/1/4][version]
7272

7373
[homepage]: https://contributor-covenant.org
74+
[issues]: https://github.com/martincostello/sqllocaldb/issues
7475
[version]: https://contributor-covenant.org/version/1/4/

‎Directory.Build.props‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<UseArtifactsOutput>true</UseArtifactsOutput>
1616
<UseDefaultAssemblyOriginatorKeyFile>true</UseDefaultAssemblyOriginatorKeyFile>
1717
<PackageValidationBaselineVersion>3.4.0</PackageValidationBaselineVersion>
18-
<VersionPrefix>3.4.1</VersionPrefix>
18+
<VersionPrefix>4.0.0</VersionPrefix>
1919
</PropertyGroup>
2020
<PropertyGroup Condition=" '$(EnableReferenceTrimmer)' != 'false' and '$(GenerateDocumentationFile)' != 'true' ">
2121
<GenerateDocumentationFile>true</GenerateDocumentationFile>

0 commit comments

Comments
 (0)