fix: pr comments

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>

Author: gaspergrom

services/libs/tinybird/pipes/repo_health_score_active_contributors.pipe

@@ -12,7 +12,7 @@ NODE repo_health_score_active_contributors_score
 SQL >
     %
     {% if defined(repoUrl) %}
-        SELECT channel, COALESCE(uniq(memberId), 0) AS activeContributors
+        SELECT channel, uniq(memberId) AS activeContributors
         FROM activityRelations_deduplicated_cleaned_bucket_union
         WHERE
             memberId != ''
@@ -29,7 +29,7 @@ SQL >
             {% end %}
         GROUP BY channel
     {% else %}
-        SELECT channel, COALESCE(uniq(memberId), 0) AS activeContributors
+        SELECT channel, uniq(memberId) AS activeContributors
         FROM activityRelations_deduplicated_cleaned_bucket_union
         WHERE
             memberId != ''

services/libs/tinybird/pipes/repo_health_score_copy.pipe

@@ -40,7 +40,7 @@ SQL >
         COALESCE(
             owh.contributionsOutsideWorkHoursBenchmark, 0
         ) AS contributionsOutsideWorkHoursBenchmark,
-        COALESCE(sec.securityPercentage, 0) AS securityPercentage
+        sec.securityPercentage AS securityPercentage
     FROM repo_health_score_copy_repos AS repos
     LEFT JOIN repo_health_score_active_contributors AS ac USING (channel)
     LEFT JOIN repo_health_score_contributor_dependency AS cd USING (channel)
@@ -124,8 +124,13 @@ SQL >
             / if(length(developmentBenchmarks) = 0, 1, 5 * length(developmentBenchmarks))
         ) AS developmentPercentage,
         round(
-            (contributorPercentage + popularityPercentage + developmentPercentage + securityPercentage)
-            / 4
+            (
+                contributorPercentage
+                + popularityPercentage
+                + developmentPercentage
+                + if(isNotNull(securityPercentage), securityPercentage, 0)
+            )
+            / if(isNotNull(securityPercentage), 4, 3)
         ) AS overallScore
     FROM repo_health_score_copy_data
 

services/libs/tinybird/pipes/repo_health_score_security.pipe

@@ -33,7 +33,7 @@ SQL >
         sum(failedAssessments) AS failed,
         sum(passedAssessments) AS passed,
         sum(failedAssessments + passedAssessments) AS total,
-        round(100 * (passed / total)) AS percentage
+        if(total = 0, 0, round(100 * (passed / total))) AS percentage
     FROM repo_health_score_security_check_pass_rate
     WHERE repo != ''
     GROUP BY repo, category