fix: memberTags usage in leftover operations (#3438)

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>

Author: joanagmaia

services/libs/data-access-layer/src/old/apps/automations_worker/data.repo.ts

@@ -240,20 +240,6 @@ export class DataRepository extends RepositoryBase<DataRepository> {
         )
       }
 
-      // load tags
-      promises.push(
-        this.getMemberTags(memberIds).then((tags) => {
-          for (const member of results) {
-            member.tags = tags
-              .filter((t) => t.memberId === member.id)
-              .map((t) => {
-                delete t.memberId
-                return t
-              })
-          }
-        }),
-      )
-
       // load no merge
       promises.push(
         this.getMemberNoMerge(memberIds).then((noMerges) => {
@@ -388,23 +374,6 @@ export class DataRepository extends RepositoryBase<DataRepository> {
     return results
   }
 
-  async getMemberTags(memberIds: string[]): Promise<any[]> {
-    const results = await this.db().any(
-      `
-      select mt."memberId", t.*
-      from "memberTags" mt
-              inner join tags t on t.id = mt."tagId"
-      where mt."memberId" in ($(memberIds:csv))
-        and t."deletedAt" is null;
-      `,
-      {
-        memberIds,
-      },
-    )
-
-    return results
-  }
-
   async getMemberIdentities(memberIds: string[]): Promise<IMemberIdentity[]> {
     const results = await this.db().any(
       `

services/libs/data-access-layer/src/old/apps/integration_sync_worker/member.repo.ts

@@ -79,19 +79,6 @@ export class MemberRepository extends RepositoryBase<MemberRepository> {
                               where mnm."memberId" = $(id)
                                 and m2."deletedAt" is null
                               group by mnm."memberId"),
-            member_tags as (select mt."memberId",
-                                    json_agg(
-                                            json_build_object(
-                                                    'id', t.id,
-                                                    'name', t.name
-                                                )
-                                        )           as all_tags,
-                                    jsonb_agg(t.id) as all_ids
-                            from "memberTags" mt
-                                      inner join tags t on mt."tagId" = t.id
-                            where mt."memberId" = $(id)
-                              and t."deletedAt" is null
-                            group by mt."memberId"),
             member_organizations as (select mo."memberId",
                                             os."segmentId",
                                             json_agg(
@@ -157,7 +144,6 @@ export class MemberRepository extends RepositoryBase<MemberRepository> {
 
               i.identities,
               coalesce(mo.all_organizations, json_build_array()) as organizations,
-              coalesce(mt.all_tags, json_build_array())          as tags,
               coalesce(tmd.to_merge_ids, array []::text[])       as "toMergeIds",
               coalesce(nmd.no_merge_ids, array []::text[])       as "noMergeIds"
         from "memberSegments" ms
@@ -166,7 +152,6 @@ export class MemberRepository extends RepositoryBase<MemberRepository> {
                 inner join activity_data ad on ms."memberId" = ad."memberId" and ms."segmentId" = ad."segmentId"
                 left join to_merge_data tmd on m.id = tmd."memberId"
                 left join no_merge_data nmd on m.id = nmd."memberId"
-                left join member_tags mt on ms."memberId" = mt."memberId"
                 left join member_organizations mo on ms."memberId" = mo."memberId" and ms."segmentId" = mo."segmentId"
         where ms."memberId" = $(id)
           and m."deletedAt" is null;`,

services/libs/data-access-layer/src/old/apps/script_executor_worker/member.repo.ts

@@ -208,7 +208,6 @@ class MemberRepository {
       { name: 'memberSegmentAffiliations', conditions: ['memberId'] },
       { name: 'memberSegmentsAgg', conditions: ['memberId'] },
       { name: 'memberSegments', conditions: ['memberId'] },
-      { name: 'memberTags', conditions: ['memberId'] },
       { name: 'memberToMerge', conditions: ['memberId', 'toMergeId'] },
       { name: 'memberToMergeRaw', conditions: ['memberId', 'toMergeId'] },
       { name: 'members', conditions: ['id'] },

services/libs/opensearch/src/repo/member.repo.ts

@@ -105,20 +105,6 @@ export class MemberRepository extends RepositoryBase<MemberRepository> {
         where mnm."memberId" = $(memberId)
         and m2."deletedAt" is null
         group by mnm."memberId"),
-  member_tags as (
-        select mt."memberId",
-        json_agg(
-              json_build_object(
-                      'id', t.id,
-                      'name', t.name
-                  )
-        )           as all_tags,
-      jsonb_agg(t.id) as all_ids
-      from "memberTags" mt
-        inner join tags t on mt."tagId" = t.id
-      where mt."memberId" = $(memberId)
-      and t."deletedAt" is null
-      group by mt."memberId"),
   member_organizations as (
       select mo."memberId",
       json_agg(
@@ -192,15 +178,13 @@ export class MemberRepository extends RepositoryBase<MemberRepository> {
 
     coalesce(i.identities, '[]'::json)            as "identities",
     coalesce(mo.all_organizations, json_build_array()) as organizations,
-    coalesce(mt.all_tags, json_build_array())          as tags,
     coalesce(ma.all_affiliations, json_build_array())  as affiliations,
     coalesce(tmd.to_merge_ids, array []::text[])       as "toMergeIds",
     coalesce(nmd.no_merge_ids, array []::text[])       as "noMergeIds"
   from members m
     inner join identities i on m.id = i."memberId"
     left join to_merge_data tmd on m.id = tmd."memberId"
     left join no_merge_data nmd on m.id = nmd."memberId"
-    left join member_tags mt on m.id = mt."memberId"
     left join member_affiliations ma on m.id = ma."memberId"
     left join member_organizations mo on m.id = mo."memberId"
   where m.id = $(memberId)